DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2019-10-20 00:00:00Z and 2019-10-21 00:00:00Z

@Learath2 good idea mutes is a mess

@TacTic comes from https://info.ddnet.tw/info so you'll have to replace info.ddnet.tw in the source code with your own server

isnt that what i just said? xd

Learath2 @Learath2

13:39

yes

13:43

Learath2 i agree some team code stuff looks rly weird, i don't get why https://github.com/ddnet/ddnet/blob/master/src/game/teamscore.h exists

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/ddnet

13:44

solo and stuff is handled in many places its rly bad

13:44

if you want to check someone is in solo check it directly, not through this stupid class

13:45

also cankeephook and cancollide should be in the player or character

13:45

and it should also store the team info

13:45

no need for this

i think we also shouldnt care about ddrace16 at this point

14:13

ill try smth

Ryozuki: The idea with teamscore is that it's shared with the client iirc

14:23

to make sure the client also uses the same rules i guess

im changing it

Ryozuki: Get rid of TEAM_SUPER aswell while at it

im doing so

15:11

and also team flock

15:11

i deleted the whole file

but team_flock is actually used, isn't it? "team 0"

We could see 0.7 as an opportunity to rewrite the server in bash

ill need some more time for that rewrite

20:49

and weekend is over xd

@Ryozuki can you atleast tell me along what line are you going to clean it up, so I can also get it in the 0.7 branch?

21:51

I guess I could work on mutes while you finish that one up

i wanted to remove teamscore and save the team in cplayer and charactercore

21:52

cplayer cuz u can be in a team while ded

21:52

and u dont have a character while ded

charactercore so we can mirror it to the client?

idk

21:52

im not interested in 0.7 :p

Even in 0.6 you'll need to find a way to replace the now missing teamscore

21:53

it's used for prediction

ik

21:53

i need more time

21:53

but we dont need team super anymore

21:53

super is a character status

yeah, i wonder who thought it was a good idea to have it as a team

sounds good to me tbh

22:13

super as a team

22:13

at least in its current form

22:14

where you can interact with all teams

but u still have the normal team

do you? huh

22:17

oh, apparently

@heinrich5991 I thought you could interact with all teams aswell, but that doesn't appear to be the case

22:38

(or I'm just not reading this correct, been to lazy to test it)

it is the case

@Learath2 src/game/server/ddracecommands.cpp:111 set character team

22:40

to TEAM_SUPER

22:41

CTeamsCore::CanCollide checks for either tee having TEAM_SUPER

I stand corrected

22:41

Still, it's not a team, might aswell just check the character

22:42

I thought I was the one who loved to mix concepts just for ease of coding

if we want super to interact with all teams, I find this better than keeping the character in the old team

22:43

I dislike the concept of super complicating all our code between otherwise separate worlds though, so I'd be happy to drop that feature

We are pretty much handling TEAM_SUPER everywhere, no?

ye

22:43

super makes every code ugly

22:44

not everywhere

22:44

iirc

22:44

it makes no sense super for testing

22:44

only for trolling

falae

22:45

false*

with infinite jump and no freeze

22:45

its enough

22:45

true

22:45

*

@heinrich5991 It could probably be neatly wrapped into if(CanCollide(cid1, cid2)) that abstracts away most if not all the complexity though, no?

not really

22:45

you'd want to not have physics core have to concern itself with something like teams

22:45

at least I'd want that

22:46

i.e. having separate gameworlds with separate lists of characters, so that characters from a different team aren't even returned from the relevant functions

we must check for super, teams, solo, collision on, nocollision, hook on/off and if colision is globaly enabled iirc

@heinrich5991 Huh, isn't the physics core actually the most concerned part? Teams manipulate the physics of the game more then anything

see above

Having separate gameworlds while possible would complicate a couple things a whole lot

u sure

like spectators seeing everything and showothers

i think it makes sense for a team to have its own "world"

I see it complicating SUPER (maybe makign it impossible) and snapping a bit

Ofc it makes sense, but I don't think we have the tools to "merge" worlds to get the combined views

why not? except for deduplicated static objects like draggers etc?

22:48

just dump everything into the snap, as before

I mean it'd all need to be handled in snap with fairly ugly code, no?

no

Something like for(auto t: m_pTeamsCore->m_pTeams->m_pWorld would need to be in a lot of places

why go through teams?

22:49

just use your m_pWorld (edited)

The teams will have the CGameWorlds, it makes sense that they own the worlds

22:50

For spectators I mean, for you it's obv just m_pWorld of your own character

why teamscore

22:50

drop teamscore

22:50

there are worlds

22:50

and players in it

22:50

no teams as is

Some other class name that will hold the teams stuff

m_apWorlds

The team glue logic needs to go somewhere

@Learath2 in the CGameContext::OnSnap function, you could iterate through the game worlds

Hmm, I might try a rewrite like that tomorrow

22:52

Having an empty slate with 0.7 is nice as I get to try more

cammostripes

no uni?

I can't convince myself to go, too much social anxiety

22:52

might aswell be useful to ddnet

isn't it start of semester?

It already started

yes, a week or two ago?

Well exactly 3 weeks ago

then maybe go to uni ^^

Interesting that this month started on a Monday, heh

october the 0th was a monday, indeed

Oh no it's past midnight, I missed that

22:54

So close to a perfect month start

the 0th?

1st was tuesda,

22:54

y

@heinrich5991 I tried going last tuesday, just couldn't get myself to, even had butterflies in my stomach

mh

Such a weird illogical feeling, even though I know no one gives two shits who comes and goes to a class, I still feel very anxious

22:57

Anyway, I have to go to milan for some bureaucracy anyway, it's a lost day, might aswell do some ddnet at the end to atleast feel better about myself

Exported 124 message(s)