DDraceNetwork - developer

[ddnet/ddnet] Pull request opened: #1934 repair the problem that class selector appear when demo playing

I think this problem is solved, but this may be a little hack, I don't know the effect of this if-else condition. !2019-10-12-12-27-ScreenShot2

Ryozuki: here?

14:13

hmm, in that case @jao do you happen to know what bug https://github.com/ddnet/ddnet/commit/c074fdd30f8e6777bcb9e51bf9b38e3cdceec65f fixed?

fix all known bugs · ddnet/ddnet@c074fdd

14:14

Line 62 of entity.cpp looks very much like undefined behaviour

is the enevelopes synchronization feature removed?

ChillerDragon

[ddnet/ddnet] Issue closed: #1702 Demo bugs

I don't think so

do i have to activate a config or something?

14:34

because during my tests i could not get the synced enevelopes reset they were happily continuing in their animation state no matter what my timer did

Learath2

[ddnet/ddnet] Pull request opened: #1935 Add a limit to GetNearestAirPos. Fix #1931

There isn't really any sane behaviour here, so I just avoided the infinite loop. You shouldn't be in the wall to begin with :P

idk how envelopes work at all

there is this checkbox if the envelope is synced or not and usually synced envelopes are bound to the game timer. So you could use the startline to reset animations. I actually used that in a map. But now it doesnt seem to have a effect

well given i don't remember any change, you can either find someone who does, or bisect to find at which version this happened

yea

Learath2

[ddnet/ddnet] Pull request opened: #1936 Mark players as afk initially. Fix #1797

The whole afktimer code is quite ugly. I might rework it at a later date. For now this looks like an acceptable fix.

15:18

Learath2

[ddnet/ddnet] Pull request opened: #1937 Clamp ping to 999. Fix #1651

I wasn't even sure if we should fix this tbh, but might aswell have the discussion here.

15:22

Learath2

[ddnet/ddnet] Issue closed: #1559 Grenade double explosion fix is broken

@Learath2 why closed?

iirc the issues raised in there were fixed

i dont think so

Is binary still unplayable?

no but lunar base is

15:44

unless there was a fix that i missed

what's the issue? did you add the mapbug command to enable double explosions?

yes, didnt help

I don't see how it can not help

15:51

@jao you added mapbug grenade-doublexplosion@ddnet.tw to the config?

yes

15:52

its not emulating the old behavior correctly

But it works for binary?

15:54

there is no way it's not emulating the behaviour correctly, it explodes twice, it's not a very complex behaviour

it doesnt work as it used to on binary either

Oh I think I see the issue there

15:56

@jao can you test a fix? I can't land a double explosion to begin with

Learath2

[ddnet/ddnet] Issue reopened: #1559 Grenade double explosion fix is broken

im not good enough either xd

15:58

i can try tho

Learath2

[ddnet/ddnet] Pull request opened: #1938 Explode grenades twice at the end if they have lifespans. Fix #1559

Just by looking at the code I think this is what was intended but only testing can make sure.

@Im 'corneum

yes

^

Learath2

[ddnet/ddnet] Pull request opened: #1939 Always try extracting map before fail. Fix #1886

I think we should also store the SHA256 in the demo, but I'm not sure how to upgrade the demo format.

Oh we are so relying on undefined behaviour with those demo headers, there is no guarantee that you can read a struct from one implementation on another

because of padding or endianness?

21:11

if it's just padding, add a static_assure

padding and endianness both I guess

most structs that are written to files consist of chars only. integers are packed into the chars so endianess shouldn't be a problem. and padding should not be an issue either when you only have chars but yeah... proper serialization would be better

padding should not be an issue on most implementations

23:18

but what if someone compiles ddnet for some exotic ancient computer that requires weird alignment?

bors[bot]

[ddnet/ddnet] Issue closed: #1651 Why is max ping in scoreboard 1000 and not 999?

23:22

bors[bot]

[ddnet:master] 2 new commits

3e7cf12 Clamp ping to 999. Fix #1651 - Learath2 93ef46f Merge #1937 - bors[bot]

23:22

bors[bot]

[ddnet/ddnet] Pull request closed: #1937 Clamp ping to 999. Fix #1651