DDraceNetwork - developer

[ddnet/ddnet] Issue opened: #1908 add personal timecheckpoints

there are time checkpoints on some maps but not on all maps. they are useful for speedruns and it would be cool if i can add my own timecheckpoints and place them where i want.

ddnet-maps

[ddnet-maps:master] 1 new commit

8aaeb08 A garden - ddnet-maps

ChillerDragon

[ddnet/ddnet] Pull request opened: #1909 Fix filescore path

The filescore system did not handle map paths well that were an actual path and not just the mapname.

# before fix
$ ./DDNet-Server 'sv_map "DDNetPP-maps/BlmapChill"'
[...]
[2019-09-15 13:29:44][filescore]: opening 'records/DDNetPP-maps-BlmapChill_record.dtb' for reading failed

# after fix
$ ./DDNet-Server 'sv_map "DDNetPP-maps/BlmapChill"'
[...]
[2019-09-15 13:31:05][filescore]: opening 'records/BlmapChill_record.dtb' for reading failed

I called Server()-> in a...

Oh btw @fokkonaut regarding your filescore problem do you get


dbg_msg("filescore", "opening '%s' for writing failed", pSelf->SaveFile().c_str());

in the beginning of your logs? (sowwy irc peeps)

11:42

i did not investigate at all but i get this error in latest ddnet and it also kills /rank obviously.

i am not sure, will check later

11:48

But I am glad I am not the only one. Can this be fixed?

If this is the problem we have a point to start looking at

but as i said didnt investigate just an idea

What is this even?

12:50

i mean your pr

no, i dont get that message btw

bors[bot]

[ddnet/ddnet] Pull request closed: #1909 Fix filescore path

13:41

bors[bot]

[ddnet:master] 2 new commits

b39de87 Fix filescore path - ChillerDragon c146de6 Merge #1909 - bors[bot]

I was trying to split out voting in a testable subclass, but voting is just way too entangled with gamecontext, if anyone has an idea to abstract it out lmk

bors[bot]

[ddnet/ddnet] Pull request closed: #1903 Consistent spacing for getters and setters

14:03

bors[bot]

[ddnet/ddnet] Pull request closed: #1878 Add paused and spec to explayerflags

14:03

bors[bot]

[ddnet:master] 3 new commits

e112cf6 add paused and spec to explayerflags - Ryozuki f5f0786 Consistent spacing for getters and setters - ChillerDragon 0c34b6e Merge #1878 #1903 - bors[bot]

@fokkonaut hm sad so its probably me having a fucked up setup. Well my pr was just about if you provid a more complex map path like sv_map "foo/bar/baz.map" it wont search for baz_records.dtb but for something messed up like foo-bar-baz_records.dtb it is a edge case because most people have no subfolders in their map directorys

I just added a little bit stability test for ddnet++ circleci. Its a client that parses cmdlist and then spams chat commands with randomly generated arguemnts and does some random movements and reconnects. Then it authenticates and shutsdown the server with rcon after 40 seconds. The server runs with gdb and shows a backtrace. So in case a commit messes up basic functionality as chat/join/cmds player or player movement circleci would catch that. I was wondering if this is somethig that would be usefull for ddnet as well?

that sounds like a great idea

Ok I will try an pr when I find time.

16:37

The risk is getting a failed or timeouted circleci when my buggy client dies even when ddnet master is stable

def-

[ddnet/ddnet] Pull request opened: #1910 [DON'T SUBMIT] Super hacky image embedder (makes maps compatible to 0.7)

For #1906 Instructions:

Copy all maps to ~/.teeworlds/maps
Open map editor and click on load
New maps are now in ~/.teeworlds

Initially I tried to use map_replace_image and build something based on that but that turned out to be harder than this approach.

def-

[ddnet/ddnet] Issue opened: #1911 Loading maps seems to leak memory

Noticed when running #1910 . At some point I run OOM.