DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2019-08-02 00:00:00Z and 2019-08-03 00:00:00Z

I dunno whats happening, can someone help?

[ddnet:master] 1 new commit

968b5c1 Version 12.6.1 - def-

[ddnet-web:master] 1 new commit

33a12ad Version 12.6.1 - def-

hehe updated aur

@ChillerDragon you react with sad smiley because you want this feature not to be spreaded? Well, I made it and I think I can do what I want with it, also this gives the game a new mechanic, which can be used in maps, for example for race maps or some other puzzle maps maybe

Im not sure if it fits ddnet

Just imagine the amount of new possibilities

yes i do

11:14

and i see fun and so on

11:14

but much more work for map testers

11:14

and more annoying vasten100 maps

11:14

I am personally not a fan of puzzle maps i like it raw

It is off by default, and I think it is not too much more testing work, because the mapper itself should handle most of the stuff already

well

11:16

I am against every new feature ddnet has

It can also be enabled in big team 0 maps, or in faily maps. Maybe there is a noob who took the weapon, and only him and a pro are left, but the pro doesnt have a weapon, so they can swap, without saving just for the weapon

yes sure

11:16

that is awesome

11:17

and also gameplay should not be based on chat commands

11:18

it should be bindable in settings for nobos

I wanted to add that just today

11:19

Like showothers

Ya thought so. Just wanted to make sure you don’t bring the trash parts of our mods to ddnet (like everything being Chat command based)

I wanted to make it with F4 first but thought like nah, not everyone will like it. Then I thought about a client command, which is sent to the server, but for that we can also just use binds.

Hey, I need some help. In my pull request, the server crashes when it gets shutdowned, using the shutdown command in rcon. It fails here: delete pKernel;, engine/server/server.cpp#L3050, any idea why?

which PR?

13:10

double delete or wrong delete order?

The one for droppable weapons

13:37

I have no idea whats happening

Have you tried gdb?

I am not on linux, and my VS doesnt show me the list of last called functions...

u have a vps tho :p @fokkonaut

15:58

sudo apt install gdb

15:59

gdb --args ./DDNet-Server "shutdown"

15:59

gdb> run

15:59

gdb> bt

(gdb) bt
#0  0x0000000000000000 in ?? ()
#1  0x000055555557f04d in main ()

16:18

nice bt

not using mingw on windows tze tze

I do

16:27

I mean, I have it

16:27

But I cannot gdb

16:28

on ddnet

u need to compile in debug mode

not in executable format: File format not recognized

16:32

because vs i think

no

16:32

gdb works

not for me

ur doing something wrong

idk

16:34

why doesnt it work?

16:34

for ddnetpp it does

figure it out urself

thans

Uf

16:36

Ryo be nice

compile with gcc?

How?

are you compiling with vs?

yes

select mingw in cmake lol

well

16:41

how

download src, open cmake gui and when you hit configure it should ask for it (edited)

What is gmake gui?

typo sry

So, I open cmake gui

16:43

And then I select my repo

did you never use cmake?

Only using VS, or on my VPS

16:43

But never the gui

it literally guides you what to do

Not really

where the src code is (dir with cmakelist in it)

So, I click on MinGW makefiles?

and then you make a subfolder and call it release right under

16:44

yes (edited)

16:44

after configuring is done u hit generate and head over to the release dir

16:45

and then u do mingw32-make -j (number of cores)

okay

16:45

No targets specified and no makefile found.

did you generate and are you in the release dir

16:46

not your src dir

you mean the build dir?

yes

yea, i am

did you generate in cmake

yes

16:46

now

16:46

Wait

16:47

it throws 10000 warnings

16:47

one second

let it do it's thing

Yea, its done, i started with gdb

16:49

(gdb) bt
#0  0x00568e0f in main ()

16:49

still

16:50

this doesnt help me :(

idk then

Why does it crash on shutdown?!

16:50

@Learath2 I need you

Im very much on vacation

I think you need to configure DEBUG as CMAKE_BUILD_TYPE

16:51

in cmake gui

and now generate again?

yee

Program received signal SIGSEGV, Segmentation fault.
0x0040d592 in main (argc=1, argv=0x16915d8) at D:\!TeeworldsCoding\git\ddnet\src\engine\server\server.cpp:3050
3050            delete pKernel;

[ddnet/ddnet] Pull request opened: #1878 Add paused and spec to explayerflags

I think client should know about this, maybe we can do something with it in the future. It also may help with https://github.com/ddnet/ddnet/issues/259 but i didn't figure out yet a way to fix it.

yea, tells me what I know already

atleast it works now

coding in windows poggers

poggers

brownbear

2

cammostripes

2

@Ryozuki could you maybe debug this, please?

if you switch permanently to linux and embrace true freedom yes

lol

:D

he already found the bug

the output most likely wont be any diffrent

its that ur using windows

xd

@noby quit please mac user

u

@fokkonaut idk what ur working on anyway

look at my pull request, it fails

i spend 40 mins like a retard trying to fix a bug but its shit

I dont know why :/

when u do /pause and /spec server puts u in team spec, or thats what i think it does rn, but with the explayer flags for pause and spec it may not be needed but older version may need it which is why i will go play dota 2 rn

xd

oh yeah that thing

@Theowyn can you debug my thing?

why do you think my bt will be any diffrent than yours?

Its not about the bt, I just cant explain myself why this happens. Maybe you get something by looking at my code

I mean you added over 500 lines of code

But it is not much, only because its a new entity

wdym 500 lines are not much ._.

xD

well does it even compile without the new entity?

it does compile, also with it

17:08

but it crashes if you type shutdown

oh yeah forgot

17:09

does it crash without new entity xD

i think no* (edited)

well then you know where to look for

inside of my code ofc

17:10

but, I dont know what could cause it

17:10

Because on my server it doesnt break

on your server? (edited)

okay, great

17:13

its not my entity

17:13

i completely removed it from my project and tried again

17:17

WHAT

17:17

xd

Does it crash without?

No, I know what causes it, but not why xD

17:19

its so stupid

Wat

compile with -fsanitize=address flag

Seems like I have fixed it

Ye i was about to suggest that

17:20

Valgrind and ASan are very nice tools

yeahh valgrind is nice

@Learath2 I really dont know what went wrong, maybe because the function was called ConDropWeapons, which is almost like ConDropWeapon, which is used inside of ddracechat?

17:22

I have no idea, but this should have fixed it now

17:22

For me it didnt crash now

the naming shouldnt cause anything to crash but it might cause u to be confused and write things that crash

UNDEFINED BEHAVIOUR

Well, without my function with almost the same name in server.cpp, it didnt crash

17:24

So i renamed it, to be more specific (which is even a better name, lol, more fitting) and now it works

17:24

I really would like to know what on earth happens there xD

use one of the two tools suggested above because it sounds like memory corruption or something like this and the fact that renaming "fixes" it might be coincidence

Yeah thats ub

17:25

Definitely not the proper fix

okay wait, what?! it still didnt work for the checks

17:27

but at least CircleCI did it now, wonder whats the issue for Travis

u should check it for memory corruption before making pr

How does that work

@fokkonaut are you on linux or mac?

WINE

Windows has no tools for this

17:29

Only garbage like dr memory

17:29

Maybe mingw implements the address sanitizer aswell

17:30

Try -fsanitize=address while compiling

How to apply it

Hmm you need to add it in cmake

17:31

Maybe searcb on github for my commit on Address Sanitizer

17:32

I think I accidentally commited it once

And another thing: Entities have tthe Reset function, but what if I want to give it a paramter? Do I have to remove the virtual then, or create a new function for it?

You cant implement a virtual with the wrong params iirc

17:34

But I'm not much of a c++ person

you can create one with parameters but it won't be called by the virtual one, so you should make sure there is a reset function without params also (edited)

which will then call the one with params?

18:06

virtual void Reset() { Reset(true, false); };
void Reset(bool Erease, bool Picked);

18:06

would this work?

18:08

@Deleted User

yea, I guess it would (edited)

18:14

erease? did you mean erase?

yes xd

dann schreibs richtig

@Learath2 I found out, the crash is undefined behaivor, because I registered a command inside of server.cpp, which has the CFGFLAG_GAME applied.

[ddnet/ddnet] Issue opened: #1879 Undefined behavior when registering an unchangeable command with more flags

When registering a command here https://github.com/ddnet/ddnet/blob/master/src/engine/server/server.cpp#L3033, so that you cant change it ingame, like sv_test_cmds or sv_rescue AND applying a flag, like CFGFLAG_GAME aswell, the server crashes on shutdown for example

lol did u know twitch chat is irc? lol

nope, did not

funny huh?

@deen i found a weird bug, when u press d it spams d it doesnt hold it

19:35

might be a sdl bug?

19:35

actually

19:35

with any bind that i hold

19:35

it spams it

19:35

like show chat

19:36

it shows and disappears super fast

19:36

when i hold it

12.5 on wn10 doesnt for me

try 12.6.1

also wors

19:38

i tried holding down show chat and the chat didnt start to flicker.

@ChillerDragon try pressing d in a plane zone do u slow down?

19:39

d or a

19:39

on 12.6.1

19:39

idc about 12.5

oh that sounds like a crucial bug

ye its very werid xd

19:39

i saw him testing it on my server

but cant repporduce with latest official release on win10

ok it might be a thing of my setup

19:40

idk how

19:40

i tried in 0.7 and it happens too

19:40

xd

19:40

ill reboot

dafuq

19:40

nobody reported such thing for 0.7 yet

still happens

19:42

idk why it happens

19:42

xd

Oh @noby so you saw it but u couldnt reproduce?

ya wait

just linux things

19:42

xxxD

ok i tried on factorio

19:44

eh

my char stops and alks

when i try to have two clients open and also screenrecord it gives only 10fps

maybe my keyboard is starting to get broken

19:44

but i dont know

19:44

fck this

so it doesnt show the spamming of the keypress very well

19:44

but when he moves slowly

Is any one up to sing ?

hes very quickly pressing and unpressing the direction

wait factorio also uses sdl

19:45

i need a non sdl game

19:45

xd

i tested current master on debian10 also worked fine

il ltry terraria

since also vanilla breaks i blame u xd

19:46

minecraft best xd

damn

19:46

something is wrong with my keyboard i guess

19:46

time to buy another

19:46

xd

19:46

i think i had this for 4-5 years

19:46

rip

oh u can try deactivating key repeate in a text editor

19:47

and then hold down a key and see if it gets inserted multiple times

are mechanical keyboards worth?

uhm my laptop has one i like the sound xd

19:49

but idk for me they are not worth it as far as i can tell

19:49

but im nobo gamewr and typer so prollly not worth a lot what i think

@Ryozuki they are best (edited)

19:51

logitech g910 is insane (edited)

150€

19:51

hmm

19:51

to much

for 5 yrs of typing

mine costs 50€

u dont even pay ur os xd

xd

urs is buggo

later ill dualboot into windowsto make sure its keyboard xd

19:53

ill have to enter the evil disk in my pc

19:53

i have linux on a 500gb nvme sdd and windows on a old 1tb hdd

19:53

i never boot windows tho xd

19:54

well luckily its not a serious problem

19:54

xd

@Ryozuki i have g910

hmm

19:55

can u even pay tw with it? xd

19:55

can u even hook?

bro

yes, i hook with keyboard

hook is with mouse

19:55

use ur brain xd

lol u hook with mouse?

????

19:55

right click

SPACEBAR

spacebar is jump

no up arrow is jump

lol no

19:56

@ChillerDragon u put to much pressure 1 hand

19:56

u have to hook and hammer and aim with one

19:56

and move with other

yes i do

so ur trolling me

myb

troll

19:57

so ur mouse hold is not buggo?

19:57

but even walking. Can u even hammerrun?

19:57

do a drag part xd

smh the first thing u thought was to blame my anticheat

19:57

lmao

would think the same tbh xd

ofc

chiller thats understandable for u

19:58

lol

i still think its onbgys antibot who injected a rat in ryos hardware

/w ChillerDragon dont tell him

/c sorri

nt

19:58

im not using windows

@Ryozuki if you use Arch, they upgraded to SDL 2.0.10 recently

yes but i tried terraria and it also happens, it doesnt use sdl i think

using wayland?

no

20:12

on x

20:12

i3wm

20:13

pressing d on my terminal (st) looks smooth

20:13

i think

20:13

xD

try xev

Exported 328 message(s)