DDraceNetwork - developer

Does anyone know why the over-head emotes on DDNet fng2 servers are smoother and slower than on any other server? I would like to implement that as a feature I checked the source from Jupeyy but couldnt find anything

02:14

@noby u maybe?

@fokkonaut does the decimals thing happen with the latest patch on a latest patch server? I assumed that was an artifact of the misdetermined message type in hud.cpp

I havent tested it, just saw it yesterday again and thought, man i wanted to report this long ago already xd

yeah I wanted to fix it aswell, but I think the Sv_Record fix should cover that aswell

I can test it in some minutes

07:18

nope, still not fixed

07:19

the deci seconds are still paused when you /pause

07:19

same for spectator mode btw

def-

[ddnet/ddnet] Issue closed: #901 Teleporter behavior

07:29

def-

[ddnet/ddnet] Issue closed: #1713 MinGW with GCC 9 shows lots of warnings

@fokkonaut but did you test it on the new server? the server was sending the wrong flag

I pulled ddnet master and did it on my lan server

07:29

Just compiled

okay, well I can fix it tonight, or you can take a look if you want

07:30

shouldn't be too difficult

Btw: what is the difference here? GAMEINFOFLAG_RACE_RECORD_MESSAGE (edited)

@fokkonaut DDRace servers send m_DDRaceTime and m_CheckpointDiff in their record messages

and this one GAMEINFOFLAG_RACE_SHOW_RECORD is not even used

scratch that, ddrace servers only send m_DDRaceTime

@Learath2 Why does DDNet send the RACE message then?

DDNet and old Race servers send the ServerRecord instead

ah

07:34

https://discordapp.com/channels/252358080522747904/293493549758939136/602765119482757122

That was tricky, I actually wanted to remove that feature but wasn't sure if it was a good idea so I added a flag instead

oh wait

07:35

I see, it is used

if a server sends that, the timer on top will display the server record instead of the server time

is cool

07:36

I mean, for custom servers, not officials

it's behaviour exhibited by old race servers iirc

If I set a flag, then check for something and want to remove a flag then using &= ~FLAG, do I have to check whether the flag is in already using m_Flags&FLAG, or will it just automatically detect thta

Well the pattern is that usually we set the flag only after the check

Well, I have 2 checks for my case

but to remove a flag &= ~Flag should always work and -= Flag will work if you know that the flag is set for certain

so, if I use &= ~FLAG, I dont have to check for it first?

nope no need to check

great, thanks

07:44

https://github.com/fokkonaut/BlockDDrace/blob/d6fbd34c7d67d2e1ea312aa59d01c5673919f7a6/src/game/server/gamecontroller.cpp#L595 I have some checks here, can you tell me if I can format that stuff better?

@fokkonaut this looks more organized tbh, I'd keep it

07:46

but you could move the definition of pSnapChar up so that you can merge the two ifs setting GAMEINFOFLAG_ALLOW_ZOOM

07:47

I wouldn't tbh, readability > linecount in this case, especially your peformance gains would be minimal

Okay :)

@fokkonaut I don't think we can fix the decisecs while in freeze

I am just looking at the code

took a look and we seem to use the race tick for the decisecs as the timer itself doesn't have the precision

07:51

we could possibly fake it

07:51

while paused, not while in freeze*

Freeze isnt affected?

07:52

Being spectator is affected

07:52

ah yes :D

nono, it's just in pause/spec, you just don't receive the ddracetime anymore

Yes, thats what I got too :D

07:52

I ended up in engine/client/client.cpp, where it doesnt get the snapshot while spectating (edited)

you do receive the snapshot, you just don't get Sv_DDRaceTime iirc

sec (edited)

oh that has nothing to do with it