DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2019-06-30 00:00:00Z and 2019-07-01 00:00:00Z

[ddnet-maps:master] 1 new commit

f06c425 M Springlobe 3 - ddnet-maps

@heinrich5991 do you know why we aren't using the c++ operator sugar for json-parser in ddnet?

10:32

the json_.*_get functions lead to pretty darn ugly code

I most definitely went overboard breaking compatibility, will have to rewrite this later :/

@Learath2 I used operator[] in my json parsing routines pretty heavily

12:30

(and operator char*, operator int etc. after checking the type)

where did you use json?

in my proof of concept http master servers

12:30

^^

12:31

I'll prolly have to re-do all of this anyways, I just dropped way too much compatibility

12:31

like the servers can't even register on old masters

^^

12:31

why did you even touch this file?

which file?

src/engine/server/register.cpp (except maybe renaming it to register_legacy.cpp and doing some search&replace

12:32

)

Oh, I was pretty out of it when I was coding this

12:32

40 hours without sleep and you can't really think much

12:35

Image attachment

the registering is the hard part™

top left buttons

well as you can see, it registers just fine, just sends the wrong info as I couldn't bother building the json

ah

12:36

I just had a static JSON there because register didn't work

12:36

couldn't tell that it works from the screenshot ^^

but I completely cannibalised register.cpp

12:37

I'll give this a git commit, then I'll start fresh, with two new interfaces

cp register.cpp register_.cpp;git checkout -- register.cpp;mv register.cpp register_legacy.cpp;mv register_.cpp register.cpp

I messed with server.cpp aswell

12:38

I don't mind starting over anyways, it's not too clean

@heinrich5991 can you help me link json-builder?

I just manually wrote the json

13:00

with str_format

13:00

but basically, just do the same as for json-parser I guess

I'm shocked

13:01

you? not using a library?

shrug

13:01

what goes wrong if you do it the same way as json-parser? (edited)

Well I tried linking it the same way, it doesn't work, and you don't mind me hacking it together with str_format

as long as you properly escape it (I think we have a JsonEscape function)

I get a lot of

duplicate symbol _json_string_get in:
    CMakeFiles/json.dir/src/engine/external/json-parser/json.c.o
    CMakeFiles/json-builder.dir/src/engine/external/json-parser/json.c.o

have you found out why that happens?

13:02

i.e. do you see the duplicate symbols?

13:03

or are you maybe accidentally linking json-parser twice?

13:03

(if that's even possible, dunno=

I only see one json_string_get

13:03

json-builder depends on json-parser, so maybe it somehow induces another compilation of it

13:04

cmake is pretty much blackmagic for me

link to the github repo of json-builder please

https://github.com/udp/json-builder

udp/json-builder

The serializing counterpart to json-parser. Contribute to udp/json-builder development by creating an account on GitHub.

13:05

meh, this powerbank cant sustain a laptop, I guess I'm done for the day

bye

13:06

why don't you have an outlet near you?

circuit breaker popped, and electricians don't seem to work at a reasonable price on sundays

13:08

I have a couple more minutes

can't you go to uni or so?

13:10

or idk, does starbucks have power outlets?

they do, but italy doesn't have starbucks

13:11

except for 2 in milan, but milan is pretty far for a starbucks

perhaps a library?

13:11

ah, probably not on sundays

I'll charge it at the neighbours place

my client crashed while i was editing a map (just held shift and wanted to paint a big area (20x40 or so)

14:57

obviously with my mouse (edited)

:/

u have latest version?

14:58

should be fixed

do you have a coredump?

12.5

14:58

no heinrich

weird

when i released the shift key and mouse the game crashed immediately

@fokkonaut os?

windows

huh, the breaker decided to work again

18:10

I wonder what changed

so many warnings with gcc9

i mean it should improve the code

[ddnet-web:master] 1 new commit

bb31104 Tournament 48 - def-

19:08

[ddnet-web:master] 1 new commit

3f7d68a upd - def-

Hmm, I don't really like this -Wdeprecated-copy who decided it'd be a good idea to deprecate implicit copy constructors?

@Learath2 it's only deprecating implicit copy constructors for specific situations

19:28

e.g. when there is a destructor

why though?

because it indicates a programming error

19:29

and it makes sense for that, if the destructor does anything at all, the implicit copy constructor can cause that work to get doubled, likely leading to double frees

@heinrich5991 do you happen to know why IEngineMasterServer was needed?

19:45

(or any of the IEngine* variants of the interfaces at all)

presumably because game is only allowed to access the non-IEngine* variants I guess

19:48

was violated by ddrace code on one occasion apparently, the background map in the menus

@heinrich5991 another small Q: Is it better to request the interface from the kernel, or pass it in while initializing?

20:02

Seems we use both

for highly convoluted stuff use the kernel

20:03

if you just need one interface, pass it

20:03

(dunno)

[ddnet-web:master] 1 new commit

a103133 upd - def-

[ddnet/ddnet] Pull request opened: #1801 Add command to resume from pause if tee has been moved

[ddnet/ddnet] Pull request opened: #1802 Prediction fixes

I believe this fixes #1671 (uninitialized variables). Some other things: Use new ddnetchar fields in prediction, small fix for prediction of moving pickups, fix the freeze end tick in ddnetcharacter (will add it to the client later) Also adds a setting for choosing between new/old antiping for grenade like suggested in #1683 (cl_antiping_gunfire 0 to disable).

23:19

[ddnet/ddnet] Pull request opened: #1803 Fix double pause due to spec

If a player is in /spec (sv_pausable 1 required) and would then use /pause, the tee would respawn, but the player would still be in /pause instead of playing again. With this, the player will resume completely

Exported 100 message(s)