DDraceNetwork - developer

do we have a convention when to use 0 and when to use '\0' ?

17:42

when setting a specfifc index of a cstring

17:43

guess ima use 0 since it has less characters

ChillerDragon

[ddnet/ddnet] Pull request opened: #1790 Add ctrl-k delete in client console

Extends shortcuts from: ed8a0b5eee8ed86ba53021e1799a3c40973f192c e9f8bd42b7dd6d6b2553c19d785b1bf6f71a455a

learned a new shortcut^^ if i only knew that early i wouldnt have to type all the stuff agian

0 for ints, '\0' for chars

meh

it's better to be explicit about the type instead of converting

18:04

and nullptr for pointers

yea thought so that ' \0' is more stringy

18:05

but \0 translates to NULL => 0

18:05

and i thought we use NULL for points not nullptr

if you turn the compiler warnings / clang-tidys on hard enough they will force you to do as I said

18:05

oh, in real ddnet code? probably a weird mix of everything

im talking about my pr

then you know what style i'd prefer

k i guess ima forcepush ur style

ChillerDragon

[ddnet/ddnet] Pull request opened: #1791 Ignore visual studio project files

Lets have atleast the cmake stuff somehow similar to the upstream c:

18:09

or more like the build ignores

18:12

Hmm .vs seems to be covered by *.vs already im not sure what is the cleanest thing to do

are there other files ending with .vs?

18:13

or is it supposed to just match the .vs dir?

idk who why created *.vs but i always have these annoying .vs directorys in my project so ignored them in upstream

if visual studio isn't creating other files with .vs ending, then just remove the *.vs and add .vs

i use a lill vscode and visual studio on windows and linux and from what i saw it only created out/ .vscode/ and .vs/ but im not 100% sure

18:17

ok \0 is fixed now

remove *.vs

alright

def-

[ddnet/ddnet] Pull request closed: #1789 Add ClHTTPFakeUserAgent

18:38

def-

[ddnet/ddnet] Pull request closed: #1786 Fix zoom if dummy is connected and only one is able to zoom

18:38

def-

[ddnet:master] 2 new commits

1664a6e Fix zoom if dummy is connected and only one is able to zoom - fokkonaut d9286e8 Merge pull request #1786 from fokkonaut/master - def-

still nobody knows what the mysterious useragent was o,O

https://forum.ddnet.tw/viewtopic.php?f=68&p=67955

we still use a forum? lol

Discord is not available behind the GFW

great fire wall?

yes

what does that mean?

Discord is blocked in China and you have to use a VPN, which is not that easy since they also get blocked by the firewall

18:41

ddnet.tw has no firewall hehe

18:42

i guess rip master ddos

nah, works for me

hm weird

works for me, too

oh men poor china

18:42

my internet works tho

18:43

ah might be my vpn

traceroute it

maybe ur fw filters vpns?

not knowingly. our hoster might