DDraceNetwork - developer

@heinrich5991 so what about braces? Do we have a style guide for that?

always braces

08:54

even if it's not in a style guide

i tried to enforce that in my mod when i started. but latley i found that no braces is easier to read and less lines. I think it is a style question. So ddnet code base wants braces always?

09:21

a

09:21

if (true) {

09:21

// foo

09:21

} else

09:22

printf("bar");

09:22

sorry for multiple lines but my client cant do it -.- uhm i think that is really ugly if the if has braces and the else doesnt

09:22

but it is in ddnet code all over the place

definitely don't remove braces from code that has it, especially when you're not doing anything else with it

09:52

I prefer having braces everywhere, I will ask for braces if the other branch also has braces, or if we have a dangling else

not having braces is cancer and inconsistent as hell mostly (edited)

ok good to know so braces everywhere -.-

11:25

oh and heinrich you mentioned this no style changes if you did no other changes multiple times now. I see it makes sense to have cleaner commit messages. But how are we going to improve the style then? I mean demo.cpp for example has even these javascript style braces with opening brace starts in same line as if. And this is really irritating while reading the code imo.

11:28

we have 4175 if ( while ( and for (s .-.

or if its so short it doesnt need braces maybe u can use ternary

yy sure but that is mostly not the case if u use normal people variables

11:30

onbgy vars can always us tenary: a = bs ? fc : tt

11:30

ok good point

i could even imagine u use braces for a new namespace because u run out of var names <2 characters xd

lmao

11:33

then i can start using undescores

:troll:

Is this interesting for ddnet? I think no? https://github.com/teeworlds/teeworlds/pull/2148

Remove "weak" hook by ftk · Pull Request #2148 · teeworlds/teeworlds

This fixes #541 Depending on the order of character spawn, players have stronger or weaker hook on each others. The reason is that velocity calculation of characters is order dependent: Example: pl...

nah weak is needed by maps

i got a slightly different fix by @qshar to remove weak hook and its generally been a good thing

11:34

idk how itd work on ddnet

How does qshar do it?

ill let him decide if its okay to post it here

imo weak is a feature. In ddrace weak is used sometimes. And imo also in other gametypes like vanilla/block/fng giving a stronger who to the person who survived longer makes sense to me.

@noby weak hook was removed for a day until it was deemed map-breaking

oh

oh, okay

sucks that they fix it in vanilla -.-

xd

it makes sense

11:36

it's a clear bug

yes but it can be seens as ferature

If ddrace will ever be on 0.7 or higher we need to reimplement lots of bugs xD

yes

11:36

lol the issue is from Ubu o.O

11:37

he was waiting 7 yrs for this pr haha

a lot of issues linger this long

ikr

remember the date of the last actual release that wasn't just security fixes

no

11:38

xd

11:38

it was before i was born

11:38

if u look at 0.6

11:39

so heinrich what about style in demo.cpp? are we planning to leave everything as it is until someone rewrites the whole file?

def-

[ddnet-web:master] 1 new commit

c984f24 Add donation - def-

I can search for a commit to remove week hook if you need, its not a secret of course

https://github.com/ddnet/ddnet/commit/2b084645276baa37b7a31aafa3fab0e3a323201b

Same hook strength for everyone (by cinaera) · ddnet/ddnet@2b08464

that looks more like the fix i saw

11:59

does it have different results than the method fokkonot posted

deen

12:07

you copy pasted

12:07

from our mod

12:07

caught you

@fokkonaut lol you should know this

what?

The strong weak thing

?

15:04

I just sent a link of the pr in vanills

i guess n0b0 means that you should know that missing weak breaks maps since you are a expirenced player @fokkonaut

Ah

15:05

yea

Yup

15:20

Sorry i wasnt clear enough

12pm

[ddnet-web:master] 1 new commit

4fc56be Add BenZ - 12pm

uhm @fokkonaut was there a knownn bug with shiftes names?

20:15

ja

ah k

https://github.com/ddnet/ddnet/issues/1752

Nameplates aren't always centered · Issue #1752 · ddnet/ddnet

Appearently the nameplates are sometimes, rarely(when the client is open for a long time) and not reproducable not centered. Related file: src/game/client/components/nameplates.cpp src/engine/clien...

@Deleted User seems like its not always starting in the tee center

20:17

look at Pfandflasche

woudlt call 20 min long

how

20:17

this is not 20 mins xd

ah its 22

20:17

22:17

20:17

xd

how

is it 36 min race time or play time?

time in germany

20:18

xd

what does Played sas?

20:18

say*

how can u play less than ur race time

i thouight its played

20:18

but my client is so old it only shows the clock

20:18

22:18 european time

20:18

xd

20:18

i red wrong

20:19

its more than 30 min all fine xd

???? xd

im not as good with numbers as u @archimede67

xd

@fokkonaut is centered for me

20:29

maybe not the newest client?

its 1 tee

yeah but still, newest client?

no

1

ah

@Deleted User Pfandflasche is not centered xd

@fokkonaut it is for me

20:47

and he uses old client

20:48

its not the same bug like urs.. urs might not even be a bug in terms of coding, but an overflow or something like that

bcs its pretty impossible to reproduce

20:48

dude

20:48

stop ignoring

fokko

Im just saying this is not centered

its not centered at all xd

its an old client

yeah

@Deleted User its not in the middle

@archimede67 even posted the fix

@ChillerDragon stop playing on old

20:49

u nobo

lehgacy swagger

chiller reporting fixed bugs

boi i pinged fokko because i wasnt sure if its reported already -.-

reminds me of your mute "fix"

xd

i have the feeling jao doesnt forget that -.-

every time you complain about bugs I will remember it

mute was clearly a feature

why i had one day in editor so many crashes ?

latest version?

20:54

see thats why im not updating

20:55

crashes in editor sukk -.-

best bug report

but in last version they fixed some bad bugs and created new stuff (edited)

stuped

how to reproduce @Deleted User

kms ¿ (edited)

@ChillerDragon you will need to update if you want the replays feature

no edit in developer pls

stupet

cherry pick git magic @archimede67

into good ol ddnet 6 client

first version of ddnet

(edited)

@Deleted User what did you do before crashing editor

zoom out a bit and release after mouse 1 and crashed , at least i save after i do somethink , i didn't lose progress

21:01

are you sure you have the latest version?

yes

tell me the version

is there a txt bug report ?

21:03

https://gyazo.com/cc2cf5bd65faa6049c9fdfe0078a69a8

Gyazo

strange

zoom makes a difference?

21:04

can't reproduce

me neither

can you do it consistently

ohhhh i remember i also was spectating someone in game ...

did you have a tile selected also

there was a bug with this but it should be fixed in latest ver

yeah

i found demo xD

dont think that it helps xd

Aim_10.0_2019-06-01_18-35-08.demo

1.44 MB

21:10

Aim_10.0_2019-06-01_18-25-31.demo

3.73 MB

21:11

lol 1st demo i crashed editor in 30 seconds

what do you want us to do with that??

dont be mean @archimede67

nah but how can a demo help as it doesn't record editor

men he tried

xd

https://www.youtube.com/watch?v=3uoM5kfZIQ0

tempura1234

Why I Don't Watch CSI

xd

22:19

they name shifted back xd

22:19

without reconnect from me or pfandflasche

22:20

what was casuing it that it behaves so weird?