DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2019-05-30 00:00:00Z and 2019-05-31 00:00:00Z

if someone could compile ddnet in release mode on windows with msvc and with debug symbols, that'd be awesome

00:45

I'd like to take a look at the annoying aio bug

00:45

@Learath2 unrelated, in 0c13c8cebb09b7798309ea0317a2e85885fb5697, you only print utf16 characters that consist of one code unit to the windows console. is this intentional?

@heinrich5991 that's a pretty crude hack tbh, I barely have an idea why it works

@archimede67 mon son est revenu mais que lorsque j'allume mon pc avec un certain casque

xd

@heinrich5991 I think that commit was after hours of messing around, I didn't really want to think much after it started working

okay

also it seems to be leaking memory

ggwp

12:21

xd

imagine spending 8 hours trying to figure out why windows won't just print what you tell it to print on the console

12:27

turns out the console is a special device in windows and it only accepts utf16

because its windows

12:27

wot

12:27

utf16

12:27

why xd

I guess bill gates thought 16 was a nice number

@Learath2 but you don't output utf8

12:40

*utf16

12:40

you only output utf16 without surrogate pairs

12:41

(have you tried characters outside the bmp?)

idk what I output tbh, I just know that if you encode the codepoints in utf16, shove that in a wchar array and pass that to WriteConsoleW it looks correct on the console

12:43

I'm pretty sure things outside the bmp won't look correctly

12:45

@heinrich5991 I think I wasn't sure if the wchar can hold characters that consist of two code units

I think wchar_t is a code unit

12:46

so you need two wchar_ts for each code unit outside the bmp

I believe wchar_t was implementation defined in size

12:47

also the way i output to the console isn't complete, it fails to work with redirects

wchar_t is probably not implementation defined in size on windows

have to check GetConsoleMode and if it's redirected you need to use WriteFile instead

12:49

Anyways, I think WriteConsoleW takes a byte array, not specifically wchar_t so could probably drop that

WriteConsoleW probably takes wchar_t tbh

12:50

ah no

12:50

const void *

well msdn doesn't say so

https://docs.microsoft.com/en-us/windows/console/writeconsole

WriteConsole function - Windows Console

Writes a character string to a console screen buffer beginning at the current cursor location.

@heinrich5991 btw are you thinking of cleaning that up?

not right now

12:51

no

12:52

I wanted to fix the stupid aio thing

12:52

but it just doesn't work

12:52

or rather, I can't find a mistake

wait you can reproduce it?

you can reproduce it with the testcases IIRC

12:52

not sure

I think I was the last person that can reproduce it reliably, and I upgraded to win10, haven't tested whether it happens still

12:53

on my computer it was an instant crash with aio stdout

12:53

like a 100% of the time

really.

12:54

also in the debugger?

you even tried to debug it with teamviewer after i gave up iirc

12:54

yep

argh

but it crashed deep in ntdll or system32

because of an invalid pointer I guess

12:54

should've tried harder

not one that I could see

ok

12:55

can you try whether you can still reproduce it?

well I can install msvc and try again, maybe it still happens

where does one even get msvc?

msvs it's called, these days

12:55

https://visualstudio.microsoft.com/

Visual Studio IDE, Code Editor, Azure DevOps, & App Center - Visua...

Visual Studio dev tools & services make app development easy for any platform & language. Try our Mac & Windows code editor, IDE, or Azure DevOps for free.

12:56

top left is msvs, rest is unrelated products :<

oh, need the ide aswell right, that will take some time to download

I currently have around 20-200KB/s. can you beat that?

that sounds horrible

12:56

what happened to germany?

aio is async io?

yes

does it work on linux

yes

is it enabled there?

I don't know if by chance, but probably

12:57

yes

12:57

@Learath2 I'm on the train, so I guess it's okayish

oh, that's great for train internet

at least they provide free internet for everyone these days

I get 5 MB/s at home

12:58

which is good

:o

12:58

monkaS

much better then back in turkey where I got 0.8 MB/s

at uni I got 600MB/s ^^

but literally everyone else gets a 800mbps link here, just my stupid old apartment

bytes or bits?

(not via wifi though. bytes)

i got 600/600 on home xd

600mbps?

uh nice

(edited)

70mb/s

@Ryozuki fast.com

12:59

plz

i got 75kb (edited)

french detected

Image attachment

I wish I got 600/600 at home

ew

never knew that site

12:59

xd

best speed test site

12:59

no clutter

I've been begging them for the last 3 years to get fibre

barcelona got fibre everywhere and its more worth to have it than dsl nowadays xd

which site

the office building next to us already has it so it's not too too hard to get a couple more fibres routes

fast.com

but the guy who owns the apartment, he is so old :/

@Learath2 I KNOW

13:00

i was on a old building before

13:00

and they didnt want fibre

i have 46Mbps

they were fcking 70 year old

13:01

xddd

13:01

lucky i moved

13:01

and the best is that

oh, visual studio seems smaller nowadays

instalation was paid by the company

13:01

not ourselves

13:01

but old ppl dont understand shit

13:02

it pissed me for lot of years

13:02

xd

to be honest I'd be okay with paying the price if it wasn't absolutely insane

what's insane?

(i dont pay it, but i think its 30-50 month the internet)

if I want them to route one for me it's around 2000e to route it, and 300e contribution fee every month for 3 years in addition to the regular fee

@Learath2 I think you only installed the installer

xd

If the apartment owner gets 80% of the residents to agree, they waive the 2000e, and the 300e is split up between everyone so it's nothing

being able to download at 70mb/s and play tw without lag is pure pleasure danAmazing

danAmazing

@heinrich5991 lol I didn't mean that small

13:04

I thought it'd be around 5-6gb but it's only 3

https://github.com/ddnet/ddnet/pull/1757

update desktop db after install by Ryozuki · Pull Request #1757 ...

So it let you use ddnet links

13:05

what should i do with this

I think: make it a message to the user to execute this command

why not just execute it ourselves?

thats what im doing rn

does it get executed on a logout/login?

wat

13:07

ah idk

because we're not necessarily installing into the system, but maybe just into some packaging folder

13:07

but the tool operates on the whole system

@heinrich5991 okay how do i cmake here?

in msvs?

13:08

https://forum.ddnet.tw/viewtopic.php?f=16&t=5765

yes

just sent this link to someone else 4 hours ago

hmm my copy seems to be missing cmake somehow

13:09

i don't see the targets

13:10

let me check if i installed all the correct components

yeah that makes more sense

13:12

I clicked the wrong c++ thing

13:12

an extra 1.16gb download

13:12

for the worst compiler ever created by mankind

poggers

13:12

@Learath2 what u prefer, gcc or clang

I think I like clang more, but I'm pretty neutral really

i think clang is smarterwith errors

my position is that msvc can go to hell

xd

13:13

windows bad

Imagine not supporting C99 in 2019

13:13

let alone C11

clang caused gcc to catch up with error messages

i think there is c18 now

13:13

it fixes bugs in c11

wat?

butdoesnt introduce anything

ah c17

https://en.wikipedia.org/wiki/C18_(C_standard_revision)

C18 (C standard revision)

C18 is the informal name for ISO/IEC 9899:2018, the most recent standard for the C programming language, published in June 2018. It replaced C11 (standard ISO/IEC 9899:2011). It has been informally named as C17 too. GCC 8.1.0 and LLVM Clang 7.0.0 support C18. C18 will be sup...

@heinrich5991 I think c17 didn't come out in time so they named it c18

13:14

caused some drama in ##C

why?

lol

someone changed the topic to C18

13:14

because ISO changed the name to C18

itsn ot like they are adding lot of stuff to be late lol

but the working group hadn't changed the name yet

C18 will be superseded by C2x

13:15

i wonder if c20 or c22

so we discussed for a couple hours whether we care about what ISO says or what the WG says

c21 looks bad

C++ has some horrible error messages, there was discussion about that in #c++ a month or so ago

yeah

13:16

with templates

13:16

and stuff

13:16

it goes insane

whether it's the standards committees job to get better error messages or is it just up to the compilers

well, it kind of depends on the standard whether it's feasible to provide good error messages

okay it compiles \o/

13:19

now let me enable aio

13:20

yeah sadly it works now that i upgraded

also the tests

let me figure out how to run them

select testrunner in the green run arrow menu

passed all tests

run it a couple of times

passes just fine

13:27

I guess that bug is lost to us forever

13:27

either way, aio dbg_logging in windows won't really work unless you use WriteConsole

build/testrunner --gtest_filter=Async.NonDivisor --gtest_repeat=-1 --gtest_break_on_failure

windows consoles are just broken

pls

where do builds go?

uh

13:28

in a deep folder

13:28

its not on ur cwd

13:28

xdd

13:28

start ddnet sv and right click it to find the path iguess

CMakeBuilds in your home folder or so

oh did they change it

13:29

i dont use vs since years xd

nah, it's special for cmake builds

they changed it apparently

13:31

it's now in, ~/source/repos/<repo-name>/out

13:32

lets see if it bresks

13:32

breaks*

13:32

I'm on iteration 4000

13:35

@heinrich5991 I don't think this will fail tbh

13:35

it's been fine for 20k iterations

13:41

@heinrich5991 when can I stop?

you can stop

13:48

lol. 10k iterations on linux cost 17s

apparently my fix for console printing unicode wasn't correct either

13:48

it doesn't work on windows 10

13:55

do you know how to look at memory in vs?

nop

very useful debugger

xd

13:55

whats ur prob already?

trying to get windows to render unicode correctly in the console

ah

13:58

does it work or not at all? xd

[2019-05-30 14:06:40][chat]: Learath2: â™«

14:06

supposed to be a music note

ah

14:07

xd

14:07

but

14:08

@Learath2 which console?

the actual console

14:08

MSDN says "For the most consistent results, applications should use Unicode, such as UTF-8 or UTF-16, instead of a specific code page."

discord down?

this ?

14:08

Image attachment

MSDN says "For the most consistent results, applications should use Unicode, such as UTF-8 or UTF-16, instead of a specific code page."

14:09

MSDN says "For the most consistent results, applications should use Unicode, such as UTF-8 or UTF-16, instead of a specific code page."

14:09

I'm trying my very best to use utf-8 but it just doesnt work...

this?

14:09

Image attachment

14:10

omg pls discord upload

@noby i think its just our private chat xd

Image attachment

on a msvc blog, they shamelessly post this

Image attachment

14:10

I think they are the ones that need to learn how to fucking use utf-8

discord is censoring me

yes @archimede67 that one

it works fine for me

are you on windows 10?

ye

amazing, it works on some computers, doesn't on others

14:11

even better

14:12

@archimede67 can you join the server and send some weird character?

xd ok

lol

xd

14:13

i'm funny huh

@archimede67 send a

lul

I hope that didn't crash everyones client :p

wait

14:14

i don't have the chat line for that message xd

14:14

Image attachment

yeah, i told you it's very broken

xd

turns out the windows console can only understand ucs-2, so wchar_t seems to be the correct choice after all @heinrich5991

@Learath2 unicode symbols work for me too, on windows 10. but this

doesnt

14:22

the line is just gone

also @heinrich5991 I remembered why I didn't allow characters from the SMP

14:22

windows console just can't handle utf16

14:23

it can only handle ucs2

14:23

@fokkonaut yeah that's a character from the SMP

14:23

it just causes the logger to return without printing anything

why

because windows console can't handle utf16

14:24

it only understands ucs2

for real?

14:25

embarrassing

yeah, it's straight out of the 90s

windows is embarasing ye

is there no way to fix it#?

14:26

discord lagging ouuuuut

yeah discord bad

14:26

lets go to irc

i am

@fokkonaut no fixing it, the console is just the way it is

Image attachment

14:30

lmao i can see emojis

14:30

gg irc

well it's not irc you should congratulate

ik xD

irc just passes along bytes as they are

14:31

it's the wonder of proper utf8 support on most linux terminals

maybe i installed some fonts

Learath2: discord works so bad rn

yeah, idk what's up with it

Learath2: on debian i saw also the emoji but not colored

14:31

i guess i got some font installed

depends on the terminal and the fonts

im using same terminal

14:32

termite

then it's the fonts prolly

lmao

xd

Image attachment

visual studio seems convinced I'm dereferencing a NULL pointer

14:33

but I'm not :/

wdym by dereferencing a null pointer

ah i see what it means

its safe to free a null pointer if thats what u meant

dereferencing is *

ah

it's trying to say I forgot a null check

is it safe?

14:35

ah

but because it's autistic it says im dereferencing NULL

clion best

14:35

or

14:35

the clang server

14:36

https://clang.llvm.org/extra/clangd/

14:36

lmao they got a screenshoot of vscode

14:36

ah but u are on vs studio

14:37

https://github.com/Shougo/deoplete.nvim/wiki/Completion-Sources i found a nice plugin for vim

apparently there is a literal macro for IsWindowsXPOrGreater

https://github.com/Shougo/deoplete.nvim/wiki/Completion-Sources i found a nice plugin for vim

https://github.com/Shougo/deoplete.nvim/wiki/Completion-Sources i found a nice plugin for vim

Shougo/deoplete.nvim

Dark powered asynchronous completion framework for neovim/Vim8 - Shougo/deoplete.nvim

apparently there is a literal macro for IsWindowsXPOrGreater

14:40

we have a os_is_winxp_or_lower

14:40

@Ryozuki I think most people I know using vim only use the built in autocompletion

14:40

it's supposed to be pretty decent when you have a ctags file

well know u now one who doesnt

14:42

pepeH

Image attachment

14:54

poggers

poggers

poggers

poggers

poggers

@Learath2 can ur vanilla vim do this tho

Image attachment

probably not

i don't use vim

I'm not sure if I want to invest time in getting fluent with vim

vim even with plugins is blazing fast

14:55

and all modern plugins are asynchronous nowadays

it sorely needs a way to properly navigate around

vim even with plugins is blazing fast

14:56

and all modern plugins are asynchronous nowadays

14:56

fcking discord

sublime text is already blazing fast

vim is hard

and vscode isn't far behind even though it's an electron app

i have fun using vim

14:56

and learning it

14:57

specially when u learn it

14:57

u notice the amount of power

14:57

in ur hands

I'm pretty decent at using vim

but it needs time to be configured to ur likings

14:57

like ricing ur desktop

14:57

xd

still not as fast as I am with my mouse though

u can spend all day

14:58

i can go to defintion too

Image attachment

ooooh, haven't played nethack in a while

Image attachment

yeah I'm done coding for the day

xd

@Ryozuki do you have some refactoring tool?

it has a rename option but it needs tweaking

15:00

cuz after it wont find the symbol

15:00

mm

15:00

i guess i need to rerun cmake

15:00

to make compile_commands.jsoon again

15:00

but im not sure

15:01

https://github.com/uplus/vim-clang-rename

uplus/vim-clang-rename

Vim plugin for clang-rename, clang-rename is a C++ refactoring tool. - uplus/vim-clang-rename

15:01

i would try this

15:01

but im lazy rn

15:02

ima play nethack too

@Ryozuki play on nethack.alt.org so I can watch

i need to learn how to play tho xd

oof

15:09

hjkl

ima register

15:10

whats diferent about 3.6.2 and .1

if you are just starting out just play the new one

15:11

couple bug fixes, couple balance things

15:12

you'll want to turn off the numberpad setting btw

uh im completly lost xd

press capital y

15:14

okay

15:14

shift+O

15:14

space a couple times

15:14

one more

15:14

h

15:14

enter

15:14

a enter

15:14

now hjkl should work to move

15:15

you can also use the diagonals, yubn

15:15

i for inventory

whats nethack

old terminal roguelike

15:16

how can i know what i have equipped

check your inventory

15:17

yeah nothing to equip rn

im poisoned xd

but that ring of conflict is very useful in a pickle

15:17

no you aren't, that message is just "wrong" it just means you took more damage

15:18

no you aren't, that message is just "wrong" it just means you took more damage

15:18

, to pick up

15:18

but wizards shouldn't really wear plate mail

y xd

it's too heavy

where can i find controls

15:19

a good website?

good question, I have no idea

15:19

https://nethackwiki.com/mediawiki/images/a/ac/Nethack_Keyboard_Commands.pdf maybe?

15:20

https://nethackwiki.com/wiki/Commands is more complete though

is # some path without light or smth?

# is corridor

15:22

you are a wizard right?

y

you can use a spell with shift Z

#off-topic lets move there xd

oh yeah true this is #developer

xd

fstd: do you still play nethack?

fstd is here? i just started using pstd service

it rocks

you can add a ?c at the end to use c syntax highlighting

ikr best

?lua and ?nim also works

doc said only c

15:59

nim lol

15:59

yo btw do we have a file naming convention? Seems like vanilla used all lowercase and together like gamecontext.cpp and some newer ddnet files use snake case like name_bans.cpp

yeah possible that those are not in the doc, I think I added nim without saying anything

15:59

yeah possible that those are not in the doc, I think I added nim without saying anything

16:00

lowercase and together is more prevalent

src/engine/shared/network_client.cpp

16:00

ah thats vanilla as well huh?

16:00

i dont get it

xd

16:01

don't ask

xc

16:01

dfq does prevalent even mean

16:02

ye so we should kill the subvalent imo

16:02

(i can also invent words :p)

xDD

Learath2: haven't played in a long time, you?

I'm starting again, but my config is gone

lol he is actually here

16:05

always track configs on github hehe

16:06

oh its a ascii game nice

16:07

is it only ascii textures or is it actually cli?

cli

awesome

16:09

i didnt know cli games are a thing i thought im the only person on planet who enjoys it

xD

Learath2: but you're not ingame are you?

no i quit when i noticed my config was toast

rq

u

Image attachment

do it

Image attachment

16:33

didnt help

xD

are there different types of all and alphabetical sort? xd or what am i not getting here

probably

16:35

or u just did shit idk

Image attachment

16:36

looks pretty all and sort to me

ye

character_dummymodes.cpp has to be under character.h

16:41

@ChillerDragon

you added a new file?

yes he did

16:45

but not sorted correctly

Hmm

@ChillerDragon did you read my message

Ye

Then do so

It makes sense

Ofc it does

But I wonder why it looks like this

?

16:47

what

i mean grep usually doesnt forget folders

does anyone care about this? https://github.com/ddnet/ddnet/issues/1734

ah nvm got confused

16:50

but it didnt help

@ChillerDragon just make sure that the order in cmakelists.txt is the same as in your folder if you sort it alphabetically

yes i piped it through the sort command

16:51

i expect that to be sorted

@ChillerDragon try piping through LC_ALL=C sort

@heinrich5991 does my pr looks good to you or is there some bugs/things wrong?

awesome that worked @heinrich5991 ur a fokin wizard

@archimede67 inline in class definition doesn't do anything btw

i dont understand why inline is in classes by default

@archimede67 the first thing that would probably need to get fixed is that the thread still accesses some stuff from the main thread

18:33

namely pSnapshotDelta and pConsole

18:33

ah, CSnapshotDelta might be threadsafe, let me check

18:33

(but pConsole isn't)

18:34

(and it might be good to factor out the CDemoEdit out of client.h and client.cpp

oh you think?

18:34

so it has its own file,

18:34

?

yes

18:36

CSnapshotDelta is not threadsafe

hmmm

18:37

but i need it to init the demoeditor

then you need to create your own instance

18:38

for each thread

of CSnapshotDelta?

yes

and for pConsole ?

patch CDemoRecorder to also work with a NULL pConsole I guess

k

18:48

thx!

@heinrich5991 where should I put the new file?

src/engine/client/

ok thanks

uff

19:30

Image attachment

ok fixed xd

@heinrich5991 I need the CSnapshotDelta from the client to make the demoeditor work properly

why?

idk, if not the demo is buggy

@archimede67 I mean if there's a way the client's CSnapshotDelta becomes the way it is, then you can just put your own copy through the same process

my own copy?

20:58

so creating a thing exactly like the m_SnapshotDelta in the client that i pass in my thread?

is there a reason why rainbow color changing was made impossible on ddnet?

maybe coz of last update with colors

no its been removed long ago

ah

21:11

idk then sry

@Im 'corneum I for example would remove it because it looks attention-grabbing

then it seems to me its the same reason that emoticon spam was removed. but as it was brought back why dont you reactivate rainbow?

I would also remove emote spams

@deen could you have a look at these PR's before a new version? #1732, #1760

Rainbow is way more attention-grabing than emotes spam

yea

Bcs emote spam is easy to ignore and only in one place but a rainbow tee with top rank makes the btm right corner of ur screen flash

xd

Exported 553 message(s)