DDraceNetwork - developer

you didn't have to, I just asked whether if it was a problem

It was kinda needed

07:54

Because when the recorder was recording for a long time like 15 mins and then you wanna save a replay you would have a big freeze like 1-2 seconds and the longer is the recording the longer the freeze would be

07:55

So I tought why not do that in a separate thread to fix that problem and its working well ^^

Gg

@Learath2 "I highly doubt this call is safe from a thread." wym?

you call into the demoeditor from a thread

10:35

the demoeditor has no lock

10:35

so i feel you could break something if this thread ends up using the demoeditor at the same time as the main client

hmmm

(i'm not sure though, for all I know Slice could be not using any members)

what can I do to be sure that this will work without potentially breaking anything? xd

10:38

Slice is creating a demorecorder and a demoplayer within the function

It'd definitely be safe if you create a new demoeditor

Each time i call the SaveReplay function? or a "global" demoeditor for the replays?

either should work just fine

10:41

I'd probably create one when spawning the thread

10:41

and destroying it afterwards

Alright thanks for that review ^^

you can destroy it in the destructor of the CJob

10:44

That Notice isn't entirely safe either, but we do that one all the time, so w/e

10:44

the sql code is full of calls into cgamecontext that aren't safe

xd

the correct way would be to have a threadsafe queue of notices

hmm

10:45

a queue of notices

The threads append to the queue

yeah

And the main client just renders them out when its time

so i should do another task for notifications?

no

10:52

I'd just leave it as is tbh

yea

we don't have a threadsafe queue in the codebase, so you'd also need to code one

ah xd

interesting idea in demo to put numbers too warp time in demo 1-9 , but this is glitch

Is there any convention to create an instance of a class as there is multiple ways to do so?

not really