DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2019-05-19 00:00:00Z and 2019-05-20 00:00:00Z

I could post a 100 issues about the client

01:29

doesn't

01:30

it's still somehow our fault that we don't fix the bugs we don't know about

[ddnet-maps:master] 1 new commit

816983f M JungleRabies - ddnet-maps

@ChillerDragon probably due to a double bind, like bind mouse2 "+hook; emote 4" (edited)

GWgoaShuu

1

the problem is, you dont check/test some commits/pullrequests of dumb user

08:42

btw and i saw the problem doesnt come from fokko, it was spsomeone

08:42

and you all accepted his useless commit

08:42

i post it st evening if im back from my tour

ah true the double binds

Learath2 is oodnet down? :c

Any opinions on integrating this into ddnet? https://github.com/FeralInteractive/gamemode

FeralInteractive/gamemode

Optimise Linux system performance on demand. Contribute to FeralInteractive/gamemode development by creating an account on GitHub.

@Deleted User

why is reality always on an oldschool server?

09:42

every morning xD

09:43

@snail

@Schulzer We have a list of default maps to load on server reload

10:58

Could actually update that with the currently most popular maps though

put only my maps in it)))

[ddnet/ddnet] Issue opened: #1738 Possible to get stuck in an unhookable tile

https://forum.ddnet.tw/viewtopic.php?t=4&p=67858#p67858

[ddnet/ddnet] Pull request opened: #1739 Ignore binds in slice save menu

Should fix a bug reported in #1702

@ChillerDragon can you test if that fixes your bug ^

which one?

11:36

and couldnt u reproduce it?

the one where demo jumps when you save a slice

ah

no I couldn't idk what exactly you pressed

nothing

11:37

i was just tpyping in a demo name

11:37

but ye i can check later

ok

gj @jao

ty

what do you think about shifting the demo speed @jao ?

12:15

lower max and lower minimum?

why lower max

its unusable for me

12:15

too much fps drops

for me it's not

fullhd nobo

and I need at least x64 for teehistorian demos

are there even teehistorian demos?

yes?

oh didnt know that

12:17

since when?

end of 2017 or so

lel

12:17

how to create em?

with teehistorian2demo tool

lel

12:19

i just tested x64

12:19

and it worked fine

12:19

might be the network bug

12:19

that was fixed

or you tested with a debug build

no

12:19

i always play release 64 from official website

oh men my demo folder is so fucked up

12:32

i have a demo that claims to be 400k minutes long

12:32

but actually isnt longer than a minute

12:32

i have negative amount of demomarkers as well xd

fix

12:35

or send demo

the negative demomarkers might be created by my crackclient

12:35

idk baut the long one but it i sonly one so idk for now

12:35

the only really fucked up thing is that i lost soooo many of my best demos due to wrong map

send the long one

don't throw away the demos with the wrong map, one can surely fix them

i wont throw them away

12:37

and if i have to wait 10 years until i have the skill to fix them

12:37

i just hope ur db holds all the amps i need @heinrich5991 -.-

12:37

maps*

http://149.202.127.134/tmp/Back%20in%20Time%202_2018-12-02_17-30-42.demo @jao can u fastwforward this demo?

how big is that lol

normal bit2 run

13:08

i think around 200 min

13:10

And the weird long demo because u asked for it http://149.202.127.134/tmp/ctf5_2019-05-01_20-12-34.demo but dont try to find a bug that might not be in ddnet client

13:11

its only 1 demo out of zillions and i also use weird clients sometimes

doesn't work @ChillerDragon

what doesnt work ? :c

playing with x64

for me it does

13:14

very bugged tho

client freezes for me

ya at some point it could also do that

14:06

thats what i ment with buggy

14:06

i will double check later if this was only caused by the old broken servers or still exists

hello people of ddnet

18:08

anything that needs urgent fixing today?

haha nice that u ask :) but not that i know

I guess I'll finish up the two pr's I have open

18:11

Also I'll fix up the clan color thing I guess

[ddnet-web:master] 1 new commit

4d043c9 Front page video: Random moments 10 GER - def-

[ddnet/ddnet] Issue opened: #1740 SQL code creates string temporaries and call `c_str()` on them

This temporary is destructed before the next function is called, leading to use after free.

Why has the world moved towards electron so quickly?

@Learath2 html/css/js stack is rly handy to make UI stuff and u can do that "on the desktop" with electron

Who in their right mind thought "hmmm, we should get a new ui framework..." "OH I know lets run an instance of chrome for every single app"

20:44

200mb for slack, 260mb for atom, 333mb for discord, 200mb for spotify

20:44

just because disk space is cheap doesn't mean you should waste it...

i only use discord

also all of them using a small amount of cpu all the time ruins my battery life

20:45

let the poor gpu go idle wtf

20:45

cpu*

xd 1.1% of 8gb = 0.088 gb

Image attachment

I have 32gb of ram on this computer, if the memory footprint of these madnesses keep growing at this rate i'll need to upgrade the entire computer

?

20:47

i have 8gb and im fine

you don't seem to run many though

and i have a ide open too

20:47

and firefox

20:47

xd

Image attachment

I run slack, spotify, discord

why u run slack and spotify

don't get me started on firefox...

20:48

modern web browsers are so disappointing

all use lot of ram

20:48

well

"we got more ram, we'll abuse the ram"

u that complain so much u can use lynx

20:48

i think it takes less than 10mb

can't browse the web with links2 anymore

20:49

everyone and their mothers use "cutting-edge js frameworks"

brownbear

20:50

u will kill me, but i like react

20:50

Atleast you don't use angular

nah i tried it 1 min and went away

20:50

long time ago

20:50

xd

ya rip lynx

react-native is a pretty cool idea actually

20:51

browsers first of all should stop accommodating for web-developers that code like they are on drugs

20:52

it's astonishing how much the browser compensates for the stupidity of the "programmer"

?

haha

ill-formed html is rendered fine by a lot of browsers

yea

ah ye

also ill-formed js

ur wrong there

thats confusing

js is illformed by default

which causes a metric fuckton of bugs and backwards compatibility issues

its the web

20:53

you shouldnt break the web tho

what u talking about

I think you should before it's too late

if u kill backwards

its already too late

also over-reaching browsers...

and internet explorer being so outdated it doesnt even include features all others have

IE is a meme xd

did you know that chromium has a userland driver for xbox360 controllers in it's codebase?

xd

20:54

no

[ddnet/ddnet] Issue opened: #1741 custom mod front layer entities

when playing custom mods (gametype is not exactly DDrace or DDNet or DDraceNetwork) the client should render all tiles from the front layer aswell, because custom mods -> custom tiles, also for front layer

the amount of garbage in modern browsers just makes my eyes bleed

20:54

Can someone buy @fokkonaut a keyboard with a shift key?

lol

20:54

wdym

ah ye u always fixing his title

20:55

xd

i tried

His issue titles always start lowercase, that also makes my eyes bleed

@Learath2 i am too lazy to use shift on mobile

...............

he uppercases DDNet tho

20:55

xd

yes

20:55

xd

20:56

@ChillerDragon u always make parameters for functions start lowercase :<

but ye i tried multiple times to convice him that commits and issues are nice with first lette ruppercase

20:56

yes

20:56

my coding style got worse

exactly

since i got a job as dev

20:56

in crap language

xD

being incasesensitve with crap code base

no u already had bad style

lol

tru

u praise vanilla a lot but ur commits dont follow it

You actually have a job @ChillerDragon?

lel

20:57

yea i do

What language do you code in? Scratch?

xddd

o.O

danAmazing

he codes in java

apex

20:57

its worse than java and scratch together

"Apex is a proprietary language developed by Salesforce.com"

yes

Why would you do that to yourself?

compiled in the cloud

did u tell them u cant do a simple problem in python for a coding game website? :P

is the pay nice atleast?

wait 20sec to 20 min to save a file

20:58

web editor to code

20:58

xd

20:58

they dont care @Ryozuki

20:58

yes they pay

20:58

and they search devs

20:58

that are willing to do this crap xd

lmao propietary language

why would salesforce even create their own language for this is what confuses me the most

its fucked

idk what to think about that

20:58

but looks crappy

it is

what happened to, python, lua, java, php and the billion other languages you could integrate?

dont ask me

20:59

some ppl with money made decisions years ago

lua is everywhere

20:59

they could have used it

so what does one do in this language?

@Learath2 i had a work experience and they coded in object pascal xd i got cancer but they offered me a training(right word?) but i declined xd

salesforce

do you program like sales or sth?

yes

@Learath2 hit his own head on desperation

@fokkonaut you also work?

what do you do @Learath2 =

No, still a student

do u have a job?

@ChillerDragon I study, I worked with a startup for a while doing react-native and php

@Learath2 im on a technical high school right now

php

21:00

ew

i like php

21:00

its easy to build crap with

u like scratch

xd

21:00

and bash

I don't know how I feel about php

21:01

I hate the other backend languages more

bash and php vars are similar :3

so I think I like php?

ruby on rails kek

my brother showed me phpstorm and i just loved that program xd

jetbrains makes good ides

21:01

but php is shit

ah yes, the jetbrains suite

i have clion

21:01

i use it for ddnet

how much is it?

free cuz student

hax

I love their licensing scheme

maybe i should check it out

its better than vs

i keep ranting about visual studio bloat ware

if at any point you buy a subscription and cancel it you get to keep the old version forever

21:02

it's what adobe should start doing tbh

sounds nice#

also all jetbrains tools are crossplatform

jeez this keyboard has a # where others have a enter key omg

I pay 20e a month for CC, if I ever stop paying I lose access

thats a lot

21:03

do u even use their tools activly?

I used to think it was a lot

@Learath2 can you send me your spotify playlist?

Then I noticed it's just one dinner less

u dont even have a job lol

21:03

how so rich

@fokkonaut which one?

lol

Image attachment

The one u use for coding

fcking ugly code

I love that integer packer

21:04

It's like a noobfilter

i implemented it in python

@Ryozuki please look at https://github.com/DDNetPP/DDNetPP

DDNetPP/DDNetPP

Based on DDraceNetwork by deen & contributors (www.ddnet.tw) which is based on the great game teeworlds (www.teeworlds.com). - DDNetPP/DDNetPP

ddnet

1

xd

no i wont look at shit mods

best cpde

@Ryozuki maybr you like that codr lmao

quality code

@fokkonaut https://open.spotify.com/user/learath2/playlist/0Rje8fvEFZoGF3cUlUcmhQ?si=fM4MYfDVRi6WEUBN1rraiQ

Chill LT, a playlist by learath2 on Spotify

Chill songs with low tempo, preferably no lyrics and mostly electro-ish.

thanks m8

It might put you to sleep though

xd

i dont want ads while i listen to music thanks

instantly followed

21:05

buy so

https://raw.githubusercontent.com/chidraqul/chidraqul/master/chidraqul.cs

21:05

thats quality code

@Ryozuki imagine not having spotify premium in 2019

?

yoyoyo

i never needed it lmao

21:06

yt playlist + adblocker

same#

It's the one monthly payment I think is worth it

i even used yt without adblocker for years

21:06

skipping ads every 5 min

21:06

xd

nah

21:06

FOSS MUSIC!!!

spotify playlist with adblocker

I can listen to it on my phone even

STALLMAN IS GREAT

best

ew i stepped in shit - people who listen to music on yt in 2k19

i have youtibe on my phone as well

21:06

2019

lmao lot of ppl do it

21:06

spotify sucks

xd

yt is free

its good

21:07

spotify is free

oh the numbe rhacker is here

?

21:07

number hacker

21:07

why

i will soon setup a selfhosted music platform to listen too myself

@fokkonaut If I'm pushing through the night I listen to https://open.spotify.com/user/learath2/playlist/5qAAYMfPVlOB4PZ6DKAtxO?si=FX-fdwShTm6nykEoya58uQ instead

EDM, a playlist by learath2 on Spotify

EDM I can still endure.

he is a wizard

21:07

with numbers

ay EDM

21:07

@ChillerDragon ? xd

toptri

Image attachment

lost half of that playlist playing around with a spotify script

xd

we played some coding games @fokkonaut and @archimede67 riüpped @jao and me

https://www.youtube.com/watch?v=U9Racui9jJI do u have this gold in spotify?

The Epic Commodore C64 SID Collection - 11 hours of C64 Music

GWpingSock

@Learath2 this is a really short playlist

@archimede67 as said, it was double the size atleast

21:08

I was moving songs around with a script, it kinda went wrong

@Learath2 i know many of your songs

ah xD

I really should create new playlists

bit music best

don't you wanna add them back?

@Ryozuki do you like chiptunes?

when finish your pr learath

@ChillerDragon do u like it

21:09

@Learath2 ye

@fokkonaut sometime before GoT drops on trackers

they remember me of old games

Anamanaguchi is a cute mix of pop and chiptunes

@Learath2 when i git rebase last time from hmh branch i got two conflicts, should i solve them before i do anything else?

yes

@archimede67 yep

alright

u shouldnt do it on hmh branch

you can't even compile the code with conflicts in, it has ">>>>>>>>"

ye and gcc is smart enough

21:10

to tell u it is a git conflict

really?

y

overreaching software again

i doubt

21:11

i think its simple

if (str_has(">>>>>>>")) return git_conflict;

u can count >>>>>> in a single line

xd

ur just over dramatic lmao

yeah but now gcc depends on the conflict markers git uses

idk how it works

what does gcc even have to do with git

@Ryozuki yea but he did so much work and its actually working except that its kinda old (1+ year)

I think hmh's was working except for sounds

tbh idk why u doing this u should do simpler ddnet stuff first

and i just want to fix the audio and add interfaces to export demo as mp4

audio isn't really too easy to fix though

ye hmh is a good programmer, if he couldnt get it it wont be easy

@Ryozuki yea but that was an idea i already had and when i saw that someone already did something i wanted to continue that but that's true that it's not easy but i don't see what else i can do

the problem was for the slow playback speed

21:14

to sync the audio properly

I think the issue was that we are recording the frames as quick as we can

21:15

but the sound needs to be stretched/shortened according to the framerate of the video

@archimede67 what do you want to do? xd

21:15

just something in ddnet?

continue the work of hmh

21:15

but for now its pretty hard xd

I want to make a chat client, but I don't want to use electron for my ui, I don't want to make it in ncurses either

21:16

Help

console

use electron

21:16

why not

I said I didn't want to use ncurses

21:17

I'd rather not make anything then make yet another electron app

ncurses is gud

@fokkonaut but otherwise i want to do make something in ddnet (which can be useful somehow) yea

Imagine people actually liking my chat client and using it

poggers

Image attachment

@archimede67 go through the issues, check what you can fix

I'd be really sad if another elecron app caught on and I was responsible for it

@Learath2 eh u got lot of competence tho

21:18

irc best

@fokkonaut alright i'll try to do that first ^^ thanks

:)

irc is a very meh chat protocol tbh

i like it

@archimede67 do you know where to find stuff in teeworlds/ddnet source?

it allows complex thins

@Learath2 use java

things

ncurses best

it wouldnt have lasted this long

chillerbot-ng best console client

it'd be really nice if irc would be upgraded to support E2E encryption e.g.

@fokkonaut wym?

@Learath2 u can do that clientside

@archimede67 have u ever made something with the ddnet srv

21:20

src*

ye

21:20

already tried something based on the work of hmh (edited)

@Ryozuki I already did, the naive implementation sends n messages per n people in the chat

21:20

horrible for latency

@Learath2 make a Web or mobile tw chat Client linked to desktop client please. I need to talk to people if i am afk in 3 hours race and currently in supermarket

znz has a module for encryption of chat msgs

@ChillerDragon android ddnet danAmazing

danAmazing

if other uses znz too u can have it ez

@archimede67 if you need help for anything you can ask me, maybe i can help :)

iOS @plsplsplslol

ios bad

@fokkonaut alright, thanks

!

@Ryozuki it'd be nicer if the protocol just supported it

is gay

also netsplits are totally avoidable

just a question, to fix something you create a new branch?

https://ircv3.net/irc/

IRCv3 Specifications - IRCv3

Specifications that the IRCv3 Working Group maintains and distributes.

you dont need to, you need to have your fork

yea

branches ofc are more clear and structured, but you can also push to your master

@Ryozuki about 10 people implement ircv3

@Learath2 nah ur wrong

but on this fork, as i saw trml creating branches like "pred_fixes_2" so i was wondreing (edited)

all modern ircdaemonds implement it as a module or builtin

21:23

ps: i host a irc sv

@archimede67 a branch per feature/pull request, is the norm

@archimede67 if you have many pull requests at once, pushing to master is bad, so yeah, branches are a good thing

k

@Learath2 well maybe not all but there is a good one thats working and being funded by ircv3 directly

21:24

https://github.com/inspircd/inspircd

inspircd/inspircd

A modular C++ IRC daemon (ircd). Contribute to inspircd/inspircd development by creating an account on GitHub.

@Ryozuki doesn't matter if no one hosts a server that supports it

lot of sv use this

is this considered as a real bug? https://github.com/ddnet/ddnet/issues/1731

Zoom resets on dummy connect · Issue #1731 · ddnet/ddnet

Reproducible in 12.4.2 But probably it was always so =)

[ddnet/ddnet] Pull request opened: #1742 fix particles, emote wheel, zoom and score for blockworlds

fixes a few things that got broken for players using ddnet client in blockworlds

@Ryozuki none of the big servers I know of support any of ircv3

21:26

except maybe multi-prefix

21:26

I see that one supported on a couple like oftc and efnet

21:27

@archimede67 I guess it was always like that

21:27

could be fixed

@archimede67 oof, idk :D for the score you just have to turn off ddrace scoreboard

21:27

the rest idk about

@Deleted User is that you?

yea maybe i can fix that and see

so many blockworld fixes

the particle thing looks like something with the prediction ( @trml )

fokko and sp someone broke it

me not

yes

lol

you added bw to isddnet

i didnt break anything

make no sense

@Deleted User got removed

21:28

nobo

21:28

nuborn (trml) readded it

21:29

for predictiom stuff

@Deleted User serverbrowser.cpp:L75

21:29

you accidentally duplicated that

what part of it is not ddnet?

ah ye i see

Also all of this Is* stuff bothers me a lot

21:30

we should really be doing a proper capability negotiation instead of mods depending on eachother and looking at gametypes

IsYourMomHappyGamemode

IsYouDumb

@Deleted User in which cases shouldn't bw be detected as ddnet?

its based on tw

21:31

vanilla

21:31

omegalul

oh and another question, do you use any code standards?

@archimede67 not really

but doesn't bw need the things DDNet needs in terms of prediction?

@fokkonaut it was already in IsDDNet

no

@trml oh, okay

i always see variables like m_Something, etc

wtf it wasnt

21:32

i looked back till 26.july.2018

@archimede67 those are member variables

@archimede67 thats code style

oh yea mb

This discussion is easily resolved through git blame

noo

21:33

that never ends gud

@Deleted User why i added it to isddnet is for eyewheel and zooz

21:33

why dont you make a pr

IsDDnet breaks the mod

@archimede67 https://www.teeworlds.com/?page=docs&wiki=nomenclature

we already tested it 1000 times

damn thank you!

@archimede67 that's kinda wrong on a couple things though

21:34

actually no

21:34

we didn't change anything nvm

k xd

aBuffffff

@Deleted User does bw need anything special even?

21:35

allow zoom seems to be it

fokkonaut want emotewheel zooz in the mod

21:36

that can be enabled in ddnet client

no

but sp someone changed the extractinfo stuff

21:36

and removed it from ddnet

21:36

it breaks probably another mods too

21:36

idk why is use ISDDNET if it gets removed

huh, I don't even remember sp someone commiting anything

he did

guess it was when I was in japan or sth

he did it to annoy me

you cant enable eyewheel if the mod is for example vanilla

but you never recognized it

21:36

he iss a troll

what is his github name?

ZombieToad

fokko why did you even made bw support in ddnet client?

21:37

if you have no idea of anything

Are you stupi

21:37

d

no you did it first

21:37

i looked back

I made it a IsBlockWorlds

21:37

and deen said move it to IsDDNet

ye, i never said add bw support to ddnet

what is that change he made even

you never asked me

you never complained

I DID

21:38

wtf

then make a pr

21:38

we are on github

kpro did

can you people not argue?

scroll up

21:38

for me is everything explained

make a pr

cant he read?

cant you

@heinrich5991 that commit doesn't seem to make much sense

foko the pr does already exist

ik

then why are you telling him to make a pr lol

why are you saying fix foko all the time

21:40

xd

21:40

to annoy

the bug is based on you and spsomeone (edited)

wat

DEFUQ

if the gamemode isn't ddnet there is no extrainfo to remove

21:42

I guess this all boils down to ddnet based mods not being identified as ddnet based

21:42

As I said previously if we did proper capability negotiation, Like negotiating whether extrainfo is sent or not, this would be much better

@Deleted User just use IsBlockWorlds for the eyewheel and zoom, then everything should be fixed

We should rollback SpSomeone's commit

which?

26.july 2018

link pls

search yourself

mine will fix the issue with #1187 instead

@Learath2 pls removed blockworldss out of ISDDNET or it isnt still fixed

who even added it into isddnet?

21:44

what a mess

@Learath2 which commit?

there's some issues that aren't issues anymore but aren't closed

@heinrich5991 #1187

like https://github.com/ddnet/ddnet/issues/1382

mapping: Сommon layer where you can move everything at once, or d...

Сommon layer where you can move everything at once, or delete, or replace.

@Deleted User well fwiw you were right about it being @fokkonaut

21:46

https://github.com/ddnet/ddnet/commit/cf09fbd1ea7e12c0e323a74a20acef953b74119b

Merge BW support into IsDDNet · ddnet/ddnet@cf09fbd

ty

@Learath2 indeed, that commit isn't correct

should have been broken for quite some time now, 4 months ago

duh me

@Deleted User deen told me to do it

and if you really add support for my mod , then ask me first, ty

@Deleted User do you or do you not want it fixed?

https://github.com/ddnet/ddnet/commit/b8730b36534988553ac498f1c9046eec417d20be

block worlds zoom + eye wheel · ddnet/ddnet@b8730b3

21:47

i did this, and it worked

@heinrich5991 is there someway to send more flags in the serverinfo?

21:47

@heinrich5991 I mean we have a couple flags available but is there a way to extend it later?

@Learath2 can't depend on server info being available before or even during server join

@heinrich5991 so https://github.com/ddnet/ddnet/pull/1732/commits/9c3dafa isn't the greatest idea?

Implement ISDDNET and Time Score cleanly by Learath2 · Pull Reque...

This is an attempt at implementing the two things in a cleaner way. Deprecated #1320 Willfix #1622 soon(tm)

fire

actually it should be fine, for this use

@Learath2 pls revert sp someones shit, but you can add blockworlds ssupport for emotewheel and zooz, but dont add it in ISDDNET

https://github.com/ddnet/ddnet/commit/b8730b36534988553ac498f1c9046eec417d20be

block worlds zoom + eye wheel · ddnet/ddnet@b8730b3

fokko this doesnt help before sp someones commit isnt reverted

21:50

xD

ok

it looks like #1742 fixes this

how about a serverflag to allow zoom?

hm

[ddnet/ddnet] Issue opened: #1743 Revert #1187

Revert #1187 because it looks wrong for vanilla and other non-ddnet servers.

If your server sends SERVER_FLAG_ZOOMABLE one can zoom, if not nope

@heinrich5991 does that break something now?

but again I'm not sure if it's the best use of the limited amount of flags we have

it does

21:52

wait no

21:53

why you add flags for it?

21:53

return (pInfo->m_Flags & SERVER_FLAG_ISDDNET
        || str_find_nocase(pInfo->m_aGameType, "ddracenet")

reverting #1187 and removing bw from isddnet should fix it

21:53

@Deleted User yeah will probably merge that one soon

21:53

That would fix #1187

21:54

ddnet based mods would send SERVER_FLAG_ISDDNET

is the github bridge broken,m

21:55

?*

why?

I cant find the message of the pull request

heinrich's isn't a pr

lol

it's an issue

oh

21:55

yea found it anyways

btw is spsomeone still dev?

he ded

good for everyone here

who is spsomeone xd

banhammer

1

1

troll

1

lol

lol

lol

lol

lol

somebody who regularly exploited ddnet vulnerabilities and claimed it was for the good

not just that, he is a ingame troll too

i remember he stole maps from closed testing servers xD

22:03

how tho

I'm not sure why you give trolls such a platform

it made us fix the names like /kill

22:03

xD

hes reformed now

like syltoox

syltoox is a lost cause

@Deleted User your pr also reverts #1187 right?

sp someone actually smart

@Learath2 ye

I'll merge that

look for style @Learath2

I think it looks fine

*

22:06

belongs to the variable

oh

and the 1 can be a true

bors is sleeping anyway

nice foko

@fokkonaut the 1s were like that before spsomeones commit

22:08

but yeah, might aswell fix them

and what about those spaces at the ifs?

I guess I could fix them myself actually

btw whoever know how to fix it with spaces or smth else, vs autocorrectur it on kpro pc

22:13

any option to fix it?

22:13

with spaces and *

the autocorrectors don't really like our style

22:13

which format tool/ide does he use?

[ddnet/ddnet] Pull request opened: #1744 Hack around the race condition in random maps selection

Revert this "once we get proper SQL code"™.

ten years

22:20

that's a bit of an exaggeration

@heinrich5991 do we get the serverinfo after connecting if we don't have it?

yes, we'll eventually get it

22:32

why do you want to put it into the server info? ^^

because it's server info

whether you can zoom?

I don't mean that one

22:33

I was just exploring the possibilities with that one

22:34

I mean isddnet

I think serverinfo is mainly the thing that's displayed in the server browser

we also display it in the ingame menu

22:35

The only other place I can see an isddnet flag is a gameinfo object

22:35

but that creates some issues

22:35

the gameclient has no concept of "server info"

22:36

CGameClient isn't really the best place to store gameinfo

it has the advantage that we don't need to think of how to write it into demos, at least

eh, forgot about that

22:42

it'll be so many lines to refactor

22:42

All that code that depends on isddnet

22:43

anyways, @heinrich5991 do you think bool m_IsDDNetis okay in CGameClient?

22:43

Or should I create some new class to hold the gameclient "serverinfo"

I would say create a struct and make it a member of CGameClient

22:46

also ignore my advice if it's convenient, I never finish my projects ^^

GAMEFLAG_ISDDNET maybe?

have voice chat, @Learath2 ?

sure

[ddnet/ddnet] Pull request closed: #1739 Ignore binds in slice save menu

22:51

[ddnet:master] 2 new commits

28f26a0 Ignore binds in slice save menu - 12pm 077aa39 Merge #1739 - bors[bot]

[ddnet:master] 4 new commits

0856fec fix particles, emote wheel, zoom and score for blockworlds - kpro998 f3ff81e fix IsBlockInfectionZ duplication - kpro998 66b1b44 Style - Learath2 131a0e3 Merge #1742 - bors[bot]

23:12

[ddnet/ddnet] Pull request closed: #1742 fix particles, emote wheel, zoom and score for blockworlds

Exported 692 message(s)