DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2019-05-15 00:00:00Z and 2019-05-16 00:00:00Z

[ddnet-maps:master] 1 new commit

edee652 M JungleRabies - ddnet-maps

@Learath2 it is also usefull for mods that use IsDDNet and want time score but dont have a Race gametype

@Learath2 looks good, thank you!

07:18

clever use of the password field

[ddnet/ddnet] Pull request closed: #1320 Implement ISDDNET server message to decouple version expectation from gametype

@timakro lol, your code was so big, and these are so few lines xd

07:45

How does this |= and &= work?

x = x | y; => x |= y

07:46

;

07:46

same as += etc

ah lol

@Learath2 how do i set the ui_color correct now? i have the values of the old variables saved

08:12

cant get it with a converter

convert it to hex rgb and then set that

another pfp

can you read jao

can you read foko

give me a link

10:48

for a converter

put your old values in a hsl to rgb converter

10:48

google

what about alpha

10:48

ui color is hsla

hsla to rgba converter

why rgba

10:48

i thought i need hey

10:48

hex*

I thought you need an alpha channel

ui color is hsla

10:49

how do i convert it to the new Format

10:49

ui_color

10:49

before it was split into single variables

convert it to hex

10:50

http://www.standardista.com/hsla-color-picker/

HSLA Color Picker / RGBA Converter

HSLA Color picker.

10:50

first result on google

thanks

I wonder if I implemented RGBA hex properly

11:24

We have a limited amount of flags for serverinfo, do we want isddnet or something like israce

11:25

@fokkonaut well I don't really see a good way to implement time-score, the way you want, where you can send different values to different clients

you need a player var for it, like m_AllowTimeScore, then decide if you want to send the flag or not based on that

I know how to hack it in

11:27

I don't see how I can add it in as a proper feature

11:27

like look at my current attempt, it's inconsistent, the score-format is set properly, but at some places you just don't know what to display in the hud

11:27

or the title in the scoreboard

11:28

if some players have their level as score and some have time e.g. we don't know what to display

why

11:30

sure

11:31

It all worked fine before, so just leave it like i did (i mean those checks for hud and scoreboard text)

I'm not leaving in a franken-feature

11:33

It's a very specific feature that can only be used for your mod, it doesn't belong in ddnet

lol

it would make sense if the entire server had the same scoreformat at the same time

if you can do it so that i can edit it serverside its ok

11:35

i mean, if you do it ddnet-wise for all players, but give me space so i can edit it serverside to only send it to specific players

11:35

shouldnt that work? if you leave my checks in

11:35

for hud and board

as long as the scores sent are the same format for every client, yeah that'd work

11:36

one current score-format, that is applicable for every client

11:36

and you can hack around with it while snapping for a specific client

thats what i want to do

11:37

So, that would work, right?

but as i said, you aren't allowed to show levels for one client while showing time for another, there will only be one type of score in the scoreboard

??

11:38

What do you mean

11:39

why doesnt that work, if I send it only to specific clients

11:39

Oh

I mean the scoreboard will display a single format for every client

Yea, like before

11:40

but i can decide whether client 1's board shows time and client 3's board shows level

yep

Yes, thats what i meant

11:40

the rest was clear to me xd

I wonder how customisable I should leave this

11:40

can you imagine any other scoreformat except time and score?

No, there is nothing else i guess? Only numbers, or the time format using 00:00

11:42

what else should it display? xf

dont kill fokkos score sys its used in ddnet++ -.-

is already

11:42

i will redo it

wat?

for ddpp

ouch

once this pr is merged i will redo it, np

11:43

its not much

11:43

trust me

Idk what else should it display, that's why I asked

Shouldnt be any other possibility

If it'll just be a toggle between Score and Time I'll use a flag

11:45

if not I'll leave it an enum

There is no other format, so make it with flags

levels

leves is normal score tho

11:46

same format

isn’t it about the label too tho

No

11:47

that doesnt matter

yeah I was thinking of adding the label too

label oent matter

11:47

nobody reads that xd

as a cute feature

@Learath2 oh, thatd be sick

11:47

❤

but in this case I mean just the format

u sure fok?

"doesnt matter" "ok that would be sick"

xd

classic foko

like the literal format string "%d" or "%d:%d:%d"

no, there is no other

format matters much more than the label

you can leave it open

one label being like score and the other like time or rank is totally fine

11:48

let the server send a format string to the client troll

troll

I guess that really is all, I can't think of anything

Yea

@ChillerDragon did somebody say remote code execution?

hehe :p

XD

remote code executing is feature not security vulnerability

11:49

troll

true

11:50

using a scoreboard format string vuln, you could replace the gamecore to add better prediction for your own mod

yes

11:50

that is exactly what people will do

11:50

nothing else

did you see ZombieLoad btw?

ZombieToad sp someone? xd

https://zombieloadattack.com/

no idk that

new cpu vuln

it says download

11:51

xd

affects all intel cpus

melt down 3.0 ?

11:51

i dont even know foreshadow

except pentiums, celerons and atoms i guess as those don't have SMT

"more critical vulnerabilities" jeez

it's very similar to meltdown yeah

11:52

same idea, unprivileged and privileged processes sharing "cores"

how can i use it to get ddnet admin rcon?

11:53

turorial pls

you can also use it between hypervisor threads, so you can access other peoples virtual machines as long as you are on the same physical server

hehe amd best

https://github.com/IAIK/ZombieLoad

IAIK/ZombieLoad

Proof-of-concept for the ZombieLoad attack. Contribute to IAIK/ZombieLoad development by creating an account on GitHub.

11:53

ah there is xd

11:53

isnt that dangerous for all these coding websites

11:54

that have thes compilers and run user code

amd was affected by spectre aswell

11:54

not meltdown as much though

like the game we played yesterday

@ChillerDragon yep, very

is this a recent vuln

lez hack these sites

11:54

im always last -.-

11:54

xd

i wonder if this is fixable OS-wise

well it's a hardware vuln

i wonder how long the NSA is using this already troll

troll

it might require new microcode

@Learath2 i didnt inform myself a lot on this butr isnt spectre and meltdown hardware too

11:56

but they are "fixed"

11:56

or idk

11:56

im not much into that

11:57

To address the issue in Debian, updates to the kernel, processor microcode, hypervisor, and various other userspace packages will be needed. These updates are being announced in Debian Security Announcements and Debian LTS Announcements as they become available.

well meltdown was "fixed" by having the kernel be careful where it executes privileged processes

uh i guess u can update processor microcode?

11:57

wathever that is

11:57

https://wiki.debian.org/DebianSecurity/SpectreMeltdown

yeah,, during early boot you can patch the processors code

uh

11:57

isnt that dangerous

11:58

u can fck up the cpu right

11:58

xd

it's signed microcode

ah

I don't remember how they fixed spectre though

11:59

the only total fix to both is disabling SMT all-together

all those vulns always get some neat logos

12:00

Embedded image

12:00

xd

12:00

this allows phishing sites

12:00

to do easy phishing

apparently they patched spectre with "unoptimizable code"

and scam

write branches in a way that the cpu doesn't try doing speculative execution

what do you mean by logos allowing easy fishing @Ryozuki ? Like distributing scam patches and using the logo to loog legit?

I'm guessing he means the new vuln

12:05

actually, not sure

@ChillerDragon lot of marketing for vulns most ppl wouldnt care less, some less tech savvy people would get worried and install some shit saying it patches it

12:05

meh i was just bored

tbh, spectre looks cute, I'd let him on my computer

1

poggers

poggers

4

@Learath2 why does str_toint_base("E0007897", 16) give me 2147483647 when it should be 3758127255

hmm

12:44

I think it might be too big

12:46

@jao

14:45 <Learath2> ,cc long t = strtol("E0007897", NULL, 16); printf("%ld %d", t, t); 
14:45 <candide> Learath2: [warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat=]] 3758127255 -536840041

12:46

maybe you are printing it out the wrong format?

12:46

because str_toint_base calls strtol

12:47

but you should be getting hte negative thing, not 2147483647 are you also trying to shove it in a unsigned int?

12:47

yes you are

but str_toint_base is int

12:59

:(

what are you trying?

hex rgba

13:09

doesn't work as long for me either tho lol

@fokkonaut https://ddnet.tw/colors.html

Image attachment

14:21

dark theme!

U weird

says the guy who speaks better numbers than english

:+(

14:24

These were just easy i'm sure i'll struggle on others

no you number wizard

14:25

we should burn u

Nah

14:25

Remember the *64 thing?

xd

I couldn't figure out how for like 10mins

i couldnt after 30

14:26

burn the witch

xd

how did you dark theme that chiller

my ubuntu darktheme did that probably

What if ryo had play with us

i guess you didnt provide enoigh styling

make light

im darktheme user

14:27

xd

Did u even style it

14:28

Chiller what

do I need to css that now or what

U dont use darktheme on discord do u?

no @jao its not the first site my theme messed up

14:28

rather do an pr on my theme than fix ur style

14:28

i us elightthemed discord xd

And u're a dark theme user

troll

Pretty strange.. xd

@jao I pack the color in the most significant byte btw

14:32

you do aswell, good

@ChillerDragon nobo u can fix it

14:48

u must tell firefox to use a light theme version of ur gtk theme

14:49

@ChillerDragon https://dougie.io/answers/firefox-linux-fix-dark-inputs/

@Learath2 what to do about str_toint_base hex rgba

wym? the answer should be correct

14:52

it should be returning the negative number

didn’t work for me

14:53

didn’t work for me

where does it fail?

15:09

do you not get the negative number?

I get the original number

@jao how are you checking?

15:12

dbg_msg("DEBUG", "%d", str_toint_base("E0007897", 16));
[2019-05-15 17:11:54][DEBUG]: -536840041

like that

15:21

but that’s still the wrong value or not

the negative value is correct

15:22

alpha is at the beginning so it also uses the sign bit

15:23

dbg_msg("DEBUG", "%d %u", str_toint_base("E0007897", 16), (unsigned)str_toint_base("E0007897", 16));
[2019-05-15 17:22:54][DEBUG]: -536840041 3758127255

15:23

I don't really get how you can arrive at 2147483647

15:26

@jao you do exactly that and you get 2147483647?

okay, what str_toint_base is doing is not well-defined

15:36

Otherwise, the new type is signed and the value cannot be represented in it; either the result is implementation-defined or an implementation-defined signal is raised.

ok you do it

I have no idea how to fix this properly

rip rgba then

god that entire feature was such a nightmare

15:41

I mean it should work right now

it worked for other rgba values too

15:41

only that one not

okay that does not make sense at all

15:42

@jao dbg_msg("DEBUG", "%d %u", str_toint_base("E0007897", 16), (unsigned)str_toint_base("E0007897", 16));

15:42

can you just print that?

I’m not at home now

I'll make colors an unsigned integer instead just to make sure we are doing things that aren't at the mercy of the implementation

aren’t they already?

I kinda cheated, I still save them as integers

15:44

(ab)using the sign bit

oh

but then as said by the standard the conversions aren't well defined

btw why do you floor instead of rounding properly

@jao you mean round_truncate? I think it was the behaviour in the past that's why I kept it

https://itsfoss.com/windows-linux-kernel-wsl-2/

Bad News! Windows 10 Will Soon Have a Real Linux Kernel

The upcoming version of Windows 10 will feature a real Linux kernel in it as part of Windows Subsystem for Linux (WSL). You would be able to update this Linux kernel through Windows updates. And you thought Marvel's Infinity War was the most ambitious crossover in history!

why u put this shit articles here

is the fucking woman needed

[ddnet/ddnet] Pull request opened: #1733 Store colors unsigned

Using the sign bit doesn't seem the safest. C++11(4.7p3)

If the destination type is signed, the value is unchanged if it can be represented in the destination type; otherwise, the value is implementation-defined.

and C99(6.3.1.3) seem to agree that the conversion from long to int is implementation-defined and thus could differ. I'm not really certain if it matters though, as it's rare to have an implementation that doesn't just discard the extra bits and within an implementation...

interesting, why would windows want a linux kernel in it? what would the linux kernel do even? (nt kernel would be running ring 0, I don't see what the linux kernel would manage)

fake articles exist troll

troll

"This is strictly my opinion. You may call it rant, I don’t really mind. Microsoft is infamous for its Embrace, Extend, Extinguish policy. It has started ‘loving’ open source and Linux in the last few years but before that Linux was cancer. The so-called ‘love for Linux’ seems more like ‘lust for Linux’ to me. The Linux community is behaving like a teen-aged girl madly in love with a brute. Who benefits from this Microsoft-Linux relationship? Clearly, Microsoft has more to gain here. The WSL has the capacity of shrinking (desktop) Linux to a mere desktop app in this partnership. By bringing Linux kernel to Windows 10 desktop, programmers and software developers will be able to use Linux for setting up programming environments and use tools like Docker for deployment. They won’t have to leave the Windows ecosystem or use a virtual machine or log in to a remote Linux system through Putty or other SSH clients."

linux kernel is licensed under gpl and derivative works must be under gpl

16:19

ur opinion is shit

it has quotes

16:19

coz i quote

troll

1

ur opinion is copypasta

"The Linux community is behaving like a teen-aged girl madly in love with a brute. " by reading this it tells me u suck

16:20

and know nothing

are u retarded or what

@Ryozuki they'll be sure to make their contributions public under the gpl

i'm actually quoting the article

ah

xd

why put that shit here tho

16:21

xd

16:21

@Learath2

Image attachment

16:22

looks like its not all clear

the derivative work would be WSL, worst case they'd need to open source that

the only good thing about this is that if you are a linux user and u are forced on a windows only enviroment on your shitty company u might have some breathable air

i think even gpl 2 isnt infectious enough to include windows and nt kernel with it

otherwise suck suck

besides gpl hasnt been tested in courts

16:24

microsoft surely has the money to beat a dragged out case

yeah microsoft beats others by using money everywhere

16:24

it has always been

16:24

cancer company

suck sucks

capitalism \o/

wouldnt they lose shit ton of money or something

https://news.ycombinator.com/item?id=12827377

tptacek

Hasn't the GPL been tested in court repeatedly?

16:25

@Learath2 "The fact that GPL cases often settle does not mean the GPL is weak. In fact at least in some cases it's because the violators know they will lose and have no motivation to proceed to trial."

@Ryozuki iirc it never went to trial, it's generally settled

16:25

yeah that

16:25

but the thing is, even if it isn't weak a case that isn't settled will take a HUGE amount of time given there is no precedent

all hail linux and debian, case closed

as time goes on the rich people get the upperhand as they have a metric fuckton of money

yeah

16:26

justice works by money

16:26

not by "justice"

in america atleast

everywhere i would say

well atleast here in italy I can sue someone for stealing my money

16:27

in america I'd need a lawyer

well idk much about law

16:27

xd

16:28

do u use arch learath?

currently yes

16:28

my experiment to gain experience with systemd goes on

Image attachment

16:29

xddd

just make linux be in europe and then do EU bullshit troll

troll

just so I can call systemd garbage and people cant call me out on not having used it

@Learath2 by using linux u are a teen-aged girl

16:31

according to the article

16:31

poggers

I think it means the general linux community that keeps crying about the "YEAR OF THE LINUX DESKTOP"

xd

16:32

https://www.reddit.com/r/linuxmasterrace/comments/bnsg42/why_i_actually_use_linux_fancy_terminals_and/

r/linuxmasterrace - Why I actually use Linux - Fancy terminals and...

878 votes and 61 comments so far on Reddit

16:32

linux best

why would you want that even

for fun

16:33

teen aged linux girls use https://www.montanalinux.org/

16:34

wait

16:34

its not that, u can try it here http://hannahmontana.sourceforge.net/Site/Home.html

16:34

lmao

@Learath2 when I tested some rgb values where off and that sounds like a reason for it

my god, there actually is an iso and all

16:34

@jao you mean the rounding?

yes

It'd be more accurate if we rounded to the correct direction, yes

16:35

if you have any example i'd like to check it out aswell

16:36

but the old code rounded down so I kept it iirc

old code was bad

16:37

well one value was off by 2 so there might be another inaccuracy

if you know the color I can check specifically why it happens

also don't forget, the less saturated a color is, the worse it maps to rgb

16:53

e.g. half of the hsl space doesn't map to rgb space

yea

16:56

but the round truncate still feels wrong

maybe if we could get a better way to round

16:57

the property we need while rounding is making sure its invertible

why is it even wrapped in a function

@jao I wrapped it so it's obvious what I'm doing and where I'm doing it

16:58

I anticipated that it wouldn't be the best way to round, so it's useful to know where it happens

xd

16:59

why do you have to invert it?

if its invertible then it's consistent on the round trip

16:59

1 HSL always maps to 1 RGB

17:00

On the bottom of the rgb vube that is

17:00

cube*

17:00

maybe we should quantise the 0->1, so that only integer multiples of 1/255.0f are allowed

17:01

or round to the closest 1/255.0f

round to closest

welll doesn't really help much tbh

17:08

#a96836 is 169 104 54

17:09

after going through hsl and coming back it's 168.0 102.2 53.9

17:09

rounding closest only fixes the blue, the roundtrip to hsl isn't really safe

17:11

rounding down is the correct choice here

17:12

or you map more of the rgb range into the closure of the interval then the boundry

would that be too much work (i mean to integrate in the latest version) if i work from hmh's branch video_rebased2 to create a demo to video thing?

i'm not sure

17:15

you can try to git rebase and see how many conflicts you get

because right now i succeeded compiling from hes sources

17:15

k

when are you converting that back to hsl tho

17:22

it’s only output isn’t it

everything entered is converted to hsl

17:22

teeworlds stores hsl colors

17:23

i didn't dare break all the old color codes

so what roundtrip are you talking about

you enter $a96836

17:23

that's rgb

17:23

it's stored as hsl

17:23

now when displaying the rgb values again it goes back to rgb

and why is rounding to closest unsafe? you are doing it only once?

rounding to closest is wrong

in your example it’s more accurate

if you round to closest, 0 gets 0 ->0.5, 1 gets 0.5 -> 1.5

17:26

every integer except 0 and 255 get an entire 1/255 of the space

17:26

which isn't right

I don’t get why it’s wrong if it’s more accurate

it's more accurate in this example

17:27

it's less accurate in some other example

can you show one

I can probably find one if I look, but that's beside the point imho, equipartitioning the space just makes mathematically more sense

in my mind this can’t be worse than how it is now

not like it's any different currently, you just never saw the rgb values

17:29

this is always what we rendered

yes it’s only output that’s why I don’t get how it’s unsafe

it's not unsafe, it's just not correct, this isn't correct either though, I should be multiplying by 256 and then rounding down

17:35

besides, it's not the rounding in the case of this number

17:39

[2019-05-15 19:38:31][DEBUG]: R: 169, G: 104, B: 54, #A96836if I print it out before the conversion to hsl and back

@Learath2 how does git rebase work? xd

it takes current branch, and the target branch

17:53

finds their common ancestor

17:53

then takes all the commits from the common ancestor to the current branch tip and applies them onto the target branch tip

hmmm

17:53

but the master branch of hmh is old

17:54

so how can i do?

@heinrich5991 you are better versed in math, can you give me a hand with all this when you have time?

17:54

@archimede67 you rebase hmhs branch onto ddnets master

but they are two branches in separate repos (edited)

@jao I think we just don't have enough bits to store accurate enough hsl to be able to get back to rgb

sad

@archimede67 they aren't

17:56

well yes they are

17:56

but you can add ddnets remote to your repo

17:57

git remote add ddnet git@github.com:ddnet/ddnet.git

i did that yea

then git fetch ddnet

oh yea i forgot that

then git rebase ddnet/master when you are on hmh's videoconv branch

I will try to prove you wrong

with the colors?

yes

I'm fairly sure the correct mapping is round_truncate(rgb.r * 256.0f)`

17:58

but the problem with my above example isn't that

why 256?

I have 2 conflicts

@jao to avoid the issue i mentioned earlier

17:59

but that's not the issue here either

17:59

the issue is that color has a large mantissa in it's S and L when converted

18:00

26.09 H 51.57 S and 43.73 L

18:00

the .57 we can't store, we can either round up or round down

18:01

either way it's 0.5 off

0.43

the .73 we can't store, currently we are .7 off

18:01

so after that it's already no longer the same color

18:02

it's now #a66636 rgb

well it's about accuracy

I started with #a96836

18:02

say you round it up when storing the hsl, it's #a96937

18:03

it's not going to be exact when we have only 255 possible values

rounding up is closer tho

18:03

in that case

also the hsl conversion between all implementations

18:04

is a little different

18:04

we don't really get 26.09 for the hue but we get 25.41

18:04

I think that's where the bug is

18:06

but the implementation of RgbToHue is the exact one from wikipedia

18:12

okay nvm, i found where the inaccuracy is

18:12

the hue is calculated correctly but when it's stored it needs to be mapped to 0-255

I don't like that you can enter wrong hex values

it's impossible to do any better without starting to store those instead of tw colors

18:14

I mean it's better to slightly improve it by equipartitioning like i said

18:15

should we start storing rgb hex colors?

@Learath2 how good is ur bash? justatest

justatest

@ChillerDragon enough to do whatever i need to really

sorri if im interrupting here

18:15

oh send help then

well most colors make more sense in hsl?

echo "g" | grep g | ./bot.py works tail -fn1 logs/0.log | grep g | ./bot.py

18:16

doesnt

@jao colors are easier to manipulate in hsl

yes and logs are full of g xd

but I guess storing as rgb is more accurate

bot.py

        while True:
            line = sys.stdin.readline()

@ChillerDragon I don't see what that's supposed to do

18:17

pass along lines that contain g?

yes

18:17

i want to filter tail and then pass it to python

18:17

i can pass tail to python

18:17

i can pass grep to python

18:18

but i cant pass tail to grep and then to python

anyways grep waits until the input is done iirc

somewhere data gets lost

18:18

ah

tail -f is never done so that's prolly it

that makes sense then

18:18

rip

18:18

any ideas?

18:18

i could also filter in python

18:18

but i prever grep cuz ez xd

filter in python

18:19

and learn more python meanwhile

-.-

18:20

u better learn bash

18:20

its best

@Learath2 can we return an invalid color instead of defaulting to black when entering a wrong color

18:21

i.e. don't update the color if u enter something wrong

I thought about that but couldn't figure out a good interface for it

18:21

maybe a bool m_Valid in color4_base and an override for !

18:22

or maybe a ColorInvalid that fails to cast to any other color

y

can't do the second one, the functions are supposed to return ColorHSLA

18:23

I guess the first one it is

ColorHSLA(-1, -1, -1)

color4_base(-1,-1,-1) and bool color4_base::isValid() that returns false if the components aren't in 0-1 range

@Learath2 four mentions. did I miss something important?

18:26

even today has >1000 messages

@heinrich5991 the first 3 was probably while we were golfing, wanted to see if you'd join

18:27

the last one I have a math question about mapping intervals

sure. PM in order to no spam the channel?

buy heinrich o,O we all have nothing better to do than spam and read #developer all day feelsamazingman

feelsamazingman

18:35

busy* not buy ^^

hex rgba works with your pr btw learath

@jao it's ARGB or RGBA>

18:49

?

rgba

some uses ARGB for hex values

so which one do you want

rgba(rrr,ggg,bbb,aaa)

[ddnet/ddnet] Issue opened: #1734 teammask wrong set

if a player is in super, the teammask is set incorrect, you cant see his projectiles.

Exported 531 message(s)