DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2019-04-26 00:00:00Z and 2019-04-27 00:00:00Z

@ChillerDragon try on ddnet++ to see if its a problem with Gameflag flags acitivated

it worked on KoG idk what gameflags you mean

Gameflag Flags

09:12

it is for telling the client the server uses flags so the client can render them in scoreboard and kill msgs

09:14

but technically shouldnt

ah

09:20

ya but the thing is that i put dbg messages everywhere and the debug messages told me that it executed the gameflag branch

09:21

if(GameFlags&GAMEFLAG_FLAGS) printf("gets printed\n");

@ChillerDragon the score thing gets rendered in one function

09:36

just breakpoint there?

and then?

09:49

idk baut breakpoints never used them especially not in windows

[quakenet] <Learath2> well when you break there you can step line by line

10:36

[quakenet] <Learath2> see why it doesn't get rendered

i dont know in what it gets rendered

11:06

all lines that i assumed are responsible for rendering are reached as my print messages show me

11:06

also idk how to go step by step. I dont have visualstudio setup or something

@ChillerDragon gdb?

oh rip

11:08

i dislike gdb on windows -.-

dont use windows

i only have the bug on windows as far as i know

dont use windows

11:08

:D

we are missing some linux emojis @jao

11:09

i want to react with debian to every message ryo posts

debian best

feelsamazingman

1

yes

11:10

lol

11:11

@ChillerDragon I'd just like to interject for a moment. What you’re referring to as Linux, is in fact, GNU/Linux, or as I’ve recently taken to calling it, GNU plus Linux.

11:11

Image attachment

Image attachment

11:12

10/10

https://www.reddit.com/r/debianinrandomplaces/

r/debianinrandomplaces

and what is linux then?

nothing

lol there is no linux

11:15

feelsbadman

:feelsbadman:

11:15

feelsbadman

11:15

xd

11:15

fail

@Ryozuki i manually ported ddnet character and all that stuff from all commits to my mod, but if i am in super and hook someone the hook is invisible and the collision for player <-> player is bad

11:35

but i applied your fix already

11:36

any idea?

no

11:36

no time for other mods sry

@Ryozuki here?

y

can you give me a hand with my pr? I'm trying to find where would be the best place to lighten the colors back up for tee colors

ok

I was thinking CRenderTools::RenderTee

@Learath2 r u sure u want to keep iostream in there

12:08

or did u missclick

12:08

xD

I think that last commit removes that

https://github.com/ddnet/ddnet/pull/1678/files

Handle colors in console by Learath2 · Pull Request #1678 · ddne...

DEPENDS: #1654 A better way to fix #1581 possibly deprecates #1597

12:08

it shows there for me

12:08

or u mean local

12:08

god damn that big image

12:08

xD

it keeps coming back

12:08

iostream wants to be ther

i am fine with iostream tho

12:08

but other vanilla ppl

12:08

might outrage

12:09

@Learath2 "best place to lighten the colors back up for tee colors"

12:09

what do u mean exactly by this btw

12:09

i think tees are rendered on client components players

You remember when black tees were a thing?

12:10

whenever we read a tw format color, we change the lightness of it so it's not too dark

isnt this why hsl is limited or smth

that's how we fixed that

i wonder why its dark

but for UI colors we didn't need that limit

12:11

when I unified the color thing I removed the extra lightness

12:11

so that we can have one consistent format for colors and they work as intended

12:12

as a side effect we no longer light up the tee colors so blacktee is possible again

and we want that or not?

(locally, remote clients will still read the color the old way so black tees appear gray)

12:12

we want to light it up locally aswell

shouldnt this be easy? make some method on color4_base

12:13

or smth

The thing is when it gets to RenderTee the color is already RGB

12:13

RGB isn't too easy to "light up"

ah

and I'm not sure if converting to HSL, lighting it up, then converting back to RGB is the best of ideas

looks ugly

12:14

how hard is it to light up rgb xD

not a well defined operation in rgb space

12:15

in hsl space it's literally translating the point

12:15

in rgb it could go anywhere

12:16

(basically RGB->lightUp() would boil down to convert to hsl, light up, convert back)

hmm i would put a virtual method on color4_base and implement it diferently on ColorRGBA and ColorHSVA, where colorgba creates a internal ColorHSVA and lights it up

12:16

its ugly

12:16

but its hidden

12:16

xd

Hmm, that sounds doable

12:17

or maybe I should do it with a ConChain on the tee color configs

12:17

e.g. light it up when it gets changed

idk what a ConChain is xD

In console, you can register a function to be called before the registered function is called

:o

TYL

12:18

it's how we handle sending the new info when player color/name/clan changes

bluekitty

12:19

i am doing some shit with sql

12:19

i wonder why ddnet doesnt use

12:19

prepared statements

sql is fun

12:19

@Ryozuki heinrich was working on rewriting the entire sql backend and using prepared statements

12:19

but then life happened

i am doing the same xd but idk if im good

12:20

im making a thread safe queue

if you are doign that yeah

12:20

make it thread safe while at it

12:20

we literally call into CGameContext from other threads

yes

12:20

sendchat

I really wonder how it hasn't crashed by now

xd

12:20

idk either xd

also the way we do vectors is UB if you aren't careful

12:21

but it's sane enough that no implementation would really "break"

what is UB

undefined behaviour

im not using system.c xd

12:21

im using c++11

12:21

stl

for tw code?

Image attachment

12:22

yeah

12:22

ima enforce

12:22

modern code

12:22

xd

god that looks scary

xd

12:22

ye thats why im not sure

12:22

i never made things like this

12:22

thread and stuff

12:22

im learning xd

I think we already have a thread safe queue in base

12:22

for a queue a semaphore would be more appropriate then a lock imho

@Learath2 whats the dif between semaphore and mutex

12:23

or lock

12:23

i think std doesnt have semaphores

a mutex is a lock

12:25

i think the only difference is that a mutex generally refers to the version that can be accessed by multiple processes aswell

12:25

a semaphore also is a counter

i think i can use a std::condition_variable

yeah that also works

12:26

@Ryozuki if you want a refernce https://github.com/ddnet/ddnet/pull/897

Implemented a threadsafe queue using C++11 by H-M-H · Pull Reques...

This also contains a wrapper for condition_variables which manages the lifetime of the mutex required for the condition_variable.

12:26

hmh wrote a decent one

12:27

think he used a lock

heinrich5991 commented on 24 Nov 2017 As discussed on Discord, this queue is currently thread-unsafe.

nope, he used a cv

xD

12:27

threading looks like a shady world

@Ryozuki "Some people, when confronted with a problem, think, 'I know, I'll use threads' - and then two they hav erpoblesms."

lol

1

lol

Or

Knock knock.
Race condition.
Who's there?

lol

xd

how inappropriate would it be to add a CFGFLAG just for colors?

lemme check what a CFGFLAG is first xd

12:41

ah

12:42

why u want to add one?

CFGFLAG_COLLIGHT

12:42

if that flag is set then when reading the color it will get light up

oh

12:42

i think its fine that

12:42

i like it

or I can rewrite the macro to have an extra parameter

since all colors that need light up are user input

I'll add a CFGFLAG for now

12:43

if people don't like it i can re-do the macro

Does anyone know how I fix the player and hook colission for super? i have added the ddnet character and all the needed stuff to my mod, but if i am in super and hook someone the hook is invisible

[ddnet/ddnet] Pull request opened: #1681 Add a simple threadsafe queue

@Ryozuki https://github.com/ddnet/ddnet/pull/1678/commits/69d78c2

Handle colors in console by Learath2 · Pull Request #1678 · ddne...

DEPENDS: #1654 A better way to fix #1581 possibly deprecates #1597

13:39

looks good?

@Learath2 help :c

except for the template blackmagic

13:40

@fokkonaut gimme a minute I need to switch tables

oke

ye looks good to me xD

@fokkonaut what do you need?

scroll up a bit

you have about 15 minutes before I go afk

oh wow :D

13:55

yea do you know how i can fix it?

13:55

basically i have merged all the code made to server/engine manually. but it doesnt work

13:56

the client doesnt update it properly

it doesn't ork is not a diagnosis

maybe related to my issue

13:56

https://github.com/ddnet/ddnet/issues/1680

new antiping · Issue #1680 · ddnet/ddnet

cl_predict_freeze is only acitve when antiping is on (dont know if that is correct?) the weapon switch is delayed and not immediately aswell as the fire animation of the weapon

do you have your code up on github?

yes

13:56

its https://github.com/fokkonaut/BlockDDrace

fokkonaut/BlockDDrace

BlockDDrace is a mod for Teeworlds, developed by fokkonaut - fokkonaut/BlockDDrace

you merged ryozukis code in?

yes

okay, this is way too much code to look at in 15 mins

14:01

i can help you debug it though

14:01

first make sure all the data arriving is correct

how?

14:02

i placed debug messages in gamecore, and everything was correct

14:02

at the time when i hooked someone

void CGameClient::OnNewSnapshot()

14:03

check if the object is unpacked correctly

sec ima add a dbg msg

14:04

what do i have to chec kfor

14:05

yes

14:05

my debug message gets printed

14:05

every tick

14:06

i placed it inside of this: else if(Item.m_Type == NETOBJTYPE_DDNETCHARACTER)

print the m_Flags

how?

14:09

oke lol

...

the client know that i am super

okay then it's the prediction code

so its related to my issue

14:10

?

14:10

https://github.com/ddnet/ddnet/issues/1680

new antiping · Issue #1680 · ddnet/ddnet

cl_predict_freeze is only acitve when antiping is on (dont know if that is correct?) the weapon switch is delayed and not immediately aswell as the fire animation of the weapon

I never touched it, so you'll need ryozuki to give you a hand, and he doesn't seem to have time

i think trml needs to fix that

14:14

updated my issue: https://github.com/ddnet/ddnet/issues/1680 @trml

new antiping · Issue #1680 · ddnet/ddnet

cl_predict_freeze is only acitve when antiping is on (dont know if that is correct?) the weapon switch is delayed and not immediately aswell as the fire animation of the weapon

oh, yeah, I'll fix that

damn you are here xd

I just came home:P

otherwise your prediction code is insanely amazing!

it may be related to your issue, I'll check

14:16

nice, ty

check my issue on github, wrote a few things

[ddnet/ddnet] Issue opened: #1682 since newer versions projectiles dont appear on big maps

in my test case it was BlmapChill, a very big and old map. ddnet client 12.3.1 not the server, changed map -> worked again maybe related to the new prediction code

Is anyone here on windows?

me

18:08

rn

18:08

xd

18:08

just fixed my boot

@Ryozuki https://github.com/ddnet/ddnet/pull/1678

Handle colors in console by Learath2 · Pull Request #1678 · ddne...

DEPENDS: #1654 A better way to fix #1581 possibly deprecates #1597

18:10

can you try compiling this?

ok

18:11

Image attachment

I think windows.h declares some min/max macro.................

compiled client and sv

18:16

@Learath2 is this all?

18:17

oh im not on a clean cmake btw

welcome to the bright side ryo

i incrementally built it

18:17

@Learath2 also im on mingw

@Ryozuki it compiled for you?

18:17

oh

im not gonna install msvc bloat

18:17

xd

mingw probably takes care of it

I can build with vs if u want

good jao

@jao yes please

git fetch upstream pull/1678/head:learathpr

18:18

:P

18:18

xd

I add pullrequests to my normal fetch

18:19

it's useful to be able to do git checkout ddnet/pr/1678

u do git checkout learathpr after

18:19

hm idk

18:19

i never checkout prs anyway xd

if you add the pr's to your remote config they are fetched along with branches

how to do that

fetch = +refs/pull/*/head:refs/remotes/ddnet/pr/*

18:20

in .git/config under your ddnet remote

18:22

I put ddnet there but you obv need to rename it the same as your own remote

https://mystb.in/tujiqufibe.shell

A fast intuitive paste service.

hello Jannis

18:24

@jao

feelsgoodman

lol

lol

can you add #define NOMINMAX above windows.h includes? @jao

18:25

There is one in system.h, one in client.cpp and one in server.cpp

18:25

maybe we should add those to our cmakefile, we never include without LEAN_AND_MEAN anyways

#define windows shit put this everywhere

#if defined(CONF_FAMILY_WINDOWS) #undef CONF_FAMILY_WINDOWS #endif

xd

18:26

#define for while(true) { //

@Learath2 system.c ?

yeah

18:27

accidentally wrote .c

18:27

.h *

18:27

...

same errors

god damn windows

18:30

if you have a little time can you try one more thing?

ok

add target_compile_definitions(${target} PRIVATE /DNOMINMAX /DWIN32_LEAN_AND_MEAN=1) below L1627 in CMakeLists.txt

[ddnet-web:master] 1 new commit

b040e26 frontpage video - def-

:o

same errors @Learath2

the mind boggles

love it when github is reaching me before my youtiube subs

can you show me around the error? maybe the compiler call itself if its possible

we need the cmake god to fix things

18:39

twintri

oh wait thats a week old

18:39

didnt see that xd

https://github.com/ddnet/ddnet/issues?q=is%3Aissue+is%3Aopen+label%3Abuilding

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/ddnet

18:40

xD

imagine having so much control with hf :/

Quite impressive skill

18:41

I'm happy I can hf at all

what's funny is I still remember back when we were all figuring out hf

18:42

few people could hf properly even less drove properly

shit vid but it shows hf progression on just fly 1 xd https://www.youtube.com/watch?v=oH-dHqN2RcY

[Teeworlds] DDrace - Just fly 1 2011-2015 + Bonus

now it's like what can't we do flying

@Learath2 https://mystb.in/waminehewo.shell

A fast intuitive paste service.

@Ryozuki you should add the most recent video I guess

@jao thanks for trying but doesn't show the compiler call and idk how to get it to show on windows :/

18:44

@deen if you have a couple minutes could you give it a try?

:(

give what a try?

@deen compiling https://github.com/ddnet/ddnet/pull/1678

Handle colors in console by Learath2 · Pull Request #1678 · ddne...

DEPENDS: #1654 A better way to fix #1581 possibly deprecates #1597

18:46

windows.h seems to define a min/max macro

18:46

#define NOMINMAX is supposed to stop it

just don't define min/max yourself

18:46

call it something else

base/math.h has been defining min/max since the beginning of time

but why extend it?

why not use std min max

and why just 3 values, why not variadic?

18:47

and I don't have windows

@deen it's the extent of my template abilities

you can have variadic templates that recurse

i'm not up to snuff on metaprogramming

and a specialization to stop

monkaS

I'll take a look, but either way windows.h defines a macro

https://stackoverflow.com/questions/49786142/variadic-recursive-template

Variadic Recursive Template

I have a particular format that requires space delimited tokens with a final null terminator (the null is part of the output). I created a function to send a series of space delimited tokens to an ...

I'm not serious about adding that

18:48

It's a pain to debug

I guess I'll go diving for a windows CD

18:48

or maybe a usb lying around somewhere

cd?

18:48

thats not used anymore xd

grab a floppy

18:49

u need about 2900 floppy disks

18:49

a guy did it

18:49

with windows 10

found a windows xp cd...

oh god

18:50

i think ucant install latest msvc

18:50

there

doubt that's new enough

idk

18:50

@Learath2 u know u can download windows 10 iso from windows and u dont even need to use a key or shit

I'm back in turkey

18:50

third world internet

xd

I have a usb with some version of windows, I'll install it and hope it's not vista or sth

good luck

fiber internet has been coming to this building for the last 6 years

i remember my days without fiber internet and playing tw

one would think I'm in a village or sth

it was such a horrible experience

18:54

now i got 600/600 :P

it's the middle of one of the densest populated cities on earth

thanks god

18:54

how many ppl

16 million documented people

18:55

very small city istanbul

documented xD

yeah, a lot of people that immigrate from villages and never register

18:55

and a lot of syrian refugees, can't even walk outside on weekends anymore

getting virtualbox to boot off of a usb is just mental

[quakenet] <deen> why would you run windows for this problem?

19:24

[quakenet] <deen> just don't add another min/max function

god fine, i'll name it minimum and maximum....

19:26

so much grepping to do

what sdif with egrep and fgrep and grep

have you tried the manual page?

19:28

"egrep can handle extended regular expressions (EREs)"

19:28

"fgrep is quicker than both grep and egrep, but can only handle fixed patterns (i.e. it does not interpret regular expressions)"

[quakenet] <deen> but why have a min, max with 3 params?

19:29

[quakenet] <deen> I don't understand what it has to do with your change anyway

19:29

[quakenet] <deen> i thought the change is about colors

conversion from rgb to hsl starts with a max3 and a min3

19:30

i found it ugly to do min(min(r,g),b)

why does my float not change its value if i add something to it -.-

19:39

Image attachment

[quakenet] <deen> What was wrong with the 2-param min/max? I thought they worked fine

You really would prefer min and min3 instead of one name for all of them?

19:41

They work fine, but it wasn't using our min and max, it's been using the macro one defined by windows.h all along

yo deen do you use windows at work?

did u read his blog

no

19:43

xd

19:44

well some of it

[quakenet] <Learath2> I'm keeping it minimum/maximum for now, can tackle that when merging

19:48

[quakenet] <Learath2> my w key is sticking, this will be the third time I get this keyboard replaced :(

wtf

2

my teeworlds are only appearing on the servers of GER and Rus :\

@xXpitiXx what server would you like to join. Go to ddnet.tw/status and copy the ip of the server.

does not work. the server is online but I can not connect

PathosEthosLogos

[ddnet/ddnet] Issue opened: #1683 New antiping issue: (ghost) shot - switch weapon - shoot

The new antiping feature is disconnected between visual and audio side of prediction. For example, if you shoot laser, then switch to another weapon faster than your ping, it shoots the laser silently (and the shot obviously doesn't register) and another weapon's bullet comes out with audio on. Visually, it looks like there are two bullets coming out almost simultaneously. (You don't have to start with a laser) Not synchronising audio is also not intuitive. Either antiping both visuals ...

I don't even remember why I started working on colors now

Exported 402 message(s)