DDraceNetwork - developer

808bb13 Disable demo shortcuts in console - 12pm 8c85d0d Merge #1661 - bors[bot]

14:43

[ddnet/ddnet] Pull request closed: #1661 Disable demo shortcuts in console

cl_Showfps

cl_showfps

bois try to use tab in console

cl_showpred 1 to show ping

it recommends and autocompletes everythign u need

dont forget the 1

nobody uses the console

lol everybody does?

14:44

uhm should?

14:44

i did it for ever

ur not being realistic

14:44

ppl might open it once

14:44

to change 1 thing

14:44

but they dont use it

its best

idc

1

-.-

Can one of you take a look at my color pr?

pushy!

14:58

looks liek build failed o.O

14:59

why is abs() overloaded -.-

14:59

seems like some classical maths.h double include what every thingy

15:00

lol GetColorV3 and V4 are both HslToRgb ?

15:01

ah ye one is 3 demensional vector and other one 4 i see the name makes sense xd

It was all so weird

15:02

some normalized, some not, there were like 3 copies of hsltorgb

since this color.h looks pretty excluded from the src im sure it wont be too much effort to setup tests for it

I have a couple in mind, but I couldn't get HslToRgb and RgbToHsl to completely agree :/

15:04

It's within 0.01% but not exact, I guess that's a result of floating point math

floats suck -.-

15:04

cant we replace it with int?

yeah I'm not a huge fan either of the way they work, but they are all we have

15:05

HSL is bi-conical space, rgb is cartesian, the conversion is a geometric one so it involves math that needs to be quite precise

15:06

you could use fixed point arithmetic I guess, but floats are good enough in this case

https://github.com/ddnet/ddnet/pull/1654/files#diff-4767dc694becb1f7e4a07ed2b9f4cfcbR594

Try working on colors a bit by Learath2 · Pull Request #1654 · d...

There were color functions everywhere, I tried cleaning it up a little. I still couldn't get the roundtrip from Hsl to Rgb to be exactly the same, but I think this is the best possible.

15:06

there is no f

15:06

1.0f

!!!!!!!!!!!!!!

15:06

eagle eye jao

yeah wtf jao

any ideas regarding the abs() compile error?

15:07

ah nvm

15:07

fixed already

the thing is

15:08

opengl uses floating color

15:08

maybe u can use ints with normalize but idk

any idea why i cant join ddnet++ (based on ddnet 9.0.2) with vanilla 0.6.5 even tho i cherry picked https://github.com/DDNetPP/DDNetPP/commit/7cbfbb01e65a8a33c7a669b4daf33d896aa1c7d2

Remove hacky security against rcon spoofing because we have a bett...

…one now (cherry picked from commit 91df0a2af0c918358d9ef2d213ca6f0ea969e8d5)

ddnet++ boo

xd

no one cares about it xd

wym?

i guess its related to anti spoof

15:09

that vanilla 0.6.5 wont join old ddnets

did you merge the 0.6.5 fixes? i think heinrich changed the connect packet

no only the commit i sent

also why is your ddnet++ not a fork of ddnet/ddnet ...?

which one is missing?

they dont even use cmake

it was created 2015 i didnt even know what git is

It's almost as infuriating as ddnet/ddnet not being a fork of teeworlds/teeworlds

lol

15:11

no thats fine

15:11

ddnet is ddnet

it has commit history tho doesnt it?

yeah, but makes pull requests harder across repo

was ddrace a fork of vanilla`?

iirc

ddnet is a fork of ddrace64 iirc which is a fork of ddrace16

15:12

or smth weird

ya i also dislike it that ddnet++ is no fork but its years too late

15:12

ddrace16 xd

15:12

wtf

15:13

teeworlds has even weirder forking than linux xd

ddnet should be a fork of eeeee's ddraceN or ddrace64 yeah

iDebian64++

15:14

so @Learath2 do you know how i can find heinrichs commit -.-

15:14

any string to search for or commit hash

15:15

https://github.com/ddnet/ddnet/commit/16694a0d7b658841971fef29ad1aae43379c8677

Use a random token for serverbrowse requests · ddnet/ddnet@16694a0

This alleviates the risk for spoofed servers.

15:15

that one?

a83e3e0 Add delete projectiles on death settings - 12pm 34542e6 Merge #1655 - bors[bot]

15:15

[ddnet/ddnet] Pull request closed: #1655 Add delete projectiles on death settings

@ChillerDragon gimme a minute, I'll push this then I'll find you the commit

sure thanks

Learath2

[ddnet/ddnet] Pull request opened: #1662 Fix platform-specific client libraries for Linux. Fix #1660

Do not hardcode library names, detect and depend on them properly instead.

@ChillerDragon iirc https://github.com/teeworlds/teeworlds/commit/a263185571903ead01f6b351a91ea219ac9d215f

Add tokens to the protocol · teeworlds/teeworlds@a263185

Tokens are added to the protocol in order to prevent IP spoofing attacks from being successful. A new flag has been added to the packet header, in previously unused space that has incorrectly been...

yo @Learath2 where did this random FreeBSD contributor appear from?

15:21

is he even part of tw community?

That's the main commit, but take a look at 0.6.5-release tag on teeworlds/teeworlds

thanks

@ChillerDragon I'm guessing he was packaging ddnet for freebsd ports

sikk

.s/ddnet/teeworlds/

?

15:22

substitute?

15:22

xd

yes

nerd

15:23

xd

it's sed syntax

ikr

discord supports it natively btw, if i don't add the "." before it would edit

1

sure

they implemented it horribly though, if you write out the pattern completely, it adds the last / aswell...

wait r u actually not kidding? xd

I actually am not kidding try

foo bar baz s/foo/bar/

15:25

how where? xd

separate message

yeet/= (edited)

15:25

xxxxxxxxxxxxD

15:26

omegalul

see, but it takes the last slash because discord people are fake nerds

15:26

they are pretendnerds

i see

15:26

xxxD

15:26

rofl

also it doesn't support using a different seperator

i mean it has to be developed by a developer

like s#kek#lol#

he should know tho

15:27

i guess u can be developer without being nerd

15:27

bad developer* :p

15:28

uff ehrinrichs commit is huughe it is exactly liek this in ddnet as well?

no that's the vanilla patch

15:29

i can look for the ddnet one if you want

yes pls c:

15:29

i sukk at searvhing the stuff

https://github.com/ddnet/ddnet/commit/c7750f36

Don't ignore CONNECT packets with data that we don't know · ddnet...

This specifically affects 0.6.5. Just treat them the same way as those without any data.

15:31

why did you stray so far from ddnet/ddnet?

wdym? why it is such a old fork?

yeah

as i said when i started coding the mod i didnt know what a function is or what git is

15:33

after the years it was too late already and its not that i miss any features from newer ddnet

15:34

its more the opposite i prefer the old rcon system

15:40

oh btw thanks a lot @Learath2 vanilla 0.6.5 can now connect to ddnet++

we have a new rcon system?

yes rcon system changed afte r9.0.2

15:40

with username

That's disabled by default

that was not supported by ddnet 9.0.2 clients

I think only we use it

broke compatbility

15:41

i was hardcode ddnet 0.6 user back then

15:41

so i wouldn update my client

15:41

xd

old clients are completely capable of logging into rcon on new servers, as long as usernames aren't enabled

im pretty sure i had troubles

15:42

or no wayof authing on my local server

we had a little bit of trouble the first week but it was fixed quickly

i remember that after executing one command

15:43

rcon stopped working

15:43

but i can confirm u fixed it

15:43

tested with ddnet 6 client and ddnet 12 srv

Learath2

[ddnet/ddnet] Pull request opened: #1663 Use freeze end tick instead of a flag. Fix #1659

I used -1 for deep frozen, and 0 for not frozen. Not really sure if this is the best way.

dont mess up freeze xd

learath why is it a draft pr

qshar style

@Learath2 why u removed telegun?

16:08

these flags are 1 bit

16:08

oh nvm

16:08

i read the diff wrong

16:09

xd

16:09

not my day

1

@jao I don't want it merged before heinrich takes a look at it aswell

16:15

He tends to be better at looking at the long term

jao is the float spotter tho

16:16

16:16

deen and heinrich4991 ddnet++ contributor confirmed

16:16

.s/4991/5991/

@gdin

16:22

I've found a issue ?

16:22

when you save

16:22

and go in solo

16:22

and you load

16:23

you cannot hook the person who went in solo

16:23

and you see him as ghost

seeing someone in solo as ghost is because u have showothersalpha enabled

16:23

ofc u cannot hook someone who went in solo

16:23

whats wrong???

16:24

and why gdin xd

all u described is how it should work

calm down ryozuki

?

i mean

16:26

he didnt have showeveryone enabled

16:26

and he still saw me as ghost

16:26

@Ryozuki

one was in solo before u made /load?

yep

16:26

i mean

16:26

that's the problem

16:26

why is it like this

16:27

it shouldn't be like it

/load kills you though

alpha is independent if u have showeveryone or not, but there is a current bug where u see ppl wiht transparency if u are in spec

fix it

i cant rn

16:30

ah

16:30

i can fix it from web

16:30

its easy fix

@Ryozuki if you know what the problem is lmk and i'll commit it

oh ok

16:31

https://github.com/ddnet/ddnet/blob/master/src/game/client/components/players.cpp

ddnet/ddnet

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/ddnet

16:31

go to renderplayers and renderhook

16:31

on the if that sets otherteam = true if solo

16:31

set that if its on spec team

16:31

it doesnt do it

you sure thats the thing?

yes

16:33

or just set the if before the spec

16:33

if

16:33

u know what i mean

16:33

hm

16:33

from a quick look

16:33

u can test is easily

why can't they hook though?

im only fixing the ghost in spec

16:33

idk why that happens

16:34

and if its related to my prs

16:35

maybe this fixed it (but i would bet it doesnt) https://github.com/ddnet/ddnet/pull/1653

Use the DDNet Network Character by Ryozuki · Pull Request #1653 ...

Fixed super prediction. Fixed solo being weird when antiping is on. Make the server-side character cores know about their character status.

so set OtherTeam = true if player in spec? seems that's already done though

no

16:35

set to false

16:35

if its in spec

16:35

i think

16:36

if otherteam == true it will render like ghost

16:36

@Learath2 maybe juyst remove the 2 ifs

16:36

than to set otherteam to true if solo (edited)

16:36

and set a || in the if

16:37

that sets the alpha

16:37

https://github.com/ddnet/ddnet/blob/master/src/game/client/components/players.cpp#L254

ddnet/ddnet

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/ddnet

16:37

this way u can see ppl on solo

16:37

as ghost

16:37

on spec

16:37

and non solo ppl normally rendered

Learath2

[ddnet/ddnet] Pull request opened: #1664 Fix solo bug

Fix a bug where the solo state from the save doesn't get loaded properly. I think it's the CharacterCore not being updated, but I'm not sure, nor do I have the setup to test it.

@deen can you take a look at #1664

arent tuninparams needed

16:49

for old clients

The SetSolo already sends tuning

ah

learath on pr streak today

@Ryozuki I couldn't really understand what to fix on the "ghost" thing so I didn't touch it

ye ill do it

I feel I've been remiss in my duties and had a rare completely free day

16:52

having multiple "Solo" variables in the code isn't exactly too nice tbh, there should be one source of truth

yeah

16:52

currently there is one in game core and other in either sv or client

16:53

we should keep the gamecore one

Currently if you aren't too careful you can end up with a different setting in TeamCore, CharacterCore, Character

yeah

16:53

teamcore solo thing and there is also team_super

16:53

its no longer needed with ddnet char

16:53

but backwards compat

16:53

sucks a lot

16:54

its a big mess

16:54

i mean why teamcore handles solo too

16:54

makes no sense

16:55

cancollide on teamcore should return true if they are in the same team then there should be a separate check for solo players

16:55

since no matter the team a solo player can never collide

I think it's an artifact from back when we hacked everything together

its also funny cuz on character.cpp server there is accesses to m_Core through m_Core directly and GameServer().... .. m_Core

gogo next pr learath

ddnet code is most def very spaghetti, I created a graph once and every class has access to everywhere

16:57

no hierarchy at all

@Learath2 interfaces are also a mess

They are a good idea, I like the structure with singletons and kernels

17:01

Oop people might object though

i dont like it

17:01

why u need a interface of a server if its only implemented in CServer

17:02

u dont have other implementations of server

17:02

a projectile interface

17:02

thats good

17:02

but server? idk

I think its an artifact of teeworlds being in C before

ye it registers interfaces with macros and things

17:03

never looked much at it

17:04

server also has MaxClients() method

17:04

while MAX_CLIENTS is used everywhere

17:05

iirc

does MaxClients() return MAX_CLIENTS

yea

lol

so maxclients should be used

17:06

so if u change maxclients u change all easily

I think MaxClients() is the max clients supported on the server

17:06

so it's supposed to be >= 1 and <= MAX_CLIENTS (edited)

warning: 'glewExperimental' redeclared without dllimport attribute after being referenced with dll linkage GLboolean glewExperimental = GL_FALSE;

17:07

compiling with mingw64

Yeah, fix that please

17:07

annoys me all the time when building releases

that looks like its from glew code itself

17:07

idk if thats fixable xd

google it at least and check

17:08

and if it's not fixable then disable that warning for the relevant c file

17:08

in CMakeLists

ye im looking

@Ryozuki it's still happening, while you are in solo ^^

yeah we changed nothing

17:10

did u see a client update? xd

e404d6f Fix platform-specific client libraries for Linux - AMDmi3 37461e3 Merge #1662 - bors[bot]

17:11

[ddnet/ddnet] Issue closed: #1660 Cherry-pick teeworlds/teeworlds#2107

17:11

[ddnet/ddnet] Pull request closed: #1662 Fix platform-specific client libraries for Linux. Fix #1660

rerunning make again compiles succesfully

17:12

thats funny

you need a clean build of course

17:12

the warning only shows up when compiling a single file

17:12

or touch that file

it worked in a dummy server, so i was confused pepeH

bug

maybe we should disable warnings for external libs

17:14

but im no cmake master

json lib also had some I think

Ryozuki

[ddnet/ddnet] Issue opened: #1665 Disable warnings for external source code.

This has to be done with cmake, maybe @heinrich5991 you can do something about it?

Ryozuki

[ddnet/ddnet] Pull request opened: #1666 fix ghosts in spec

[ddnet/ddnet] Pull request closed: #1620 Rewrite of prediction code, with additional prediction (updated)

17:52

[ddnet:master] 8 new commits

0b3f3b0 Rewrite of prediction code, with additional prediction - trml 92ef0b0 Collapse if statements - trml c5c837e Revert dummy input fix (which wasn't a sufficient fix) - trml e88459a Make more variables private - trml 78c8f42 Put public members in a single block - trml 3d8bd17 Add extended data to CCharacter and improve prediction of super/solo/endless/superjump - trml 681f309 Remove the dummy prediction - trml 526af03 Merge #1620 - bors[bot]

[ddnet/ddnet] Issue opened: #1667 Tees are half transparent when I'm in solo, even when spectating

Looks quite annoying. @Ryozuki

18:03

[ddnet/ddnet] Pull request closed: #1666 fix ghosts in spec

18:03

87c797e fix ghosts in spec - Ryozuki 3f99dfd Merge pull request #1666 from Ryozuki/pr_fix_solo_spec - def-

18:03

[ddnet/ddnet] Issue closed: #1667 Tees are half transparent when I'm in solo, even when spectating

18:03

[ddnet/ddnet] Pull request closed: #1664 Fix solo bug

18:04

Use the DDNet Network Character by Ryozuki · Pull Request #1653 ...

5d44619 Fix solo bug - Learath2 dc1e638 Merge pull request #1664 from Learath2/dd_pr_solofix - def-

rls today?

https://github.com/ddnet/ddnet/pull/1653 consider this

Fixed super prediction. Fixed solo being weird when antiping is on. Make the server-side character cores know about their character status.

18:37

oh my

18:37

conflicts

18:37

xd

fu

18:51

this prediction code xd