DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2019-04-06 00:00:00Z and 2019-04-07 00:00:00Z

help

00:45

Image attachment

[ddnet/ddnet] Pull request opened: #1585 Use OpenSSL md5 if it is available

Fixes #1582.

just use cmake ^^

01:04

have you compiled bam with the same compiler you have currently installed?

ye

[ddnet-maps:master] 1 new commit

fe67a7f A Heartcore II - ddnet-maps

[ddnet/ddnet] Issue closed: #1583 Integrate CPack DEB on cmake for easier debian package generation

[ddnet/ddnet] Pull request closed: #1584 Notify about chat mentions in editor

11:46

[ddnet:master] 2 new commits

98bfeb3 Notify about chat mentions in editor - 12pm a0c0ff5 Merge pull request #1584 from 12pm/editor-mentions - def-

[ddnet/ddnet] Pull request opened: #1586 Localize mentions

[ddnet/ddnet] Pull request closed: #1586 Localize mentions

xD

I'd like to update the translation files in two different PRs, can't do that without merge conflicts

13:20

so I just merged the PRs

[quakenet] <Ryozuki> heinrich5991: please explain jao why force pushing shouldn't be used unless you need too, he says he only does what git-god (aka you) does lol

13:25

[quakenet] <Ryozuki> @heinrich5991 heinrich5991 force-pushed the heinrich5991:pr_ddnet_external_md5 branch from 8d073c7 to e3657ab 12 hours ago

13:25

[quakenet] <Ryozuki> y

13:25

[quakenet] <Ryozuki> xd

13:29

[quakenet] <heinrich5991> force pushing on public branches like master is a big no-no :P

13:29

[quakenet] <heinrich5991> but for PRs it's fine most of the time. it can make it hard to track changes, but if that's not a problem, you can do it

[quakenet] <deen> Does github not keep the history of the PR after force-pushing?

13:52

[quakenet] <deen> Seems like quite a deficiency

13:53

[quakenet] <deen> My idea is to ammend and force-push to PR branch when I fixed something, but add a regular commit when I add something more

[quakenet] <heinrich5991> I try to keep every commit building to aid in bisecting

[ddnet/ddnet] Pull request closed: #1572 cl_mouse_min_distance as requested by Makoyuri

14:28

[ddnet:master] 2 new commits

e31561e cl_mouse_min_distance as requested by Makoyuri - def- 2f4dd5a Merge #1572 - bors[bot]

[ddnet:master] 4 new commits

330a996 Add localization for updating output - def- 9df30dc Localize mentions - def- cc1ce86 Update language files - def- ea82402 Merge #1574 - bors[bot]

15:04

[ddnet/ddnet] Pull request closed: #1574 Updater localization and update language files

[quakenet] <heinrich5991> deen: can you walk me through your "handle fs failures" pr?

[ddnet/ddnet] Pull request opened: #1587 Small fixxings

[quakenet] <deen> heinrich5991: anything specific?

15:40

[quakenet] <deen> The idea is to propagate the errors instead of losing them immediately

15:40

[quakenet] <deen> and then in the end set us to failed

[ddnet:master] 3 new commits

e44b1ca Use OpenSSL md5 if it is available - heinrich5991 e3657ab Use SHA256 instead of MD5 in some places - heinrich5991 b25c527 Merge #1585 - bors[bot]

15:54

[ddnet/ddnet] Issue closed: #1582 Use system md5

15:54

[ddnet/ddnet] Pull request closed: #1585 Use OpenSSL md5 if it is available

[quakenet] <Ryozuki> heinrich5991: deen im trying to save 3 more variables, do you happen to know what i have to do here after i add the 3 at end? https://github.com/ddnet/ddnet/blob/master/src/game/server/save.cpp#L185

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/ddnet

16:00

[quakenet] <Ryozuki> what a weird way to save tho xD

[ddnet/ddnet] Pull request opened: #1588 Save telegun on /save

I don't know if the if statements below are correct, please tell me if they aren't as i don't know much what they are about.

[quakenet] <Ryozuki> heinrich5991: where to find gameid?

16:25

[quakenet] <heinrich5991> CGameContext::m_GameUuid

16:25

[quakenet] <heinrich5991> or rather CGameContext::GameUuid()

16:25

[quakenet] <heinrich5991> you can format it to a string with FormatUuid, needs a character array of size UUID_MAXSTRSIZE

16:28

[quakenet] <heinrich5991> (you don't have to load it anywhere, just save it)

16:29

[quakenet] <Ryozuki> so i just put a \t%s at end?

16:29

[quakenet] <Ryozuki> i guess yes

16:29

[quakenet] <heinrich5991> yes

16:31

[quakenet] <heinrich5991> %*s to ignore the string in sscanf

16:31

[quakenet] <Ryozuki> %*s on load right

16:32

[quakenet] <heinrich5991> yes

16:32

[quakenet] <Ryozuki> so in future its easier to add new things

16:32

[quakenet] <heinrich5991> yep

16:34

[quakenet] <heinrich5991> (the * parameter has no effect on the return value, so you still only count the parameters that were read before)

16:38

[quakenet] <Ryozuki> done

16:38

[quakenet] <Ryozuki> whoever merges it should rebase xD

[ddnet/ddnet] Pull request closed: #1588 Save telegun on /save

18:24

[ddnet:master] 6 new commits

b92b2f1 save telegun on /save - Ryozuki beeda4d fix warnings - Ryozuki fb398eb better this way - Ryozuki 69fd7f1 fix and add gameuuid - Ryozuki 52b58c3 final fix - Ryozuki edbd899 Merge pull request #1588 from Ryozuki/pr_save_telegun - def-

18:29

[ddnet/ddnet] Pull request opened: #1589 Remove some code duplication in CSaveTee::LoadString

by using a switch-case with fallthroughs, seems like the perfect use case.

18:32

[ddnet/ddnet] Pull request closed: #1577 Cleanup menus_ingame.cpp

[ddnet/ddnet] Pull request opened: #1590 Update Brazilian Portuguese translation

yo @heinrich5991 i assume .rpoject and .settings is some microsoft stuff?

20:42

its probably folders?

20:43

talking about gitignore. Im thinking about adding a / at the end to indicate that these are folders but im not sure if this is a good idea

[quakenet] <heinrich5991> https://github.com/ddnet/ddnet/commit/122fcef8b66e83bb65ecbb2bc820653340eeda71

Updated gitignore · ddnet/ddnet@122fcef

20:44

[quakenet] <heinrich5991> they were added here, no indication whether they're folders

hmkay

[quakenet] <heinrich5991> it works without the / as well

yes it does

20:44

but i like adding / if its a folder

@ChillerDragon add .idea/

i guess if u add a / it wont hide it if its a file right?

xd

[quakenet] <heinrich5991> note that it doesn't match symlinks to folders anymore if you do that

yes ryo the idea would be with / lonley

what?

i guess i will add .idea instead

why

20:45

i always put / for folders

looks weird

??

if pothers dont have a /

[quakenet] <heinrich5991> doesn't match symlinks to folders if you add a /

Embedded image

[ddnet:master] 6 new commits

238d552 Ignore vscode folder - ChillerDragon abba71e Fix tw code style - ChillerDragon ce5a7ea Remove one of two graphic includes - ChillerDragon 9052047 Cleanup if nesting - ChillerDragon 84409bd Ignore idea folder - ChillerDragon 5d9d0d7 Merge #1587 - bors[bot]

21:19

[ddnet/ddnet] Pull request closed: #1587 Small fixxings

[ddnet:master] 2 new commits

55ae5e2 Update Brazilian Portuguese translation - rffontenelle ad4c13b Merge #1590 - bors[bot]

21:52

[ddnet/ddnet] Pull request closed: #1590 Update Brazilian Portuguese translation

Exported 88 message(s)