Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2019-03-19 00:00:00Z and 2019-03-20 00:00:00Z
Avatar
01ec5ef Front page video: Anim run by BabaMäßig - def-
Avatar
[ddnet/ddnet] New branch created: official-server-symbol
06:47
4f515bf Add symbol for official servers in server browser (fixes #1501) - def-
06:48
Avatar
ed5b08e Also recheck official server status when json gets loaded - def-
Avatar
[ddnet/ddnet] New branch created: authed-spec-color
07:13
6d04e11 Color authed players in spec (fixes #1497) - def-
07:17
0f9b89f Color authed players in spec (fixes #1497) - def-
08:16
4f515bf Add symbol for official servers in server browser (fixes #1501) - def- ed5b08e Also recheck official server status when json gets loaded - def- 2209113 Merge #1505 - bors[bot]
08:38
0f9b89f Color authed players in spec (fixes #1497) - def- 38333b6 Merge #1506 - bors[bot]
Avatar
[ddnet/ddnet] New branch created: chat-command-autocomplete
09:33
da08b7b Autocomplete chat commands (fixes #1504) - def-
09:34
Disadvantage: Always autocompletes DDNet commands, even if you're not on a DDNet server. Advantage: Quick and simple.
09:35
Might also consider fixing https://github.com/ddnet/ddnet/issues/1490 at the same time
Avatar
[quakenet] <Learath2> deen: yep, will try wrapping it up today or tomorrow
Avatar
great, thanks
Avatar
[ddnet/ddnet] New branch created: cmake-build-type-error
09:46
1d343e7 cmake: Fail on unknown CMAKE_BUILD_TYPE (fixes #1334) - def-
Avatar
ChillerDragon 2019-03-19 10:30:39Z
@Im 'corneum for showall and showothers i recommended the alisases /sa and /so to have lesss typign and less typos
Avatar
d00d32c More error checking in system.c (fixes #1317) - def-
10:44
[ddnet/ddnet] New branch created: error-checking
Avatar
74bfedd More error checking in system.c (fixes #1317) - def-
10:57
1b2e41e More error checking in system.c (fixes #1317) - def-
Avatar
How do i create a Thread in ddnet 11.9 (server)
Avatar
thread_init and then just randomly access and overwrite data everywhere without any locking whatsoever
Avatar
ChillerDragon 2019-03-19 11:34:49Z
xd deen troll
Avatar
@timakro https://github.com/ddnet/ddnet/pull/1320 What's up with this btw?
This adds a new network message sent from the server to the client when a client connects. It tells the client that the server is a DDNet server and it is used in addition to the gametype to determ...
Avatar
Can I create a class, which has full access to character.h?
12:22
so like a subclass
Avatar
In object-oriented programming, inheritance is the mechanism of basing an object or class upon another object (prototype-based inheritance) or class (class-based inheritance), retaining similar implementation. Also defined as deriving new classes (sub classes) from existing o...
Avatar
[quakenet] <heinrich5991> you mean full access to the member of CCharacter?
Avatar
You can inherit from CCharacter
12:23
or you can have a friend class
Avatar
heinrich5991: yes
12:23
@Learath2 so with a friend class i can use all members?
Avatar
a friend class has access to all the members of the class it's friends with
Avatar
and how do i create a friend class?
12:25
*of character
Avatar
class CIdkWhyYouWouldNeedOne { friend class CCharacter; };
12:27
oh it's the other way around in C++ i think
Avatar
@deen Would still like to see it merged, if you don't like it close it
Avatar
@fokkonaut yeah you need to declare friendships in CCharacter
12:28
add friend class CIdkWhyYouWouldNeedOne; inside CCharacter
Avatar
alright, thanks :)
Avatar
Why are you adding a friend class?
12:28
It rarely is the correct solution
Avatar
fce4ed6 Remove strerror() usages since they are not threadsafe - def-
Avatar
because i have server-side bots, which need full access to the character and for controlling them they get a dummymode, one dummymode is often multiple hundred lines long, dont want to have all that in a funciton in the character
12:30
so the bot moves, based on the mode
Avatar
that sounds like a decent use
Avatar
Would be nice to have documented somewhere what are the arguments available in CMakeLists.txt for running cmake, in order to avoid requiring to read the CMakeLists.txt's code and other files in cmake/ folder every time one forgets it.
Avatar
how do i call a function inside of the friend class, from inside character.cpp
Avatar
In object-oriented programming, a friend function, that is a "friend" of a given class, is a function that is given the same access as methods to private and protected data. A friend function is declared by the class that is granting access, so friend functions are part of th...
13:05
A friend class in C++ can access the private and protected members of the class in which it is declared as a friend. A significant use of a friend class is for a part of a data structure, represented by a class, to provide access to the main class representing that data struc...
Avatar
help the developers I have a new amd video card and after your updates ddnet freezes even with good ping and fps. when correcting I will write. Thanks for attention.
Avatar
Which version is the last good one and which is the first bad one?
Avatar
amd videcard
Avatar
gfx_opengl3 disabled?
Avatar
as soon as updated today began to freeze
Avatar
Try downloading 11.8 again, is that version fine?
Avatar
Ok, I'll try in advance thanks
Avatar
Rafael Fontenelle 2019-03-19 13:51:28Z
@heinrich5991 I notice pnglite is part of LIBS_CLIENT. If CLIENT=OFF, shouldn't it be OFF as well? Sorry if my logic is incorrect, I'm just reading CMakeLists.txt (edited)
13:52
glew too, for that matter.
Avatar
58d9bd4 Make cl_authed_player_color modifiable - def-
14:41
[ddnet/ddnet] New branch created: modifiable-authed-color
14:42
Old color was rgb = (0.78, 1.0, 0.8) In hsl = (125°, 100%, 89%) Converted to hex hsl: H = 125° / 360° * 255 = 89 = 0x59 S = 100% = 0xFF since the TW HSL color system fobids too dark colors it uses l = 0.5 + 0.5L/255 so L = (0.89 - 0.5) * 2255 = 199 = 0xC7 So in total we get 0x59FFC7 = 5898183 (Someone should just make a web interface where you can punch in all TW color formats and get them interchanged....)
Avatar
f0000e5 Switch to simple check symbol for official server - def-
15:06
[ddnet/ddnet] New branch created: official-server-icon
15:07
[ddnet/ddnet] New branch created: square-and-center
15:07
ed87b33 Square and center icons before rendering them on button - def-
Avatar
[ddnet/ddnet] New branch created: fix-x
15:22
f51c12c Fix alignment of x inside button - def-
Avatar
@deen Heh, that x bothered me aswell
Avatar
It's a bit oversized, so it doesn't fit
15:23
so my fix is hacky
Avatar
The x's in the checkboxes are also off center btw
Avatar
yes, they should be higher, right?
Avatar
[ddnet/ddnet] New branch created: remove-useless-comments
15:24
36fef2c Remove useless comments in menus.cpp - def-
15:24
Not sure if we want to do this kind of cleanup
Avatar
2c640b6 Remove useless comments in menus.cpp - def-
Avatar
but numbers are correctly aligned
15:25
i found that strange
Avatar
I saw some fixes in 0.7 to the ui code, I think they fixed it
15:26
don't really remember what exactly it was though
15:26
Are we rendering a text x in there? if so maybe it's the font rendering changes we have
Avatar
apparently we switch to an icon font for rendering the X
15:26
that probably explains it
15:27
yep
Avatar
[ddnet/ddnet] New branch created: fix-checkbox-x
15:31
4468f61 Fix rendering of checkbox x - def-
Avatar
Still looks like its a little low no?
Avatar
yes, but every text inside a button looks slightly low, so it looks consistent to that now
15:35
like the Refresh and Reset filter in the screenshot
Avatar
Ooh yeah true
Avatar
can someone help me setting up MySQL with ddnet 11.9
Avatar
it is on the readme
16:08
just read it
16:08
xD
Avatar
i dont have any sql experience, so i asked ._.
Avatar
u dont need any
16:09
the instructions are obvius enough
Avatar
i dont see any on the readme
Avatar
"Importing the official DDNet Database"
Avatar
just dont import anything
Avatar
thats not what i want
Avatar
but follow the instructions
Avatar
thats what u want
Avatar
what console is that?
Avatar
u should change some things to apt if u use a debian distro
16:10
"MySQL (or MariaDB) support in the server is not included in the binary releases but it can be built by specifying -DMYSQL=ON, like cmake -DMYSQL=ON ... It requires libmariadbclient-dev, libmysqlcppconn-dev and libboost-dev, which are also bundled for the common platforms."
16:10
did u compile with mysql first
Avatar
Rafael Fontenelle 2019-03-19 16:11:02Z
I don't thing mysql support works on Linux. Maybe someone involved in the development can confirm that.
16:11
mysql does work on linux
16:11
it doesnt work on windows
Avatar
Rafael Fontenelle 2019-03-19 16:11:14Z
Sorry, I meant Windows
Avatar
should work on both
Avatar
it doesnt o nwindows last time i checked
Avatar
but it's not really tested
16:11
I know, I asked you to help fix it today 😄
Avatar
? today?
16:12
when
16:12
xD
Avatar
682f2e5 Add libmysqlclient too - def-
Avatar
After spending a lot of time, I could not build a working version of ddnet for Windows with turned on MYSQL flag. Perhaps it would be worthwhile to check the availability of this feature and add bu...
Avatar
After spending a lot of time, I could not build a working version of ddnet for Windows with turned on MYSQL flag. Perhaps it would be worthwhile to check the availability of this feature and add bu...
16:12
ima try
Avatar
0ac8974 Update ddnet-libs to include libmysqlclient - def-
Avatar
but for me locally the bundled stuff is still annoying
16:13
1. the c++ connector doesn't support mariadb
16:13
2. the c connector depends on an old ssl version
16:13
so meh
Avatar
i am not sure also of the utility of using mysql on windows
16:14
anyone who hostso n windows will probably only use it on home
16:15
thats why i never bother helping people who wants it on windows i know it will be effort wasted
16:15
monkaS
Avatar
Well windows servers are a thing, and some people are just stubborn
Avatar
yteah pay for a worse thing than debian master race
16:16
toptri
16:18
@Learath2 i sometimes bored and read some forums the only argument they have for windows server is "corporate support"
Avatar
The fact that Microsoft runs their own cloud mostly on Linux should be proof enough 😄
Avatar
debian is far of from "master race", it's very very outdated in most cases
Avatar
i use debian testing
16:18
and its stable too
Avatar
And worst of all debian has systemd
16:20
everyone complaining about it
Avatar
(trolling in #off-topic please :D)
Avatar
yet i dont have any problem
16:20
are u one of those "i use arch btw" xd
Avatar
arch is also systemd since forever
16:20
so what does learath use
Avatar
im using win 10 feelsamazingman
Avatar
I'm sure it works fine for granny and help this year be the YEAR OF THE LINUX DESKTOP, but it's an unflexible blackbox monolith
Avatar
ChillerDragon 2019-03-19 16:21:24Z
troll
Avatar
several people are typing monkaS
Avatar
Rafael Fontenelle 2019-03-19 16:22:01Z
Have anyone tested mariadb's C/C++ connector (https://mariadb.com/downloads/#connectors) ? I only knew 'mysql-connector-c++' (edited)
Download MariaDB products with up-to-date documentation from the official source. Includes MariaDB Platform, connectors, dev bundles, and apt/yum.
Avatar
learath when it comes to software its hard to find something he likes no surprise troll
Avatar
I have devuan on my dedicated servers and I use a very stripped down version of ubuntu for cloud servers
Avatar
@Rafael Fontenelle on arch mysql-connector-c++ is patched to work with mariadb, that's what I use, same on Debian I think
Avatar
For devices that are not meant to be servers I use gentoo, with OpenRC
16:24
is runit like systemd
Avatar
Currently my desktop is arch with systemd though, I'm using it for a couple months so I can finally tell people to sod off when they tell me I never tried systemd so I can't have an opinion on it
Avatar
oh u are a masochist!
16:24
twinbop
Avatar
Rafael Fontenelle 2019-03-19 16:24:41Z
@deen oh ok
Avatar
runit is very very minimal, love the idea but it's hard to get right and it's pretty crude imho
Avatar
@Rafael Fontenelle official ddnet servers are all mariadb
Avatar
ChillerDragon 2019-03-19 16:25:22Z
linux sucks
16:25
real people use the poney kernel
16:25
PonyOS: A Hobby Operating System for Everypony
Avatar
04d67c0 Square and center icons before rendering them on button - def-
Avatar
cmake works
16:26
im going to build it now
16:28
@deen \ddnet\ddnet-libs\mysql\include\mysql_connection.h(37): fatal error C1083: No se puede abrir el archivo incluir: 'boost/shared_ptr.hpp': No such file or directory`
16:28
missing boost i guess
16:28
that's annoying
Avatar
windows is annoying :D
Avatar
the mysql-connector-c++ also is
16:29
I was wondering whether we should just use the c connector directly
16:29
and shared_ptr? That's standard c++...
16:30
i guess that headers are rly outdated
16:30
xd
Avatar
depending on boost just for shared_ptr and scoped_ptr, nice one
Avatar
isnt boost modular tho
16:30
but yeah nonsense
16:31
you can try installing it and windows and see if it continues
16:31
i will try but its pain
Avatar
ChillerDragon 2019-03-19 16:33:49Z
boost is only needed for the mysql version?
Avatar
ChillerDragon 2019-03-19 16:33:58Z
hmm
16:34
i tried installing boost on windows once it was a mess xd
16:35
would be nice to have it in the super handy ddnet libs
Avatar
boost is big
16:35
u dont want it if u dont need it
Avatar
ChillerDragon 2019-03-19 16:35:58Z
yea true
Avatar
I was thinking of doing the opposite and just removing mysql stuff from ddnet-libs
Avatar
yeah remove it
16:37
so we can tell them to use linux for mysql
16:38
stallman will thank us
16:38
poggers
16:40
idk if my hardrive or what but takes so much to decompress
16:40
lol
16:45
@deen is it cmake who finds boost or its just the compiler who tries to find boost? if its not handled by cmake i doubt windows will work
16:46
since winodws doesnt have a default path to find stuff
16:46
oh wel
16:46
it does
16:46
aed1684 Document build arguments in README.md - rffontenelle f5c397b Improvements to build arguments documentation - rffontenelle f46fc84 Merge pull request #1512 from rffontenelle/patch-1 - def-
Avatar
In 669018bc9cb I've introduced def->refresh which might be allocated by virStoragePoolDefRefreshParse() but is never freed. Signed-off-by: Michal Privoznik
Avatar
Rafael Fontenelle 2019-03-19 16:49:13Z
😃
Avatar
@deen wiht boost installed (had to configure the visual studio solution to include the boost path) i have this errors, sry for spanish:
16:52
some generated stuff not compiling
16:53
this makes no sense
Avatar
try a clean make
Avatar
same error hm
Avatar
try deleting that file
16:54
or what does it say in line 155
Avatar
it complains there should be a } or ,
16:55
and there is a ,
16:55
xD
16:56
gamecontext.cpp
16:56
too
16:56
so its not a generated thing
16:56
"Target OS: windows 32bit" hmm
16:56
MSVC/14.16.27023
16:57
im 64 bit
16:57
idk why it targets that
16:57
aaaaaaa windows is pain
16:58
i give up xd cant waste on this
Avatar
ok, thanks anyway for trying
Avatar
guys is it possible to see advanced stats (like markers) in the client before hovering the demos? (edited)
17:07
without hover
17:07
with hover
Avatar
Fetch Info button at the bottom
17:07
it takes a while if you have many demos, that's why it's not default
17:07
ctrl-f also works
Avatar
oh. wait a sec
17:09
hm but after deleting one demo I have to press it again. Maybe there can be an option to always have it on. Because when I am looking for possible demos I would like to do "fetch info" and sort by marker
17:10
and just delete all demos without a marker
Avatar
watching and deleting the demo probably takes way more time than pressing ctrl-f
Avatar
what do you mean. Ye i dont want to watch the demo. the marker thing is a great feature to have
17:13
I mean after i press ctrl-f or fetch info. then i want to sort by marker (from ... to 0) and just delete every demo without a marker. either in a whole (not possible i think) or just one by one. but I think after deleting one demo the order of demos change again
Avatar
so i have to fetch info again, delete one. fetch info again. delete one
17:13
and so on
Avatar
22f278f Demo browser: Make Fetch Info a checkbot instead - def-
❤ 1
17:30
[ddnet/ddnet] New branch created: fetch-info
17:30
And persist the result. Helps with the workflow described by Shyzo on Discord:
I mean after i press ctrl-f or fetch info. then i want to sort by marker (from ... to 0) and just delete every demo without a marker. either in a whole (not possible i think) or just one by one. but I think after deleting one demo the order of demos change again so i have to fetch info again, delete one. fetch info again. delete one and so on
Avatar
So many mails from github today 😄
Avatar
Sorry about that, I thought it might be better style than just pushing straight to master
Avatar
Well it is ofc, I always had to move github mail into it's own folder, with a notification rule, just sped up that progress 😛
Avatar
need 4.20 for the memes twintri
18:31
58d9bd4 Make cl_authed_player_color modifiable - def- ed65737 Merge pull request #1511 from ddnet/modifiable-authed-color - def-
Avatar
1eee573 Remove flattr from donations page as no one uses it - def-
18:58
90eb766 Add note about printing t-shirts - def-
Avatar
Rafael Fontenelle 2019-03-19 19:02:03Z
@deen whereever -> wherever
Avatar
found that on my own 😄
Avatar
so long i didnt pr ddnet
19:08
xd
Avatar
@deen do bors again
Avatar
GitHub is where people build software. More than 31 million people use GitHub to discover, fork, and contribute to over 100 million projects.
19:35
@fokkonaut 🤦
Avatar
i didnt change it so how should i know it was 0, because it was after the update to 11.8
Avatar
the good firefox bug that is 18 years old https://bugzilla.mozilla.org/show_bug.cgi?id=70315
NEW (nobody) in Core - Widget: Gtk. Last updated 2019-03-05.
Avatar
yes, wtf
Avatar
so hard to fix? xd
19:39
idk
19:39
there are manual fixes
19:39
but firefox didnt fix it oficially
19:39
best is
19:39
" Status:NEW "
19:40
xD
Avatar
@Rafael Fontenelle I don't quite follow
19:57
you shouldn't need pnglite to build the server (the build script will still look for it though)
20:05
b58285c Make server logo vote disappear - def-
Avatar
i noticed its going uphill lately for ddnet
20:07
many players are comming / comming back (edited)
20:16
0d5db8a Make cl_authed_player_color modifiable - def- 4ab5b26 More error checking in system.c (fixes #1317) - def-
Avatar
@Im 'corneum i wouldn't go that far
Avatar
at least i have seen a lot old pros online in the past
Avatar
@deen would it be sufficient to give a warning when the build type is unknown?
Avatar
[ddnet/ddnet] New branch created: remove-norank
20:55
0535f31 Remove unused norank icon from browse_icons.png - def-
Avatar
(I'm a bit worried about future-compatibility)
Avatar
[quakenet] <deen> ok
Avatar
985c015 cmake: Warn on unknown CMAKE_BUILD_TYPE (fixes #1334) - def-
21:15
d469654 add vote_unmute and display on chat - Ryozuki 43a1990 ConVoteUnMute -> ConVoteUnmute - Ryozuki e00e9f1 add vote_mutes - Ryozuki 6ed3276 fix formatting - Ryozuki dda515b Merge #1519 - bors[bot]
Avatar
@Learath2 client auth level needs to reset on server join or something
21:28
because other servers don't send it
Avatar
[quakenet] <deen> will fix it
Avatar
[ddnet/ddnet] New branch created: reset-authed
21:30
9ea9a43 Reset authed level in client - def-
21:33
As reported by jao on Discord: 22:26 <jao> @Learath2 client auth level needs to reset on server join or something 22:28 <jao> because other servers don't send it
21:38
Avatar
Okay, lets see how well bors performs when we have a lot of prs in queue 😛
Avatar
@Learath2 theoretically, it bundles them
22:16
let's see how that works out
Avatar
@deen maybe you shouldn't be working on ddnet/ddnet branches and get your own fork, you are triggering all the CIs except circle twice
Avatar
1e4890c More error checking in system.c (fixes #1317) - def-
Avatar
DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/ddnet
Avatar
we have so many appveyor builds queued up :/
Avatar
[quakenet] <heinrich5991> you can probably cancel them
22:22
[quakenet] <heinrich5991> in the UI
Avatar
but that might cause them to fail on github, which could fail bors
22:24
at 12 minutes a piece, we have 8 queued so all the merges will be complete in 1 hr 36 mins 😛
22:24
hmm, travis seems to have added windows, maybe we can try theirs to see if it's any faster
Avatar
nah, doesn't fail bors
22:26
have heard these days everyone migrates away from travis
Avatar
@heinrich5991 well appveyor doesn't seem to understand github organizations too well, I don't seem to have any access to ddnet/ddnet
Avatar
I think we run appveyor twice anyway ^^
22:29
I think there was def-/ and heinrich5991/
Avatar
@heinrich5991 btw are you going to finish #1479?
Avatar
@Learath2 dunno what to do
Avatar
@heinrich5991 It already works, you just need to not rename the artifact but instead put it in a folder and store that folder
Avatar
I do that already
22:33
the folder is called artifacts
Avatar
You don't there is no folder called artifacts so you end up renaming the file to artifacts 😛
Avatar
oops
22:35
the mkdir must've gone missing somewhen
Avatar
Also the path turns out a little too deep imho, not really important but maybe copy it to /tmp/artifacts and store that or change the destination
Avatar
[quakenet] <Learath2> jao: hmm, doesn't really look squeezed to me
Avatar
it's fixed in one of deens prs
22:40
didn't see it
Avatar
[quakenet] <Learath2> great, my github notification bell is stuck...
Avatar
@Learath2 why do you think my whitelist shouldn’t be in the server? isn’t it the same result if you do it from the script?
Avatar
[quakenet] <Learath2> more code to maintain, more configuration to be pushed to all servers, if we end up with a big whitelist higher server memory usage, and potential to get out of sync
22:47
[quakenet] <Learath2> but yeah, they are functionally the same, so I guess either achieves the goal
Avatar
isn’t the script local?
Avatar
except the script is in python and hopefully doesn't need as much code for maintaing a simple list
Avatar
[quakenet] <Learath2> Huh I thought we ran the dnsbl server only on ddnet.tw
Avatar
it runs on ger at least
22:54
also, is there a reason why pending is treated like blacklisted for votes check?
22:56
how long does it take to make a dnsbl request
Avatar
because it's ment to counter vote bots that join just to vote
23:05
theoretically it should take very little time
23:08
f51c12c Fix alignment of x inside button - def- 2c640b6 Remove useless comments in menus.cpp - def- 4468f61 Fix rendering of checkbox x - def- 9d623cb Merge #1516 #1517 - bors[bot]
Exported 388 message(s)