Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2018-11-06 00:00:00Z and 2018-11-07 00:00:00Z
At least the
if(State() == NET_CONNSTATE_OFFLINE)
{
if(CtrlMsg == NET_CTRLMSG_CONNECT)
{
...
}
}
blocks seems to be useless. The connection establishment is handled by the CNetServer and CNetConnection::Feed is only called when there already is a connection, so the case offline and connect cannot happen.
This also makes the SecurityToken parameter for CNetConnection::Feed and NET_CONNSTATE_PENDING unnecessary.(edited)