DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2018-10-04 00:00:00Z and 2018-10-05 00:00:00Z

[ddnet-maps:master] 1 new commit

79657f1 A DoomWorld - def-

bug report on newest 11.4.4 version: no visible hookthough meh.

Image attachment

[ddnet:master] 1 new commit

a95032b Apply heinrich5991's fix for #1324 - def-

@Cellegen | HU how come stuff keeps breaking? example map and location?

[ddnet:master] 1 new commit

e8bd845 Fix #1325 - def-

07:25

[ddnet/ddnet] Issue closed: #1325 ___isOSVersionAtLeast undefined on OSX

07:30

[ddnet-scripts:master] 1 new commit

407d2de Use -mmacosx-version-min=10.7 in Mac libs - Dennis Felsing

07:30

[ddnet-libs:master] 1 new commit

a115093 Use -mmacosx-version-min=10.7 in Mac libs - def-

07:31

[ddnet:master] 1 new commit

005feb2 Update ddnet-libs - def-

[ddnet/ddnet] Issue closed: #1324 -lpthread in wrong location on Debian 6

Finally got all builds working again. Please try nightlies with library updates: https://ddnet.tw/news/nightly-builds/

2

[ddnet-libs:master] 1 new commit

9bb674d Strip Windows dlls - Dennis Felsing

08:02

[ddnet:master] 1 new commit

41d1a48 Update ddnet-libs - def-

[ddnet:master] 1 new commit

a21f01e str_copy: Avoid -Wstringop-truncation warning in GCC8 - def-

[ddnet/ddnet] Pull request closed: #1315 Implement brush saving. Fix #1111

08:59

[ddnet:master] 2 new commits

fef22f3 Implement brush saving. Fix #1111 - Learath2 fc7b373 Merge pull request #1315 from Learath2/dd_pr_brushsave - def-

[quakenet] <heinrich5991> deen: do you employ code review at work?

09:40

[quakenet] <heinrich5991> if so, can you tell me how that generally works? I think I have too little of an idea what to actually do there

@deen (sorrry for the ping) Do you have some pointers on how saving automapper data to the .map file should be handled? I would want to make the .map file readable by older clients if possible (so I would prefer to not bump versions up)

@Bojidar Marinov no idea! I'm no good with automapper / map files etc

[quakenet] <deen> heinrich5991: bridge is not working discord -> irc btw

aw, np

[quakenet] <deen> heinrich5991: Yeah, we do have code reviews: https://hookrace.net/blog/hana-cpp-development/

09:55

[quakenet] <deen> So we have some automated tools running to check stuff like clang-tidy/format etc and then 2 people who review the code manually on top

09:57

[quakenet] <deen> You read the change and try to understand what it does. If you can't understand it, ask some questions or suggest comments. Try to find mistakes and unclarities

@Bojidar Marinov you could have an extra layer and encode your stuff there but that seems super hacky

09:58

@heinrich5991 probably knows better ways

I was thinking of adding a new object type, something like LayerAutoMapperParams

And we also added sound without breaking backward-comp, right?

yeah, new object types won't break compat

I haven't tried extending the map format before. I'd probably try to do it like I tried extending the map format

09:59

i.e. in a way that won't clash with any other development on the map format

09:59

let me look into it for a bit

[quakenet] <deen> You can review line-by-line and make sure each line seems reasonable. And you can look at the bigger picture and try to understand what the change is trying to achieve and if that's the best approach for it.

10:05

[quakenet] <heinrich5991> I don't know why the bridge stopped working. I couldn't find anything related on the issue tracker :/

10:06

[quakenet] <deen> Open a new bug I guess? :D (with logs ideally)

10:07

[quakenet] <heinrich5991> let's look into what they want for a bug report

10:11

[quakenet] <heinrich5991> huh. github has a new "new issue" screen

10:11

[quakenet] <heinrich5991> I can select "bug report" or "feature request" after clicking "new issue", presumably, these are issue templates

10:11

[quakenet] <deen> Looks the same to me, maybe you have some beta or a/b testing going on

10:12

[quakenet] <deen> or it has to be enabled per project

10:12

[quakenet] <heinrich5991> per project, probably

10:12

[quakenet] <heinrich5991> try: https://github.com/42wim/matterbridge/issues

42wim/matterbridge

bridge between mattermost, IRC, gitter, xmpp, slack, discord, telegram, rocket.chat,hipchat (via xmpp), steam, twitch, ssh-chat, zulip and matrix with REST API (mattermost not required!) - 42wim/ma...

10:12

[quakenet] <deen> "Get organized with issue templates"

10:12

[quakenet] <deen> in repo settings

@Bojidar Marinov make the Game Tiles auto placer button appear in every Group, not just the Game group. If you use it from another layer and it will use for example Front layer you have to add it to the Game group, not the current group

that's another issue

10:35

and actually, either automatically placing gametiles from another group or multi-group selection is likely going to be my next take

10:39

also, I would like to lessen the hassle of adding more images by putting an "Add"/"More.." button in the image picker popup, so that people don't have to open the images tab to get started

@deen i was curious on my newest version of Demonsphere (which is on the test section) and i wanted to make the design less laggy but as i saw, i didnt see the hookthrough in the beggining while it works normally.

10:47

when i went entities on

10:47

only unhook was possible to see

10:47

instead of hookthrough

10:49

Oh... maybe that caused the problem danAmazing

danAmazing

i switched the places of Game and Front x,ddd

Image attachment

thonkery

2

you just answered your question yourself...

ye ik it was already night when i was found it ;c

10:50

i was wondered it was editor bug or client bug. now we know ._.

PEBKAC

@Bojidar Marinov I'm coding the general solution to your problem right now

(edited)

wow, cool!

(edited)

@Cellegen | HU yeah, that's the problem. But it's a nice trick if you want to hide some stuff inside of the map I guess

HMMM like symbols @Im 'corneum ? troll

troll

[quakenet] <heinrich5991> deen: what's LLT?

11:47

[quakenet] <heinrich5991> like, what's the long version of that name?

@ChillerDragon Oh my... I was able to make the autoautomapper optimization work fine (and hopefully without bugs!) \o/

[quakenet] <deen> heinrich5991: LTT you mean? Our custom C++ standard library

[quakenet] <heinrich5991> deen: but what does LTT stand for? :)

@deen hello i have question about vote list in ddnet types/$SERVERS/maps is public for download ?

https://github.com/ddnet/ddnet-maps/

ddnet/ddnet-maps

All released maps on DDraceNetwork, see also https://ddnet.tw/releases/ and https://maps.ddnet.tw/ - ddnet/ddnet-maps

12:43

e.g. https://github.com/ddnet/ddnet-maps/blob/master/types/ddmax/votes.cfg

ddnet/ddnet-maps

All released maps on DDraceNetwork, see also https://ddnet.tw/releases/ and https://maps.ddnet.tw/ - ddnet/ddnet-maps

i saw votes.cfg

12:43

but in votes.cfg wrote ddnet orginals server top1

12:43

if there is maps file it will be better

12:44

in ddnet-scripts is very old update

[ddnet/ddnet] New branch created: ringbuffer-test

12:48

[ddnet:ringbuffer-test] 1 new commit

43b7950 Try to test ringbuffer (for #1307) - def-

12:49

[ddnet/ddnet] Pull request opened: #1326 WIP: Try to test ringbuffer (for #1307)

I tried to test it and create a similar scenario like in the crash: ``` (gdb) print m_Buffer $18 = {<CRingBufferBase> = {m_pProduce = 0x7f26f6135050, m_pConsume = 0x7f26f6135050, m_pFirst = 0x7f26f6134fd8, m_pLast = 0x7f26f6135050, m_Size = 32760, m_Flags = 0}, m_aBuffer = "\000\000\000\000\000\000\000\000 3 years\001\000\000\000\001\200\000\000\001\000\000\000)\000\000\000\030P\023\366&\177\000\000L\001\000\000\000\000\000\000\355\066\f\223\066\001\000\000\355\066\f\223\066\001\000\0...

[quakenet] <deen> heinrich5991: Library of Templates and Tools ;)

13:25

[quakenet] <heinrich5991> ah :)

to be honest, I don't really understand what you're asking for, @Vexar

@Vexar nope, the votes.cfg is not public, we use it in our internal ddnet repo where passwords and stuff lives

13:27

ehm, votes.cfg is public, but maps file not

13:28

@heinrich5991 he means these files: https://github.com/ddnet/ddnet-scripts/blob/master/servers/types/brutal/maps

ddnet/ddnet-scripts

The magic scripts that make DDNet run. Contribute to ddnet/ddnet-scripts development by creating an account on GitHub.

13:28

@Vexar what's your use case?

i update my ddrace servers maps file manually

you're running our scripts to create the votes.cfg from it?

and i'm now really tired to continue my old method

13:31

yes

13:31

craete-votes.py

13:31

in ddnet-scripts

I see, what is your server called btw?

i not got your mean

13:32

you want know my server name or .. ?

sv_name on your game server

13:32

yeah

ddnet persian

ah, cool, it's still alive

13:32

y

13:32

but with register 0

So if I put the maps file in ddnet-maps repo is that good for you?

y

will do

that really great

13:32

tnx

13:33

and i have a method for fix ddnet-server_sql crashing on windows

13:33

i don't know you tested beforce or no

13:33

ddnet with mysql on will crash on windows

good to know, how to fix it?

but i change a little in codes

can you make a PR on github?

a can try

13:34

i*

[ddnet-maps:master] 1 new commit

2ec4415 Add types/*/maps.txt - def-

[ddnet/ddnet] Pull request opened: #1327 Try closing the file earlier. Fix #1250

Maybe closing the file earlier could work?

[ddnet:master] 2 new commits

189a293 Try closing the file earlier. Fix #1250 - Learath2 7f4c5b2 Merge #1327 - bors[bot]

14:52

[ddnet/ddnet] Pull request closed: #1327 Try closing the file earlier. Fix #1250

is there any way to get the nightly build with a specific sha1? or at least see the sha1 of the current nightly build?

Nope, I build them manually

17:31

@cin want one? Otherwise there are also the CI builds

17:33

Current one is 41d1a4802f1304bf83599f66bc29f6a8615376ed

I just use the circleci artifacts, thanks

this guy is trolling on DDRace. Server : DDNet GER - novice [DDRaceNetwork] .

Image attachment

18:15

if someone can help

18:16

and now he stopped...

@𓆏 Kynilix 𓆏 you can ping @Moderator in #general next time

oh ok

18:23

thx

[ddnet/ddnet] Issue opened: #1328 Merging accounts of people with '/' in the beggining of their names

Some update added, that a prefix like (1) is added before usernames, that are begging with the / (slash) charachter. So a name like mine /\ssa turned to (1)/\sssa. I guess you did it, because commands are begging with the / character and it makes it therefore impossible, to write my name in the chat. I don't think it's an issue, that these names have changed on your servers. But you forgot to merge/move the database entries of all people, whose names begin with /. I am now hav...

19:36

[ddnet/ddnet] Issue closed: #1328 Merging accounts of people with '/' in the beggining of their names

Exported 130 message(s)