DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2018-08-20 00:00:00Z and 2018-08-21 00:00:00Z

the Vanilla servers on ddnet have been patched thanks to eeeee \o/

1

any accessible code @Learath2 to take a look at?

https://github.com/eeeee/ddnet/tree/wip

ddnet - DDraceNetwork, a mod of Teeworlds

3

feelsamazingman

4

hm, sadly still only a few ppl securely connected, but thanks for the update of east's code.

patched zCatch servers aswell

also patched infection

14:53

I'm calling it a day

Foot, tw-plus and fng2 remain to be patched

not securely connected players experience a ping spike of up to 1000 (edited)

@jxsl13 on which server is this happening and which antispoof patch is it running?

mine zcatch

15:28

used the patch of east

well you could try https://github.com/savander/zCatch/pull/4

Antispoof by Learath2 · Pull Request #4 · savander/zCatch

Port the antispoof patch to zcatch

as I just patched it with eeeee's updated version, I have no information regarding the newer patch, which doesn't seem too different from easts, cuz sadly lots of players are not connected securely (edited)

well whatever non standard client they use is their problem

maybe the vital flag part of the second commit is missing.. checking just now

for vanilla clients the token is only sent in the handshake preventing spoofing

wait why are the servers being ipspoofed anyways

cuz someone can

15:36

and does

oh

sadly you cannot really track the ips back to their origin :'c

the ips are forged

15:40

you can trace them back but they'll just get you some innocent machine

15:41

networking is more of a honour system, you trust that everyone puts their own ip as the source, but some asshats don't

15:41

usually networks check for that kind of forgery but again, some asshat networks dont

I meant the packet origin

15:49

not ip origin

15:50

hm, it seems that the vital flag stuff is the same as in your patch.

15:51

does the patch consider this issue? https://github.com/ddnet/ddnet/issues/500

Token handshake a bit brittle · Issue #500 · ddnet/ddnet

Token handshake shouldn't rely on NET_CTRLMSG_ACCEPT, that's not guaranteed to arrive. Probably better to check the first normal message you receive. Vanilla handshake assumes that the clie...

I don't really know the issue tbh

15:52

the players getting 1000 ping shouldn't really happen as the invalid packets should be getting dropped quickly

15:52

maybe your server is struggling?

that's basically the problem, that that packet does not arrive and thus people are not connected securely. (I got a cheap as hell of a server :D)

people can only be connected securely with the ddnet client or another client that implements the extended TKEN handshake

oh, meaning that vanilla is not yet able to handle that Oo?

the vanilla stuff is just for the initial connection, we don't really have a way of making vanilla send a token on all packets

15:54

so the vanilla part is just a challange response to stop them from taking a slot

ah, ok

15:54

now I get why ppl are not connected securely

thx (edited)

@noby where's the client version stored :O?

version.h

version of client sent to the server?

21:42

ehm, nope :/

version.h

21:43

is correct

what folder or is there only one Oo?

only 1

[ddnet/ddnet] Issue opened: #1262 Segfault in FillSelection

As described in https://forum.ddnet.tw/viewtopic.php?t=6608 I created a tele layer, selected a FROM tele, tele number 12 and tried to fill selection using shift and dragging left mouse. ``` Thread 1 "DDNet" received signal SIGSEGV, Segmentation fault. CLayerTele::FillSelection (this=0x555557c78150, Empty=false, pBrush=0x555557c77720, Rect=...) at /media/ddnet/src/game/editor/layer_tiles.cpp:1031 1031 if((!pLt->m_pTeleTile[(ypLt->m_Width + x%pLt->m_Width) % (pLt->m_WidthpLt->...

@Bojidar Marinov ^

where does the server store that information when received from a client Oo?

21:52

hm, engine/server.cpp it seems

Exported 52 message(s)