Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2018-07-24 00:00:00Z and 2018-07-25 00:00:00Z
07:52
1ca7944 add changelog for 11.3 - Ryozuki 25d64f7 fix ampersant - Ryozuki 23b827c Merge pull request #48 from Ryozuki/patch-4 - def-
Avatar
Yeah that was about the margin functions .. Hmargin doesn't create a horizontal margin (between the two rects) but a margin between the horizontal line as Heinrich described. Not really intuitive at the beginning but ok (edited)
Avatar
@heinrich5991 is it possible to create the dummy for multiple servers by somehow changing the address from NetClient[1].Connect in DummyConnect() in engine\client\client.cpp?
Avatar
I honestly don't know what will break then ^^
10:05
try it out 🙂
Avatar
i tried, but cant really figure out how. The parameter needs to be a NETADDR but i dont know what exactly it is
Avatar
a NETADDR is either an IPv4 address or an IPv6 address
10:18
+ a port
Avatar
give me an example please
Avatar
NETADDR Addr; if(net_addr_from_str(&Addr, "127.0.0.1:8303")) { /* error parsing the address */ }
Avatar
m_NetClient[1].Connect(&m_ServerAddress);
10:25
this is the code
10:26
unedited
10:26
m_ServerAddress is a NETADDR
10:29
i cant get it to work (edited)
Avatar
what do you mean?
Avatar
ah wait a sec^^
10:33
hahaaa
10:33
it works
10:33
i mean
10:33
my dummy is on another server
10:33
and i get server messages from it
10:34
but my client doesnt show im on if i switch to the dummy
10:34
i really think someone can make this happen
10:35
i can even chat on the other server without seeing it xD
10:36
and emotes work too
Avatar
about the checkbox thing @heinrich5991
10:44
if (DoButton_CheckBox(&g_Config.m_ClReplaceVanillaSkins, Localize("Kitty skins (DDCat)"), g_Config.m_ClReplaceVanillaSkins, &ReplaceVanillaSkins)) (edited)
10:45
the first parameter is the ID you said
10:45
but how can i make a different one for the coala checkbox?
Avatar
Well the address of the config option should be unique enough, why do you want another one?
Avatar
can we allow zooming out one time on any server? my defualt zoom is 9 because my screen is bigger than others and zoom 10 looks ugly
wtf 1
Avatar
wtf no dont make ddnet a cheat client
pepeH 1
Avatar
@fokkonaut that gives an unfair advantage in some game modes
yes 1
Avatar
true
Avatar
why are some in config_variables.h and some in variables.h?
Avatar
I don't know
13:25
presumably because some are more game-related (in src/game) and some are more engine-related (in src/engine)
Avatar
@fokkonaut there is a lot more to do to make it work
Avatar
@heinrich5991 how do check if the var is empty or not?
Avatar
check whether the first element is 0
Avatar
if(g_Config.m_ClVanillaSkinPrefix[0])
14:07
this is "if the string is nonempty"
Avatar
ok^^
14:12
ok im done
14:15
@heinrich5991 look at github
Avatar
you didn't like the checkboxes anymore?
Avatar
that doesn't really seem discoverable to me anymore
Avatar
what do you mean?
Avatar
ah, you added it to the UI
14:17
mh
14:17
adding a check whether the prefix is already contained in the skin name would allow some deduplication of the skins
14:18
"// index 0 and 7 are bluekitty and limekitty"
Avatar
so i need to check if the input is kitty and i != 0 and 7?
Avatar
no
Avatar
for kitty now
14:18
why
Avatar
you can check whether kitty is contained in the skin name
14:18
whether the prefix is already contained in the skin name
Avatar
that is too hard for me heinrich
14:19
you can merge this and then add that?
Avatar
the function str_find in src/base/system.h does what you need
Avatar
???^^
14:20
i dont know if that would be reliable at all
14:21
whether the algorithm I described would be reliable or whether the function I gave you would be reliable?
Avatar
the algorithm
Avatar
mh. it's a heuristic, definitely
14:22
it works for our use cases, at least
Avatar
hmm
15:26
b8b97eb added skin prefix (#1218) - fokkonaut
Avatar
Fixes #1216 Didn't work on making the panel underneath show only vanilla skins, but it might be doable as well.
Avatar
This displays four buttons below the edit box, one for resetting the skin prefix, and the other three for activating the shipped variants "kitty", "coala", "santa". The "none" string is translatable, the variants names are not because they correspond to file names.
Avatar
Fixes #837 Took a while to guess the right sscanf usage (since it does not detect unmatched input past the last format specifier).
Avatar
d08f03f Changing vanila skins option no longer requires restart - bojidar-bg b8b4f63 Merge #1219 - bors[bot]
Avatar
a635d4a Allow entering automapper rule probability as percentage - bojidar-bg 71c38d8 Merge #1221 - bors[bot]
Exported 95 message(s)