DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2018-06-14 00:00:00Z and 2018-06-15 00:00:00Z

[ddnet/ddnet] New branch created: staging.tmp

[ddnet:master] 2 new commits

a858b7d fix /settings stuff - ZombieToad 51ebc68 Merge #1145 - bors[bot]

haha

08:33

he made it!

@Dev pls dont start with the new team change issue im almost done c:

as you wish @ChillerDragon xD

oh men i run into crashbugs .-.

09:21

yay fuxed

09:22

what time do you suggest for the mute duration? Since its not chat i would suggest a longer time than 1 minute

09:22

like 5 or even 10

[quakenet] <Gabee> The "DDNet masters" only show DDNet servers? Like, the ddnet.tw team?

uhm i guess i have to save ervy ip on join and leave to keep track of the join leave spam

09:40

is that ok?

i already have a system sortof like this that saves every ip thats connected in the last X min and autobans if they reconnect more than Y times

bans -.-

09:41

omg

but that doesnt help because the spam is spec->team 0->spec

i capture that

09:41

spec join works fine

09:42

because i have a player var but rejoin the score gets lost

09:42

i guess ill save all ips

maybe u can find a better way to do it than i did

10:03

i use the same system to rate limit chat, it has a queue of queues where the inner one stores times and the outer one stores strings(ips, messges, etc)

i also use the chat system

10:03

.-.

10:03

it isnt too perfect i guess

no i mean i made the system and used it for limiting duplicate chat messages as well

10:04

players on ddnet servers can spam the same message every 10sec and reconnect every 10sec forever and afaik nothing happens

oh dupilcated messages

10:06

so if i type "no u" on your server multiple times i get life banned?

Image attachment

10:06

lmao

10:06

no it doesnt ban

10:06

it just doesnt send the message

xd

it has a ratelimit_tick function that gets called every x ticks and a ratelimit_add function for when theres a new [ip, chat message]

10:10

i think theres probably a better way to do it but it works

omg it always loads the same score of 800

10:10

idk whats happening here

?

i wish i coulkd code

oh i wouldnt try to reuse the chat limiting system that ddnet already has

.-.

10:11

its good

its good for what it does

10:11

but its not good against duplicates

it just lacks the save funktion

10:12

and im working on that

10:12

duplicates?

10:12

im working on teamchange messages

10:12

has nothing to do with duplicates

10:12

its always same person same with chat

yes the duplicate message is "_ joined the spectators"

i dont havr to check the message

10:15

i just check the ip

then u check for duplicate ips

10:16

instead of messages

i have no idea what ur trying to say

like when an ip changes team u add that ip to the global pool of all ips that have switched teams in the last _ minutes

10:18

and then rate limit based on that

yea kinda

10:19

i use the chat sys

10:19

so they get a score

10:19

incremented

i guess that could work too

ye it could

10:20

but random stuff is happening due to my lack of brain

i thought it would be easier to make a new rate limit thingy than try to figure out how the chat score system works and edit it to work

i already worked with it

10:21

i know exactly how it works

10:21

im having trouble with extending it

why

on saving the score value it always uses a new array entry

10:22

idk why

10:22

and always loads the first

saving it to where

to the array of teamchangemute structs

10:25

https://github.com/ddnet/ddnet/pull/1118/commits/835f56001305f52985ff6da2cf82727cea025826#diff-129e0a8a4db4d018b08816cb64c8363eR359

Add vote_ban rcon command by ChillerDragon · Pull Request #1118 ...

Works the same as muteid. Vote banned players aren't allowed to start or participate in votes.

10:25

such things

lol i also have voteban but it works differently

10:26

mute accepts a third argument

10:26

id time and mode and mode is a bitmask and its stuff like 1=namechangemute 2=votemute 4=chatmute 8=teamchangemute etc

xd

10:27

found the bug

is ther an option in visual studio to stick to teewoods convention?

11:20

it always updates my if(statement) to if (statement)

11:20

adding spaces

[ddnet/ddnet] Pull request opened: #1146 Add team change mutes (fixes #1144)

Im not sure if the tunings are perfect. But the only false positive i could imagine is two lan buddys joining with dummys. The last tee would trigger the team change ban for 10 minutes. But this false positive is okay i think because they will probably play longer than 10 minutes and no message gets lost at all.

[ddnet/ddnet] Issue opened: #1147 Dynamic camera option gets reset on every exit.

if anyone used expressjs and wants to use typescript, i must say https://nestjs.com/ looks very good

Nest - A progressive Node.js web framework

Nest is a framework for building efficient, scalable Node.js web applications. It uses modern JavaScript, is built with TypeScript and combines elements of OOP (Object Oriented Progamming), FP (Functional Programming), and FRP (Functional Reactive Programming).

[ddnet/ddnet] Pull request opened: #1148 remove unused thingy

And added an backdoor feelsamazingman

feelsamazingman

unused thingy = ban command

[ddnet/ddnet] Pull request opened: #1149 hacky fix reserved slots

ddnet 11 wont send password unless the wrong password menu shows

[ddnet/ddnet] Pull request opened: #1150 fix pause messages

they were reversed

[ddnet/ddnet] Pull request opened: #1151 fix veto

before if a player entered the game and stayed before start on a server with a clock over 20 mins he would get veto

Exported 96 message(s)