DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2018-03-20 00:00:00Z and 2018-03-21 00:00:00Z

[ddnet/ddnet] Issue opened: #1089 CMake doesn't detect distribution MySQL libraries on Debian 8.10

mysql_config exists, libmysqlclient-dev and libmysqlcppconn-dev are installed. Reported by @Laxa on Quakenet, #ddnet.

nice there heinrich closing all the prs without discussion

06:15

it looks like heinrich can veto everything he wants xD

[quakenet] <eeeee> well he has to remind the plebs who's in charge

not funny

@Ryozuki I closed a couple of pull requests that hadn't had some discussion in some time, which I was not going to merge and no one apparently did

No

08:40

Dont close them

I thought keeping them open only made the authors think that they might get merged eventually, e.g. by me

You so selfish

which PRs would you like to have re-openend?

All the ones you closed

why do you want to re-open the "show the IPs in more places to moderators"?

I explained it iin the issue

08:43

Brb i come in 1 hour

@Ryozuki https://github.com/ddnet/ddnet/pull/1050

Pointless to hide the ip. Fixes #907 by Learath2 · Pull Request #...

Any rank that can use ban or mute can easily abuse bans and mutes anyways. We can maybe consider this again after a rework of bans/mutes to use/include nicks. But even with that bans and mutes have...

08:43

I don't see a comment

issue

we should modify the bans and mutes command to display which nick was used when the players was banned/muted

Your idea on the modhelp pr is a thing i had in mind, but why if you suggested that, you close the pr? There is no need to do that.

09:20

Ssme with the ban pr

09:20

It is senseless to hide the ip

09:21

You could merge that pr and then when you have done the pr with ur feature change it

09:22

And you know what? I'm in favour of the /mods command

09:23

Did you even talk with the moderators about it?

09:24

You dont even have rcon wheb you are admin to not spend time on that, yet you decide for them?

[ddnet/ddnet] New branch created: staging.tmp

we talked about the mods feature in discord

10:22

why is it senseless to hide the IP?

10:23

@Ryozuki I don't think /modhelp is useful without asking for external help

We talked about it and the only one against was you

10:30

Maybe what @Learath2 said is true, actually the mute system works with "mute indexes" so hiding the IP would make the moderator don't know who is who when using "mutes" to "unmute" someone. And also bans works with IPs not ids. So if a mod bans someone by mistake, without the ip he/she can't unban it.

from here https://github.com/ddnet/ddnet/issues/907

IPs visible for moderators in rcon console · Issue #907 · ddnet/...

Since ip addresses are considered sensitive / confidential information it's reasonable to hide them from non-administrators (moderators in our case). The rcon commands mutes, unmute, bans and ...

10:32

Do you even read what i said? There is no need to close the modhelp pr, just wsit for the external feature

[ddnet:master] 2 new commits

08e2c84 Only count distinct client IP addresses for minimum player vote count - heinrich5991 1e15b97 Merge #1088 - bors[bot]

10:33

[ddnet/ddnet] Pull request closed: #1088 Only count distinct client IP addresses for minimum player vote count

Same with teleportgun, you were against it without even testing it

10:33

And seems like u ignore everything i said on that pr

yes, I think I read what you say

10:35

but if a feature is not helpful, I don't think we should add it

what

1

1

hello xd

hi

im just lookin' at this cvonversation go on xd

In my opinion you dont

10:37

Shit mobile connection...

10:40

And this convo will be hard ignored, i know it

10:43

Everytime something is talked with admins, they wait to see if we forget it

10:43

I alwsys had to remind things frequently to get something done (edited)

merge /mods pr

then people can detect that a mod joined

11:09

"[3:56 PM] Ryozuki: the troll leaves when i join"

that would be nice if mods could remove trolls solely by being present

not if the troll rejoins once the mod leaves

11:13

which apparently happened in that case

wich they could anyway

not if they don't have a reliable way of detecting a mod

11:14

if they just leave whenever someone joins, then that's a troll greatly reduced in impact

just join and see whether you get banned

then you don't annoy the server for a couple of minutes, hopefully you get bored

11:15

or people can advance somewhere where they aren't blocked by you anymore

and the mods names are public anyway and moderating with fake name is not allowed

11:16

so what does it change

I recommended ryozuki to change the name if that happens

11:16

this would no longer be possible with the PR

ye but that’s illegal

"illegal" A GAME jao its a game

1

with rules

more like guidelines...

well if you don’t want that mods act by rules

11:19

let’s see how often you get funbanned

but i dont

whatever, @heinrich5991 let it be learaths or snails decision at least.. they actually have moderator experience..

what do you say about my argument, @jao?

or you stop being to shy to moderate, try it for a month and decide then

no, I won't do that. people will be even more mad at me afterwards

your argument is that you can’t moderate undercover anymore?

my argument is that you can't do anything if the situation I quoted above happens

what is bad about trolls leaving when mods join

it's bad if they rejoin once the mod leaves

11:26

if the mod is only there to take care of the troll

you can ask the mod to come back

yes. and then the troll leaves again

11:27

the mods don't have endless amounts of time, in most situations when someone reports here, it's hard enough to get a mod to come once

well you can still join with fakename, spec the troll or whatever to make sure you don’t ban for no reason, get the players id and then rename/ login and ban them

okay, that would work

11:32

so the positive thing we're after is being able to chat to the mod directly?

ye

@jao how about letting logged-in people be highlighted by the word "moderator" or "mod"?

spammy

yes please do it

moderator is spammy?

11:36

mod maybe…

11:36

mhmh

no i mean people would just spam that xd

but they wouldn't spam the people they get from /mods?

ye not much more than now

mh

11:39

wait. if people know the moderators they can just chat them directly

11:39

without /mods

the /mods is mostly for new or unfamiliar people and to easily find mods on crowded server

I think that could be achieved by hte moderator highlight as well

11:40

the difference between these two might only be discoverability

11:40

but I don't think new players know about console commands that much either

and you get no info about a mod being there and if yes, how many

yes… mh

11:44

so this is the upside of the /mods command

imo the best way would be to color mods differently in scoreboard

that would give status to the mods – people would like to be mods for status even more I'd guess

or just give them a little icon

11:46

nothing super special

doesn't matter how they're different, if you can recognize it at a glance, you make it a status symbol

11:46

speaking of that, could we remove the "admin" tab on the right?

that is like having rcon

except you don't passively show other people that you have rcon

so being admin doesn’t come across as status symbol

11:48

and it’s not like we can’t remove mods if they don’t do a good job

Sometimes its hard to delete mods who do nothing

11:50

e.g onion and aoe

aoe was easy to remove

I would still merge the mods ps, if youen counter a situation where you have to use a fake name cuz trolls leave when u join, they wouldnt see you in /mods unless you login

11:52

So u can find the id in the meantime

11:52

Aoe was removed cuz me reminding it every day

11:52

To learath

11:52

Same with gdin

nah he was removed once we cared and found the time to deal with inactive mods

Nah

11:54

When snail actually wanted to do it

xd

And his gdin advice excuse...

11:54

Pretty ridiculous

nice assumptions

They arent

it's not like an inactive admin hurts anyone

where is your proof xd

Poor argument @heinrich5991

i actually took part in it, but yeah tell me the truth

gdin told me he might want to get mod/admin again for the summer. would ddnet do that? knowing he will be gone after the summer again?

2 years later @Ryozuki still thinks gdin is my best friend and that I solely protected him

1

Yes

Aoe was the funniest

11:57

Reaccepted a inactive mod

because he is black

1

and snail's second best friend

11:58

@heinrich5991 if deleting botted ranks from botters is not doable, whst you tjink about excluding then from the rank lists, e.g not count them on /top5points /teamranks etc

12:30

And ofc ranks page

@Ryozuki botted ranks will be deleted

I would lifeban the name

cool

12:30

we're not the US

Yeah, this is botterland (edited)

Sp someone?

[quakenet] <jxsl13> I'm pro visibility of the ip for mods!

13:37

[quakenet] <heinrich5991> why do you want it? :)

jxsl13 sadly your opinion will be ignored and no one will care, as heinrich is who decides

13:37

he ignored my argument xD

[quakenet] <jxsl13> Damn, did not read, just closed my client

13:37

[quakenet] <jxsl13> What did you say before?

Embedded image

[quakenet] <heinrich5991> [14:37:13] <@heinrich5991> why do you want it? :)

[ddnet/ddnet] Pull request reopened: #1000 Add /modhelp chat command

oh the unexpected happened

[quakenet] <jxsl13> That argument with other commands depending on ips and the ability to distinguish people was key

https://github.com/ddnet/ddnet/issues/907

IPs visible for moderators in rcon console · Issue #907 · ddnet/...

Since ip addresses are considered sensitive / confidential information it's reasonable to hide them from non-administrators (moderators in our case). The rcon commands mutes, unmute, bans and ...

13:39

Maybe what @Learath2 said is true, actually the mute system works with "mute indexes" so hiding the IP would make the moderator don't know who is who when using "mutes" to "unmute" someone. And also bans works with IPs not ids. So if a mod bans someone by mistake, without the ip he/she can't unban it.

13:40

also most games with moderating capabilities show ips too

[quakenet] <heinrich5991> jxsl13: bans and mutes could show nick and timestamp

how would you ban

13:40

and unban

[quakenet] <heinrich5991> ban <clientid>

unban

[quakenet] <heinrich5991> unban <banid>

13:41

[quakenet] <heinrich5991> after bans has been updated to show nick and timestamp

13:41

[quakenet] <heinrich5991> (which was what the linked issue in Learath2's PR was about IIRC)

so when this will be done?

13:41

as for now u cant do that

13:41

same with the people who complains about the unfinishable map due to the bug fixed

[quakenet] <jxsl13> How many players with the same ip can enter your server at the same time?

13:41

[quakenet] <heinrich5991> 4

a lot of people complains you don't care about that

[quakenet] <jxsl13> How do bans work?

13:42

[quakenet] <jxsl13> Ip based

@Ryozuki I will accept a PR that does that, if you want to contribute it

[quakenet] <heinrich5991> yes

"or don't you care about that"?

if you join a server with the map binary when there are players in, you can see that people complains due to the grenade bugfix making that map unfinishable

13:43

they consider this should be a priority fix

we can talk about we can fix this if you want

13:43

*about how we can

[quakenet] <jxsl13> Ok, so mods will see the ips as well as nick and timestamp. (Y)

heinrich wants a id ban system

13:44

he doesnt want to show ips

13:44

in any way

13:45

@heinrich5991 ill do ban thing

cool

13:45

thanks

jxl13 sv_max_clients_per_ip defaults to 4

[quakenet] <jxsl13> If you ban id 4 and at the same time 3 other players due to having the same ip, how do you want to handle that?

mmm

[quakenet] <heinrich5991> they'll all be banned, same as for kickvotes

this happens same now right?

[quakenet] <heinrich5991> yes

13:48

[quakenet] <jxsl13> It's an extreme example, but at least one other player could be expected to be banned.

13:48

[quakenet] <jxsl13> Due to having the same ip

13:48

[quakenet] <heinrich5991> yes

its the problem of not having a auth system

[quakenet] <heinrich5991> haven't seen that except when people are in the same household

13:49

[quakenet] <heinrich5991> no, it's a problem of having a free game, where you can easily join

13:49

[quakenet] <heinrich5991> accounts won't help here

13:49

[quakenet] <jxsl13> Will they get the same ban id?

13:49

[quakenet] <heinrich5991> yes

13:50

[quakenet] <jxsl13> So hashing the ip :D?

13:50

[quakenet] <heinrich5991> I believe unban <id> works today

13:50

[quakenet] <heinrich5991> ?

13:50

[quakenet] <jxsl13> For the id

13:50

[quakenet] <heinrich5991> no, there are ban ids, they're incrementing from 0

s[ip|entry]

[quakenet] <heinrich5991> IIRC

its index

13:51

not player id

13:51

i think

[quakenet] <jxsl13> Ah, ok

mutes work like that too

[quakenet] <heinrich5991> yes

13:51

[quakenet] <jxsl13> Yeah, the unban id is the id on the bans list

so the feature needs to show nick and timestamp?

13:52

since u can already unban index

yes

[quakenet] <jxsl13> hm, the discord webapp is buggy as hell

there is a .deb package, but its still a webapp anyway

[quakenet] <jxsl13> have discord installed, should work :D

hello jxsl13

[quakenet] <jxsl13> hello back jxsl13 xD

feelsamazingman

1

It's like I'm having deja vu

mh?

learath feels weird again

Ryozuki keeps thinking we are all satan's bffs

:)

15:03

Or maybe im the only one who cares enough to complain about things?

Or maybe, just maybe things are not as horrible as you paint it to be

I just try to make the decision-making process more open

seriously one read through your messages and people would think @snail and @gdin were running a money laundering operation and me and @heinrich5991 are trying to change the game so it plays like we want

15:06

well

15:06

actually heinrich doesnt want to change the game it seems

It's a game with max 1000 players that we are trying to keep alive, just relax and enjoy the game

i do

15:07

and i also "try"

15:07

i also enjoy this game everyday so

15:07

i will complain if i feel something is not fair or i dislike

15:07

as im free to do it

You are free to do it but over exaggerating things won't get you anywhere. I'm pretty sure @heinrich5991 would discuss about anything yet you approached him with anger

15:09

As a matter of fact if a PR isn't getting merged I'd rather have it closed, Just take a look at my PR in teeworlds/teeworlds. It's just sad

i don't feel i approached with anger

15:10

ddnet is far from being as inactive as teeworlds

I'd have preferred if oy closed it the second I opened it if he had no intention of merging it. Waste of my time and @cin's time.

what does this mean "if a PR isn't getting merged"?

oh wasted how? did you even do anything with the pr?

15:12

@jao means that the feature is not added

I wrote it?

being added*

15:12

i dont mean that...

15:12

after u wrote it

ye but that's the same as closing it or no

I fixed it?

@jao well its like saying you reject it

I wasn't any good back then, that thing took me hours to get it working

or do you mean, not going to be merged because no one has time to check

u usually state it by closing the pr

I used "If a PR isn't getting merged" as "If we don't feel a PR should be merged"

and we have super mind powers so we know that

15:15

No I hoped you could read the queens english

15:15

It's not like a PR is going to merge itself

1

salt

aren't you working on something to detect the use of bot?

i don't think, since can be avoided due to opensource

feelsbadman

1

@Ryozuki I didn't even know snail defended me about keeping my status or whatever, don't worry about that xD. I agreed to leave for the time being because of obvious inactivity and I was too busy to make any contribution, but when the summer rolls around I'll probably be coming back (edited)

heartw

1

1

3

[quakenet] <jxsl13> :c got a problem regarding sqlite

16:55

[quakenet] <jxsl13> it seems to cause server lags, even tho it's executed in different threads :c

[quakenet] <heinrich5991> it's executed in a different thread?

17:02

[quakenet] <heinrich5991> how?

[quakenet] <jxsl13> back :O

17:17

[quakenet] <jxsl13> basically liek this: https://git.johnbehm.de/jxsl13/zcatch/src/branch/zCatch/src/game/server/teehistorian.cpp#L509

17:17

[quakenet] <jxsl13> like*

17:18

[quakenet] <jxsl13> every transactions is executed in a new thread, every x ticks I execute a middletransaction, which writes all previous transactions to the db and starts a new transaction

17:19

[quakenet] <jxsl13> and every x ticks I cleanup the finished threads from my thread queue

17:20

[quakenet] <jxsl13> this is the cleanup https://git.johnbehm.de/jxsl13/zcatch/src/branch/zCatch/src/game/server/teehistorian.h#L164

17:21

[quakenet] <jxsl13> joinThreads is only executed on shutdown

[quakenet] <Henningstone> jxsl13: will CleanThreads not make the main thread wait for all left threads to finish execution either? You are joining them after all...

17:39

[quakenet] <jxsl13> if I'm not mistaken, the t->joinable() returns true if the thread finished execution?

17:39

[quakenet] <jxsl13> thus joining it directly, because finished executing

17:40

[quakenet] <Henningstone> if I'm not mistaken it does exactly the opposite, return true if the thread is still running (thus joinable)

17:40

[quakenet] <jxsl13> and every other thread is added back to the queue

17:40

[quakenet] <jxsl13> ._.

17:40

[quakenet] <jxsl13> xD let's test that out :D

17:40

[quakenet] <jxsl13> thanks :O

17:40

[quakenet] <Henningstone> http://en.cppreference.com/w/cpp/thread/thread/joinable

17:41

[quakenet] <jxsl13> aw, damn :c

[quakenet] <jxsl13> does anyone, know what this is https://pastebin.com/rtJ605Hp

#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/rai...

[quakenet] <heinrich5991> it seems you catch too many signals with your signal handler

[quakenet] <jxsl13> something causes a crash :c

yes

18:59

there's an exception being thrown

[quakenet] <heinrich5991> have you compiled with debug info?

19:02

[quakenet] <jxsl13> yep

19:03

[quakenet] <jxsl13> some thread seems to throw an exception :c

19:03

[quakenet] <jxsl13> and as someone mentioned to me that if this is done, everything within that thread'S context is deleted

19:03

[quakenet] <jxsl13> thread'S

19:03

[quakenet] <jxsl13> 's

19:03

[quakenet] <jxsl13> ._

[ddnet/ddnet] Pull request opened: #1090 Add `LATIN SMALL LETTER L` confusable

This makes LATIN SMALL LETTER L confusable with LATIN SMALL LETTER I because CYRILLIC SMALL LETTER PALOCHKA "ӏ" (mapping to i) wasn't confusable with LATIN SMALL LETTER L "l" (mapping to l) before. Also add tests for str_utf8_comp_confusable.

@Learath2 @fokkonaut that should fix it ^

[quakenet] <Learath2> heinrich5991: why is that diff huge?

20:16

[quakenet] <heinrich5991> "Update confusable data to Unicode 11.0.0"

20:16

[quakenet] <heinrich5991> because it's a checked in generated file

[ddnet/ddnet] New branch created: staging.tmp

[ddnet:master] 3 new commits

5be3e1c Update confusable data to Unicode 11.0.0 - heinrich5991 6d88a29 Add LATIN SMALL LETTER L confusable - heinrich5991 9da402a Merge #1090 - bors[bot]

20:41

[ddnet/ddnet] Pull request closed: #1090 Add `LATIN SMALL LETTER L` confusable

Does someone have a good project idea for a webapp. Something people could need/has potential thonkery

thonkery

ty

[quakenet] <Learath2> If I had one i'd make it meself :P

make one that's not garbage

21:07

that's my idea

https://www.youtube.com/watch?v=Vhh_GeBPOhs

Steve Ballmer: Developers

1

1

[quakenet] <jxsl13> ._. still laggy ... don't know how to fix

[quakenet] <Learath2> heinrich5991: +v NeXusTw_

21:39

[quakenet] <Learath2> or deen

21:40

[quakenet] <Learath2> or that

21:40

[quakenet] <NeXusTw_> test

21:40

[quakenet] <NeXusTw_> yay

21:40

[quakenet] <heinrich5991> sorry

21:40

[quakenet] <heinrich5991> forgot to remove the +m

21:44

[quakenet] <jxsl13_webchat> does the thread limit apply to detached threads?

[quakenet] <Henningstone> jxsl13 / jxsl13_webchat: detaching a thread basically just means that you don't have to (and can't) join it anymore. This allows you to immediately destroy the thread object (i.e. delete it), but this also means that you have no more way to make sure your thread has done it's job (e.g. write all left sql queries to the disk) before the program exists.

22:34

[quakenet] <Henningstone> about your laggedy's... spawning a thread has got a little overhead as well; not sure if it's enough to cause noticeable lags though.

[quakenet] <jxsl13_webchat> https://git.johnbehm.de/jxsl13/zcatch/src/branch/zCatch/src/game/server/teehistorian.h#L179 :c don't know how to approach this here differently

23:04

[quakenet] <jxsl13_webchat> I think the lagg is caused by the joins

[quakenet] <eeeee> what a mess.. can't wait for c++ coroutines

Exported 340 message(s)