DDraceNetwork - developer

[quakenet] <jxsl13> heinrich5991 ?

01:00

[quakenet] <heinrich5991> yes?

01:01

[quakenet] <jxsl13> I need to get all the uuid stuff that is generated in the compile.py ._.

01:01

[quakenet] <jxsl13> my last linking error is related to that pythin script

01:01

[quakenet] <jxsl13> python*

01:08

[quakenet] <heinrich5991> mhmh

01:08

[quakenet] <heinrich5991> you don't necessarily need the uuid stuff I guess

01:09

[quakenet] <jxsl13> ._.

01:09

[quakenet] <jxsl13> only the stuff from the void RegisterGameUuids(CUuidManager *pManager) function

[quakenet] <heinrich5991> nah, that should be good to remove

[quakenet] <Learath2> heinrich5991: I thought teehistorian did use uuids

yes

01:36

but it doesn't need RegisterGameUuids

[quakenet] <Learath2> oh

01:36

[quakenet] <Learath2> how hard is teehistorian_index to set-up btw?

compile it

01:37

    if ./teehistorian_index -b index data > index.tmp; then
        mv index.tmp index
        wc -l index
        echo ---
    else
        rm index.tmp
    fi

01:38

this is what I have on successful teehistorian download

01:38

it indexes the new files not found in the current index

heinrich5991

[ddnet/ddnet] Pull request opened: #1082 Fix a bug with name bans

Overlong nick names could be used to circumvent name bans.

@Learath2 review soon plz

[quakenet] <Learath2> you just had to split it out to it's own class :P

01:40

[quakenet] <heinrich5991> it's not an own class

01:40

[quakenet] <heinrich5991> it's a single function

01:40

[quakenet] <Learath2> could you check why my tests on the vote abstraction don't work btw? I gave you like 4 highlights about that :/

01:40

[quakenet] <heinrich5991> I guess

01:42

[quakenet] <Learath2> https://github.com/learath2/ddnet/tree/dd_pr_voting give it a look sometime :)

Learath2/ddnet

ddnet - DDraceNetwork, a mod of Teeworlds

01:42

[quakenet] <heinrich5991> will try to

01:48

[quakenet] <Learath2> heinrich5991: your trim right function looks weird

01:49

[quakenet] <heinrich5991> I just moved the StrRtrim function from server.cpp

01:49

[quakenet] <heinrich5991> the tests pass (?) ;)

01:50

[quakenet] <heinrich5991> Learath2: i.e. is it a "it looks weird" or is it a "it might have a bug"?

01:51

[quakenet] <Learath2> I thought it might've had a bug but it seems fine

01:51

[quakenet] <heinrich5991> thanks for checking so thoroughly :)

01:54

[quakenet] <jxsl13> ddnet client crashed on mac :D -> https://pastebin.com/buKsKMFE

Process: DDNet [21206] Path: /Appl...

01:55

[quakenet] <heinrich5991> not now :(

01:55

[quakenet] <jxsl13> save the link :D

01:55

[quakenet] <heinrich5991> on quitting?

01:55

[quakenet] <jxsl13> yep

01:56

[quakenet] <heinrich5991> may I post to github?

01:56

[quakenet] <jxsl13> yeah, why not

01:56

[quakenet] <jxsl13> ls

01:59

[quakenet] <Learath2> heinrich5991: I'd prolly put some weird utf8 characters in the tests just to be sure, but looks fine to me

heinrich5991

[ddnet/ddnet] Issue opened: #1083 DDNet crashing on macOS on quitting

Reported by jxsl13 on IRC. <details> <summary>Stack trace</summary> ``` Process: DDNet [21206] Path: /Applications/DDNet.app/Contents/MacOS/DDNet Identifier: org.DDNetClient.app Version: 11.0.3 Code Type: X86-64 (Native) Parent Process: ??? [1] Responsible: DDNet [21206] User ID: 501 Date/Time: 2018-03-14 02:51:38.399 +0100 OS Version: Mac OS X 10.13.3 (...

[quakenet] <jxsl13> :c removed UUID stuff, compiles, but not working

bors[bot]

[ddnet/ddnet] New branch created: staging.tmp

02:05

heinrich5991

[ddnet/ddnet] Pull request opened: #1084 Add string and nameban tests with Unicode characters

[quakenet] <heinrich5991> jxsl13: I don't have the energy to help you right now

02:06

[quakenet] <heinrich5991> tomorrow?

02:06

[quakenet] <jxsl13> do I have a coice :D?

02:06

[quakenet] <jxsl13> choice*

02:06

[quakenet] <jxsl13> s*

02:07

[quakenet] <heinrich5991> I really can't do it right now, I need sleep :/

02:07

[quakenet] <heinrich5991> good night

02:08

[quakenet] <jxsl13> gn8

bors[bot]

[ddnet:master] 3 new commits

d7f6cf2 Fix some system.c insanity - heinrich5991 1130466 Put name ban stuff into a separate file - heinrich5991 c65ffeb Merge #1082 - bors[bot]

02:10

bors[bot]

[ddnet/ddnet] Pull request closed: #1082 Fix a bug with name bans

QingGo

[ddnet/ddnet] Issue opened: #1085 Maybe we should make dummy more controlable

In China Server I always have to play some ddrace map with my dummy because only few player know this game here, but it is hard to pass some part like hookfly with the function now ddnet client have. For example: !screenshot_2018-03-14_19-57-39 Even if i use bind mouse1 +toggle cl_dummy_hammer 0 1. I can make dummy hook me when i put my left mouse botton, but can't keep dummy at right w...

QingGo

[ddnet/ddnet] Pull request opened: #1086 Provide more controlable command for dummy

I register some new command, which are cl_control_dummy, cl_dummy_jump, cl_dummy_fire and cl_dummy_fire, to make dummy more controlable. if i want to contol my dummy to jump, first, press f1 in game, and use "cl_control_dummy 0", second, use "bind mouse1 +toggle cl_dummy_jump 1 0". finally, i can contol my dummy to jump by pressing left mouse button.

12:26

Jupeyy

[ddnet/ddnet] Issue opened: #1087 mem_alloc / mem_alloc_debug is not thread safe

Used in the graphics backend, used when sound is loaded, and dunno if some workers use it too. 95% of all start / close crashes.

Can i somehow see who were the first finishes on any map on the website?

I can't find it

@Im 'corneum maybe you can download the stats stuff.

i found a nice quote on hacker news:

He fooled Death, staved off it's dance

it beat him yet, Longinus' Lance

now the bet is in our hands

perhaps we'll get another chance:

Wise for ever, still funny now

The party's on the day of Tau

He chose a funny day to die

A perfect day: the day of Pi.

Amazingly, Stephen Hawking died in the day of pi

@heinrich5991 would it be hard to implement it? i remember that deen had posted it on some maps and the dates are also there. would be nice.

[quakenet] <Learath2> shouldn't be too-too difficult, it's just one mysql query to figure it out and it never changes

[quakenet] <jxsl13> heinrich5991 ._., mind helping me figuring out, why the stuf doesnt work xD ?

15:53

[quakenet] <jxsl13> I got it compiling and most of the PRs from ddnet are added .

15:54

[quakenet] <jxsl13> First problem is, that the nor the folder not the log file are created :c

15:55

[quakenet] <jxsl13> neither fodler, nor log files*

do you get any errors?

[quakenet] <jxsl13> none

16:09

[quakenet] <jxsl13> not even the tee historian errors ._.

16:10

[quakenet] <jxsl13> if somewone wants to take a look https://git.johnbehm.de/jxsl13/zcatch

zcatch

bors[bot]

[ddnet/ddnet] New branch created: staging.tmp

[quakenet] <jxsl13> this branch -> https://git.johnbehm.de/jxsl13/zcatch/src/branch/teehistorian

zcatch

you most definitely are missing a part of the pr

16:17

actually no

16:18

jxsl13 well you are never checking g_Config.m_SvTeeHistorian so I guess you actually are missing some parts of the pr

[quakenet] <jxsl13> it is saved in another variable if I'm not mistaken

all the code in gamecontext.cpp depends on m_TeeHistorianActive but you never set it to true anywhere

[quakenet] <jxsl13> lol

16:20

[quakenet] <jxsl13> ._.

https://github.com/ddnet/ddnet/blob/master/src/game/server/gamecontext.cpp#L2559

ddnet/ddnet

ddnet - DDraceNetwork, a mod of Teeworlds

[quakenet] <jxsl13> that's what I thought xD

@heinrich5991's code is usually pretty verbose

If you actually had enabled it and it failed it'd shout at you

[quakenet] <jxsl13> but somehow missing in my code ._. lost it on the way

anyways busy for an hour or so

bors[bot]

[ddnet:master] 2 new commits

aa85c5b Add string and nameban tests with Unicode characters - heinrich5991 5a5b397 Merge #1084 - bors[bot]

16:23

bors[bot]

[ddnet/ddnet] Pull request closed: #1084 Add string and nameban tests with Unicode characters

[quakenet] <jxsl13> sadly still not working :c

[quakenet] <Learath2> jxsl13: why?

17:47

[quakenet] <jxsl13> I don't know why, it enters the specific if-branches (seen on server debug msgs) but does not even create the file

17:48

[quakenet] <jxsl13> also using ddnet's system.c with some functions thath were needed for zcatch, so I kind of wonder why it's not working

17:48

[quakenet] <jxsl13> system.c/system.h

[quakenet] <jxsl13> (ﾉ °益°)ﾉ彡 ┻━┻

18:15

[quakenet] <Learath2> no errors?

18:16

[quakenet] <Learath2> find the io_open and work from there, if the file isn't even getting created the io_open isn't being hit at all

does the teehistorian folder exist in your teeworlds save folder?

18:27

with downloadedmaps, demos, etc.

[quakenet] <jxsl13> it should be created in the folder where the binary is?

18:30

[quakenet] <jxsl13> the is by default no such folder

18:31

[quakenet] <jxsl13> there*

no

18:38

where you downloadedmaps and demos folder is

[quakenet] <jxsl13> ._.

18:42

[quakenet] <jxsl13> ._.

18:42

[quakenet] <jxsl13> xD

18:42

[quakenet] <jxsl13> https://i.imgur.com/SFDtpVG.png

18:44

[quakenet] <jxsl13> where or how do I change this to the default folder, where the binary lies

18:44

[quakenet] <jxsl13> ?

these are some weird names

18:50

it should be called sth like c03081aa-186b-4ca4-9b5d-72e5d51edebb.teehistorian

[quakenet] <jxsl13> do I have uuids?

18:50

[quakenet] <jxsl13> :D

18:50

[quakenet] <jxsl13> no

this is a part that is not hard to add

[quakenet] <jxsl13> I had it yesterday not working, so I deleted the uuids and now using server start timestamps

if everyone had his own id, it wouldn't be possible to steal ranks and you could ban by them maybe?

the problem is when you start creating a subtly incompatible format

18:52

you can change the folder it writes to by using a storage.cfg

[quakenet] <jxsl13> ... you told me yesterday to delete the uuid stuff, cuz I needed to fiddle with the python scripts ._.

yes. not this particular one, the rest are fine

18:53

sorry :/

[quakenet] <jxsl13> which now format do you exactly mean now?

I'll see how to re-add it to the mod

[quakenet] <jxsl13> -now

18:55

[quakenet] <jxsl13> how to extract he raw data?

18:55

[quakenet] <jxsl13> and read it :O?

https://github.com/heinrich5991/libtw2 has a tool that can convert it to json

heinrich5991/libtw2

libtw2 - Some Teeworlds stuff in Rust

[quakenet] <jxsl13> how do I compile the teehistorian rust project?

go to the tools directory and execute cargo build --release teehistorian_dump

18:57

I can also give you the executable if you want

[quakenet] <jxsl13> macosx

18:59

[quakenet] <jxsl13> installing rust:D

https://rustup.rs/

rustup.rs - The Rust toolchain installer

The Rust toolchain installer

[quakenet] <jxsl13> brew :D

19:00

[quakenet] <jxsl13> mega nice

19:01

[quakenet] <jxsl13> heinrich5991 -> https://i.imgur.com/CCpgFVq.png

19:02

[quakenet] <heinrich5991> cargo build --release --bin teehistorian_dump

19:04

[quakenet] <jxsl13> no cargo.toml

19:04

[quakenet] <jxsl13> :c

19:04

[quakenet] <jxsl13> ls

go to the tools directory

[quakenet] <jxsl13> hm :O

[quakenet] <jxsl13> rip magic :c

x

rip magic?

19:25

the executable is in target/release/teehistorian_dump

[quakenet] <jxsl13> diesnt work, magic is wrong, I suppose I need to learn black magic

19:34

[quakenet] <jxsl13> doesn't*

19:35

[quakenet] <jxsl13> manipulating the header and adding a fake uuid didnt help :c

is the current source code in the repo?

[quakenet] <jxsl13> yes, teehistorian branch

19:49

[quakenet] <jxsl13> @heinrich5991

19:49

[quakenet] <heinrich5991> checking it out

[quakenet] <jxsl13> https://files.johnbehm.de/share/99aecd84c5eddb1a42db35e0b30e10a15180c0b35920b329b92ea372f4df37a6

20:27

[quakenet] <jxsl13> test teehistorian file

20:27

[quakenet] <jxsl13> that was created with my version

20:30

[quakenet] <heinrich5991> I'm currently fixing stuff :P

20:30

[quakenet] <jxsl13> nice nice :D

compiling chromium takes so long wtf :/

[quakenet] <heinrich5991> how would that sqlite format look like, jxsl13?

21:41

[quakenet] <jxsl13> much like your json

21:42

[quakenet] <jxsl13> maybe with nick names

21:42

[quakenet] <jxsl13> and only input

21:43

[quakenet] <jxsl13> player_change <- is that player mobement?

21:43

[quakenet] <heinrich5991> yes

21:43

[quakenet] <heinrich5991> basically only in there to check whether the replay is correct

21:43

[quakenet] <jxsl13> ah, ok

21:43

[quakenet] <jxsl13> I think that's too much info x)

21:44

[quakenet] <jxsl13> the tick part is cool and input, i suppose

21:44

[quakenet] <jxsl13> what's the duration of a tick at max?

21:44

[quakenet] <heinrich5991> the duration of a tick is 0.02s

21:45

[quakenet] <heinrich5991> 1/50 s

21:45

[quakenet] <jxsl13> hm k

21:46

[quakenet] <jxsl13> I wonder if an own sqlite table for every player is too much for the db to handle

21:46

[quakenet] <heinrich5991> why not a column for the player? ^^

21:46

[quakenet] <jxsl13> yeah, first thought

21:47

[quakenet] <jxsl13> {"tick":3647,"item":{"type":"drop","cid":0,"reason":""}},

21:47

[quakenet] <jxsl13> 5da229be-4df5-432c-9d9a-3ddb3cfd02ff.teehistorian: Teehistorian(UnexpectedEnd)

21:47

[quakenet] <heinrich5991> server not cleanly shut down?

21:48

[quakenet] <jxsl13> maybe I'm missing stuff in my ctrl-c kill function

21:48

[quakenet] <jxsl13> isnt Server()->OnShutDown() not enough?

21:48

[quakenet] <heinrich5991> aaahhhhhh

21:49

[quakenet] <heinrich5991> don't do that :o

21:49

[quakenet] <jxsl13> hm?

21:49

[quakenet] <heinrich5991> I'll fix the function

21:49

[quakenet] <heinrich5991> don't call Server()->OnShutdown() from a signal handler

21:49

[quakenet] <heinrich5991> in a signal handler you should do little to nothing

21:49

[quakenet] <heinrich5991> e.g. set a variable ShuttingDown

21:49

[quakenet] <jxsl13> :( ok

21:49

[quakenet] <heinrich5991> that the main loop takes as a signal to shut down

21:49

[quakenet] <heinrich5991> may I do that?

21:49

[quakenet] <jxsl13> I have no problem, as long as it work :O

21:52

[quakenet] <jxsl13> I think it would be wise to put the teehistorian initialization stuff in a function like mentioned in one of the comments to have it in one location(the appropriate class)

21:52

[quakenet] <heinrich5991> to which branch shall I push?

21:52

[quakenet] <jxsl13> teehistorian?

21:52

[quakenet] <heinrich5991> ok

21:55

[quakenet] <heinrich5991> jxsl13: pushed

21:56

[quakenet] <jxsl13> nice

21:57

[quakenet] <jxsl13> and something new learned :)

21:57

[quakenet] <heinrich5991> :)

22:03

[quakenet] <jxsl13> hm

[quakenet] <heinrich5991> jxsl13: ? :)

22:44

[quakenet] <heinrich5991> hm?

22:44

[quakenet] <jxsl13> nothing :D