DDraceNetwork - developer

@Learath2 I am

01:32

my patch?

the git revision thing

hm. probably using some py3-only stuff

or did we break py2 long ago?

how did it pass CI though?

merhaba @Learath2 !

@jao what's the benefit of the /mods?

hi @Deleted User

01:34

@heinrich5991 maybe CI has py3?

it's some old ubuntu version

01:34

doubt it has py3 as default

01:35

maybe cmake automatically prefers py3?

players know whether there is a mod on the server and who it is

a logged in mod

01:39

okay. I'm not sure what I would do with that info

01:39

nag the mod?

01:40

@Learath2 python2 scripts/git_revision.py works fine for me

01:41

can you give me the error?

ask them for help (edited)

I overwrote that terminal long ago :/

01:41

something about FileDoesntExist sth

FileNotFoundError

01:42

?

yeah that one maybe

@Learath2 can't you regenerate the error?

I'd need to rebreak my dockerfile

01:49

well I did, give it a min until it builds

01:52

I managed to fill my entire harddisk with docker images

@Learath2 does that translate to "I can't give you the error right now"?

just need to wait couple seconds more

02:07

Traceback (most recent call last):
  File "/ddnet/scripts/git_revision.py", line 5, in <module>
    except (FileNotFoundError, subprocess.CalledProcessError):
NameError: name 'FileNotFoundError' is not defined

02:07

@heinrich5991 ^^

python --version?

02:10

@Learath2 ^

it's not really easy to check

02:10

2.7.9

docker run --rm <container> python --version

the container didn't finish building because of the broken build command i have in there

@Learath2 do you have git installed in the container?

02:15

apparently the except clause is only evaluated if an error occurs

no git in the container

then you'll get incomplete version info :/

02:17

but at least you found a bug like this

heinrich5991

[ddnet/ddnet] Pull request opened: #1059 Python 2 support for `scripts/git_revision.py` on error /o\

@Learath2 ._. ^

@heinrich5991 there seems to be a problem with out of tree builds

out-of-tree builds?

wait i'm not sure what's happening :/

I've not done an in-tree build recently IIRC

mkdir /build && cd build && cmake /ddnet fails with

02:53

fatal: Not a git repository (or any parent up to mount point /build)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
Traceback (most recent call last):
  File "/ddnet/scripts/git_revision.py", line 5, in <module>
    except (FileNotFoundError, subprocess.CalledProcessError):
NameError: name 'FileNotFoundError' is not defined

have you seen my pull request?

I meant the git part on top

it should fix the error

02:54

second commit in the PR

02:54

the error message was not properly hidden

02:58

(git command should be called. if it errors, git revision is unset)

02:58

I'm going to sleep

02:58

good night

I'm going to try finish this one

merge the PR

02:59

it'll help

Learath2

[ddnet/ddnet] Pull request closed: #1059 Python 2 support for `scripts/git_revision.py` on error /o\

02:59

Learath2

[ddnet:master] 1 new commit

3610f0c Python 2 support for scripts/git_revision.py ... - heinrich5991

oups, the wrong kind of merge

now that commit message is unclear

03:00

I'm gonna force-push to master

pls do

heinrich5991

[ddnet] Branch master was force-pushed to 458804c

Compare changes

@heinrich5991 can i get osx sdk somewhere without xcode?

eh

03:01

you mean automatically?

no, for testing

follow the instructions in the readme of the dependent project – you download xcode, but you don't need a mac

guess I'll leave that one to tomorrow

@Learath2 may I go to bed now?

yes you may

good night

night

Learath2

[ddnet/ddnet] Pull request opened: #1060 [INCOMPLETE] Add a dockerfile

docker build -t ddnet . docker run -v ~/ddnet/build:/build -it ddnet ./build-all.sh Currently only works for linux and windows. Will add mac, prepare bundles and close #997.

damn, totally wasted my day on this

1.3tbps ddos https://twitter.com/olesovhcom/status/969328679410110466

Octave Klaba (@olesovhcom)

1.3Tbps DDoS mitigated by our VAC, packet per packet .. (not with an ACL) 10000 source IPs, from 1608 AS

Retweets

102

Likes

153

most sources looks like from chine

06:42

china*

bors[bot]

[ddnet/ddnet] New branch created: staging.tmp

14:41

bors[bot]

[ddnet:staging.tmp] 1 new commit

12e8c7a [ci skip] - bors[bot]

14:41

bors[bot]

[ddnet:staging.tmp] 2 new commits

ad99c58 Add /pausevoted and /specvoted - def- 964c683 [ci skip] -bors-staging-tmp-1058 - bors[bot]

14:41

bors[bot]

[ddnet:staging] 7 new commits

1387ee9 Regenerate version file on git changes - heinrich5991 ad99c58 Add /pausevoted and /specvoted - def- fca8155 Merge pull request #1056 from heinrich5991/pr_d... - def- b285d77 Python 2 support for scripts/git_revision.py ... - heinrich5991 565f963 Properly hide stderr in scripts/git_revision.py - heinrich5991

bors[bot]

[ddnet:master] 2 new commits

ad99c58 Add /pausevoted and /specvoted - def- e64919d Merge #1058 - bors[bot]

14:56

bors[bot]

[ddnet/ddnet] Pull request closed: #1058 Add /pausevoted and /specvoted