DDraceNetwork - developer

uhm does some1 knows how these github reviews work?

11:25

some1 wrote some comments to my code and i responeded but its invisible if im not logged in

11:26

it looks like this while being logged out:

11:26

1

11:26

but for me logged in i see my response:

11:26

pending

11:29

probably

11:29

maybe someone has to accept it, or you have to

11:29

xD

??????

11:49

i just commented a comment

11:49

on my own pr

?! ?!!?! ?! ?

you probably started a review instead of adding single comments https://help.github.com/articles/reviewing-proposed-changes-in-a-pull-request/#submitting-your-review

login, reply below my comments and press 'comment' (edited)

1

@heinrich5991 I just randomly stumbled upon a comment from you: https://stackoverflow.com/questions/426230/what-is-the-ld-preload-trick

What is the LD_PRELOAD trick?

I came across a reference to it recently on proggit and (as of now) it is not explained. I suspect this might be it, but I don't know for sure.

Ryozuki

[ddnet/ddnet] Pull request opened: #977 Active moderator mode

This PR adds a RCON command called "moderate", which enables a active moderator mode for the caller, so this will happen if a vote kick/spec is made:

Vote will last atleast x seconds defined by CGameContext::m_VoteCloseTime (35 seconds on ddnet, according to @heinrich5991) even if there is majority.
If a active moderator votes, it will be a force vote.
If the active moderator doesn't vote, it will pass normally
This is only for kick and spec votes.

I also added `access_level ...

@ChillerDragon you need to click "finish review" or something

14:58

"pending" means that it hasn't been sent yet

heinrich5991

[ddnet/ddnet] Pull request opened: #978 Disable warnings for GTest

Warnings for GTest broke the build because GTest turns warnings into errors, which is undesirable if GTest is just used as a dependency. See also https://github.com/google/googletest/issues/1373.

heinrich5991

[ddnet/ddnet] Pull request opened: #979 Add a missing call to `lock_wait` in test function

This was uncovered when I tried to run other code with ThreadSan, but it only found this. :(

@Learath2 does aio still crash for you?

15:14

can't reproduce ATM

You never could reproduce it

15:19

Will check when im hom

I was able to reproduce it once I think

15:21

in the tests

<Chairn> Hello

16:33

<Chairn> How do you compile ddnet now?

allo

<Chairn> I've seen that bam isn't needed anymore

bam or cmake

<Chairn> was there an update on bam?

16:34

<Chairn> i got this error with bam: configure.lua:109: there is no configuration option named 'opus' bam.exe: script error (-t for more detail)

16:34

<Chairn> configure.lua:109: there is no configuration option named 'opus' backtrace: configure.lua(109): (null) config.lua(20): options_func local configure.lua(115): Load method configure.lua(187): Finalize method bam.lua(35): (null) bam.exe: script error (-t for more detail)

i'm using bam 0.5.0, you?

<Chairn> 0.4.x

16:36

<Chairn> so there was an update

try 0.5

ty @saibotu and @heinrich5991 i managed it to reply a comment^^

<Chairn> hum, still the same error

16:42

<Chairn> configure.lua:109: there is no configuration option named 'opus' backtrace: configure.lua(109): __index metamethod config.lua(20): options_func local configure.lua(115): Load method configure.lua(187): Finalize method bam.lua(35): (null) bam.exe: script error (-t for more detail)

16:42

<Chairn> bam version 0.5.0 using Lua 5.3.3

bam -c config

16:44

(or try deleting config.lua)

16:44

afk