DDraceNetwork - developer

ddnet-maps

[ddnet-maps:master] 1 new commit

8015244 M Adragaline 2, M Downhill Jam, M Ghoul, M Hear... - def-

Learath2

[ddnet/ddnet] Pull request opened: #975 Add feature to disable votes when a mod joins

Requested by @snailx3 on discord.

<nemo2> yeah, it's that kinda attitude that irritates me most about python

17:10

<nemo2> "there's only one right way to do things, and it is guido's way"

the voting code looks horrible

<nemo2> interesting feature request

17:20

<nemo2> I don't think we even block people from kicking me when I have mod powers.

17:20

<nemo2> much less block votes

17:21

<Learath2> you probably don't have half the trolls we have :P

17:21

<Learath2> funvotes pass so quickly mods can't stop them sometimes

17:25

<nemo2> Learath2: we have a few very persistent ones

17:25

<nemo2> Learath2: they got pretty bad. but...

17:25

<nemo2> Learath2: I dunno. I think they got tired of it.

17:25

<nemo2> Learath2: also, we allowed players to flag nicks as "enemies" that would autokick once they joined a room

17:25

<Learath2> I really feel like rewriting the vote counting code, but I can't really test it alone

17:25

<nemo2> only works if you're the room controller tho

17:26

<nemo2> I guess the difference is you guys don't have the "room admin" vs "server admin" since all the rooms are servers

@Learath2 Write a sandbox for unit testing it

17:41

So you can simulate having players on the server voting something specific

17:41

(not sure how realistic in ddnet code though)

<Learath2> I don't think we have the unit testing framework in place for it

i think heinrich added some unit tests

<Learath2> how about I write sth reasonable looking and we test it on the servers? :D

17:42

<nemo2> wow. you guys are organised

nemo2: it's more how I wish it would be, not how it really is, haha

<nemo2> https://hg.hedgewars.org/hedgewars/file/tip/tests/lua these are the only tests we have...

17:42

<Learath2> I'd need an entire working CGameContext instance to test it the way heinrich did it

17:43

<Learath2> nemo2: we are slowly adding tests for the new components tho

17:43

<nemo2> oh.. unc0rr has some server stress tests come to think of it

17:43

<nemo2> but that's it

17:43

<nemo2> nothing that could be considered a unit test

17:43

<nemo2> unless you define the "unit" as "the entire engine"

17:44

<Learath2> I'll just write something reasonable and test it with a couple people

17:44

<nemo2> lol. that's usually our approach too

17:44

<nemo2> Learath2: I checked in something to hash-check lua scripts recently, and thought I had it working, until a german player joined

17:45

<Learath2> :)

17:45

<nemo2> just fortunate he actually joined. or it would have gone into release crashing the german localisation

<nemo2> heinrich5991: welp. I think I'm going to prune my server list

17:55

<nemo2> I'm literally just hanging out on this server due to ddnet

17:55

<nemo2> heinrich5991: see you in irc://irc.freenode.net/hedgewars irc://irc.freenode.net/ddnet

17:55

<nemo2> waves

<Learath2> https://github.com/Learath2/ddnet/commit/aed21dea this isn't too easy :P

Revamp vote counting. Fix veto · Learath2/ddnet@aed21de

<deen_> fack my laif

23:24

<deen_> bb i go toilet