DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2018-01-02 00:00:00Z and 2018-01-03 00:00:00Z

I need assistance, I do not have that much internet lag and don't have fps lag, however, whenever i play every tee is really choppy and laggy except mine, my emotes are also really choppy/laggy and idk why

01:16

help

cl_predict 1

01:16

?

Diddn't do anything

but

01:18

change it to that value i said

01:18

and test

I did

and

01:18

cl_predict_ddrace 1

It made it even worse

cl_predict_ddrace? didn't know that value

but exists

01:21

i have both on 1

01:21

that's why i suggested it

[ddnet/ddnet] Issue opened: #971 Server Security Token Seed exposed by brute force...

Vulnerable function... https://github.com/ddnet/ddnet/blob/32f919eee0eb2ed196852b60232696ca252ee7af/src/engine/shared/network_server.cpp#L144

[5a4ae8cc][NetDump]: Server Security Token (Local Client): 1960989836
[5a4ae8cc][NetDump]: *** Looking for server security token seed... please wait, this may take some time. ***
[5a4aec87][NetDump]: Server Security Token Seed: 109142
[5a4aec87][NetDump]: Server Port (Local Client): 45844

Without any algorithm optimization I get the ...

[ddnet/ddnet] Issue closed: #971 Server Security Token Seed exposed by brute force...

@heinrich5991 ddracepredict https://github.com/ddnet/ddnet/blob/master/src/engine/shared/config_variables.h#L381 https://github.com/ddnet/ddnet/blob/master/src/game/gamecore.cpp#L475 https://github.com/ddnet/ddnet/blob/master/src/game/gamecore.cpp#L548

ddnet - DDraceNetwork, a mod of Teeworlds

ddnet - DDraceNetwork, a mod of Teeworlds

ddnet - DDraceNetwork, a mod of Teeworlds

https://i.imgur.com/Me5a3Jy.png

Embedded image

11:31

im trying to compile ddnet client lul. Clients suck but i wanted to fix some stuff

11:32

i cloned the ddent-libs repo into the ddnet repo but it still seems to fail

11:32

btw im on windows

didn't you have the same problem before? xD

ye i had it some time ago

11:37

i suck at client compiling

11:37

i made it once ago on my main machine but i grilled it .-.

make sure that you have in good places all files

i have cloned ddnet repo

11:38

and ddnet-libs inside it

like that ? git clone --recursive https://github.com/ddnet/ddnet (edited)

eh

11:39

without th recurssive

I would like to try with that --recusrive after all

11:39

hahah

what does it do?

11:39

am in not getting eyrything without it ?

read documentation, it's first link

11:40

command*

mimimimimi

idk, maybe you made somethiing wrong while cloning, that's why i suggest to do it like they said

11:40

in documentation

how can u fail cloning lul

11:41

ok itz me...

11:41

but still.....

just try

i am

it's small effort to try

11:41

xD

#vacation-net-speed

#oh-my-god

looking good

11:42

this recursive rocks

xxD

and u too Sanvander ma boii

11:42

misspleeddleled ur name

11:42

gg

11:43

xd

11:43

u just became Sanvander

11:43

giggle

11:43

ah nuuu

11:43

cccccoooommmppllili terrrmininatter

11:43

https://i.imgur.com/Zjqcb1e.png

Embedded image

11:44

the compiler copied my typos xd

huehuehue, no idea

SDL_Joystick wtf

11:44

is this android stuff?

ya

windows10 != android

I see

11:45

maybe obs thinks it is

11:45

lul

ah it doesnt find SDL.h

11:45

also

curious

SDL is kinda important i guess

yea, like really important

yo San can u trade an SDL.h ?

how much you pay?

uhm

11:46

2$

11:46

in shitcoin

11:46

my own crypto currency

try bam clean

nope .-.

11:47

still no SDL.h

11:47

i guess i dont have it

11:47

lemme search it

11:48

ah i found one in the ddnet libs

11:48

maybe i can change tha path

nonono

11:49

it should works, it had to be in ddnet-libs

11:49

that's why it's called ddnet-libs

11:49

somehow it can find it

i fixed 1 error

11:52

by replacing #include "SDL.h" with #include "super/long/path/to/SDL.h"

11:52

xd lyfe hacks w chiller

:v

11:54

I can't test bam by myself hehehe

11:54

using cmake to do compile

ha, same problem Chiller

12:14

on bam

12:17

fixed

12:17

!!:P

12:17

@ChillerDragon

12:18

https://github.com/ddnet/ddnet/blob/master/other/sdl.lua#L42

ddnet - DDraceNetwork, a mod of Teeworlds

12:18

adjust that line to: settings.cc.includes:Add("ddnet-libs/sdl/include/windows")

12:19

temporary solution, since I don't know how it exactly works. because there's a mac file

[ddnet/ddnet] Issue opened: #972 Bam for windows includes wrong SDL folder

Hey, have no idea how to fix it properly but: https://github.com/ddnet/ddnet/blob/master/other/sdl.lua#L42 Has to be settings.cc.includes:Add("ddnet-libs/sdl/include/windows") on windows. There's also some mac file, maybe we can detect somehow if we are using windows or mac.

it compiled yay

Yay

12:30

savander the dev

[ddnet/ddnet] Pull request opened: #973 Treat checkpoint teleporters the same independent of the number

Previously, checkpoint teleporters with a number of 0 were displayed but not effective.

@Savander wanna make a pull request to fix that line?

don't know how to fix it

15:22

there's a mac file

15:22

don't wnat to break anything

just do the change you wanted to do, that's exactly the right one

[ddnet/ddnet] Pull request closed: #969 [DO NOT MERGE] Abusing CI

@heinrich5991 how to assign fix?

15:29

to issue

what do you mean?

15:31

have you used git before?

[ddnet/ddnet] New branch created: staging.tmp

15:31

[ddnet:staging.tmp] 1 new commit

7f1587d [ci skip] - bors[bot]

15:31

[ddnet:staging.tmp] 2 new commits

8d47638 Add manual locking to ASYNCIO for transacted ... - heinrich5991 05703ca [ci skip] -bors-staging-tmp-957 - bors[bot]

15:31

[ddnet:staging] 2 new commits

8d47638 Add manual locking to ASYNCIO for transacted ... - heinrich5991 c15f52b Merge #957 - bors[bot]

yes but

15:31

i mean

15:31

sometimes i see "fixed #724"

ah

15:31

yes

and it's strikethrough

15:31

how it works xD

you can add "Fixes #972." to the commit description

15:32

then it automatically closes #972 when it is merged

oh, great

close/fix/resolve in all their forms close the issue

[ddnet/ddnet] Pull request opened: #974 Fixes #972.

good, didn't know

15:33

<Learath2> still can't get rid of bam /o\

it's usually good practice to use the first line of the commit message to describe what you changed

15:33

e.g. "Fix bundled SDL includes for bam on Windows"

<Learath2> "Fix SDL include for bam. Closes #972"

:<

<Learath2> I'm not sure what the consensus is on the final punctuation tho :D

the "closes" can also go on a new line

<Learath2> second line should be empty imho

yes

15:35

no punctuation in first line, punctuation afterwards

15:35

first letter is capital

15:35

first line is in imperative form

woah, it's rather difficulty hahaha

"Fix abc", not "Fixed abc"

15:36

<Learath2> You are for only one sentence in first line?

15:36

<Learath2> I almost prefer to have the issue number on the first line

meh

15:36

ok

15:37

don't really think it's necessary

<Learath2> @Savander nah it's not, just describe what you did on the first line and most everyone will be okay with it

it's not really important

It's necessary to make project readable

<Learath2> I feel the more strict you get about these things the more you drive away new contributors

and that's definitely a thing I want to avoid

15:38

see also teeworlds/teeworlds

That's right, it's not necessary in this project

<Learath2> It's not necessary in any project imho, as long as it's not too messy

but imagine a big one, with mishmash inside

see rust-lang/rust, it's okay

15:40

they have ~100 merged PRs a week

<Learath2> if I was running a huge project I'd force First line describes change and has Issue # if it closes an issue for commit messages

<Learath2> and for coding format I'd have them run it through a formatter

+1

<Learath2> It's much less painful to have people run it through a formatter then to shove a format down their throats

if you can get clang-format to work with the ddnet style, please go ahead

15:41

I tried it a bit already

<Learath2> well we could try to make it as close as possible and have one large format commit to fix the rest of the codebase

I think, the worst think is to teach people how the name convenction works

<Learath2> the naming convention we have in teeworlds code is one I love actually, a lot of people seem to hate it

15:44

<Learath2> but m g s_ _p _a conveys a lot of information for me

[ddnet:master] 2 new commits

8d47638 Add manual locking to ASYNCIO for transacted ... - heinrich5991 c15f52b Merge #957 - bors[bot]

15:44

[ddnet/ddnet] Pull request closed: #957 Add manual locking to `ASYNCIO` for transacted writes

15:44

[ddnet/ddnet] New branch created: staging.tmp

15:44

[ddnet:staging.tmp] 1 new commit

15f364b [ci skip] - bors[bot]

15:44

[ddnet:staging.tmp] 2 new commits

33c88c8 Fixes #972. - savander 572f4ff [ci skip] -bors-staging-tmp-974 - bors[bot]

15:44

[ddnet:staging] 3 new commits

802219d Add interface headers to CMakeLists.txt - heinrich5991 33c88c8 Fixes #972. - savander 4659c71 Merge #958 #974 - bors[bot]

I don't understand how people can be so ignorant of the coding style tbh

15:45

(looking at you, eeeee :P)

I think, things like that were good when IDE wasn't that good as now

when I enter new projects, I just look at the code that's there, and format my code accordingly

Since, IDE provides any information you need to understand

15:46

but yea, i like to follow code convections

15:46

i like to have pretty and solid code

IDEs tend to provide m_, might have g_ and s_, but I don't think I have seen IDEs which support p or a

<Learath2> GNU style makes me want to claw my eyes out :P

whatever

15:48

just use the pre-existing style ^^

15:48

it doesn't matter ^^

PSR yeey

<Learath2> in case they use GNU style, I just don't contribute

15:48

<Learath2> heinrich5991: do you know a file that has perfect format in ddnet?

the shortest one? (edited)

teehistorian? :p

<Learath2> preferably the longest known perfect file

I'm the only author

@heinrich5991 build failed ;<

my fault

15:50

see the error

where?

<Learath2> heinrich5991: are we doing tab for indent space for align or just spaces?

15:57

<heinrich5991> we're using tabs for indentation

does it matter?

[ddnet/ddnet] New branch created: staging.tmp

16:00

[ddnet:staging.tmp] 1 new commit

a3d3722 [ci skip] - bors[bot]

16:00

[ddnet:staging.tmp] 2 new commits

802219d Add interface headers to CMakeLists.txt - heinrich5991 cae5909 [ci skip] -bors-staging-tmp-958 - bors[bot]

16:01

[ddnet] Branch staging was force-pushed to 824a568

Compare changes

16:04

[ddnet/ddnet] New branch created: staging.tmp

16:04

[ddnet:staging.tmp] 1 new commit

8ba1c89 [ci skip] - bors[bot]

16:04

[ddnet:staging.tmp] 2 new commits

33c88c8 Fixes #972. - savander 1f266ab [ci skip] -bors-staging-tmp-974 - bors[bot]

16:04

[ddnet] Branch staging was force-pushed to 3017957

Compare changes

is there somekind of stylecl for c?

<Learath2> heinrich5991: we both have "switch (" and "switch(" no space is more common

or it works for everything, I worked only with it for PHP

16:05

choose one!

16:05

tbh with space, more clearer

<Learath2> I'd put a space but teehistorian.cpp doesn't have one

16:05

<Learath2> actually no

16:05

<Learath2> I wouldn't put a space

16:06

<Learath2> will do no space after control

Learath2: most code doesn't have space after if while etc. in tw code

<Learath2> nice

<heinrich5991> Learath2: fixed https://github.com/ddnet/ddnet/pull/958

Add interface headers to CMakeLists.txt by heinrich5991 · Pull Request #958 · ddnet/ddnet

[ddnet:master] 2 new commits

33c88c8 Fixes #972. - savander 3017957 Merge #974 - bors[bot]

16:28

[ddnet/ddnet] Pull request closed: #974 Fixes #972.

16:28

[ddnet/ddnet] New branch created: staging.tmp

16:28

[ddnet:staging.tmp] 1 new commit

1429c82 [ci skip] - bors[bot]

16:28

[ddnet:staging] 2 new commits

b3932c7 Add interface headers to CMakeLists.txt - heinrich5991 ceaa953 Merge #958 - bors[bot]

16:28

[ddnet:staging.tmp] 2 new commits

b3932c7 Add interface headers to CMakeLists.txt - heinrich5991 bdf8e12 [ci skip] -bors-staging-tmp-958 - bors[bot]

16:29

[ddnet/ddnet] Issue closed: #972 Bam for windows includes wrong SDL folder

<Learath2> well clang-format can't do indentation for PP directives

16:55

<Learath2> and if we are running everything through clang-format I'd rather not have braces for one line blocks

goto fail;

<Learath2> heinrich5991: well clang-format is missing indentation for PP so no way to succeed :D

[ddnet:master] 2 new commits

b3932c7 Add interface headers to CMakeLists.txt - heinrich5991 ceaa953 Merge #958 - bors[bot]

17:10

[ddnet/ddnet] Pull request closed: #958 Add interface headers to `CMakeLists.txt`

https://www.youtube.com/watch?v=nJWN0wrPHRo

Build Web Apps With RUST (aka Intro Into Web Framework ‘Rocket’)

18:24

18:24

web development with rust

18:24

huh, maybe i will start learn that lang

@heinrich5991 do you know when sth belongs in game/variables.h and belongs in engine/shared/config_variables.h?

19:07

never wondered

game stuff in variables.h, theoretically

19:07

but lots of variables break that rule

should recategorize them sometime

why we have two files after all?

separation I guess?

We have lack of documentation, no idea differences between both without your help

one is in engine, one is in game

19:34

game stuff should mostly use stuff that is in game, too

19:34

same for engine stuff

Some programmers once asked Guido van Rossum whether 
Python would ever support braces. Since that day, braces have 
been available through a __future__ import:
>>> from __future__ import braces
  File "<stdin>", line 1
SyntaxError: not a chance

23:46

i found this funny xD

lol

23:50

xD

Exported 268 message(s)