Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2017-12-28 00:00:00Z and 2017-12-29 00:00:00Z
Avatar
irclink BOT 2017-12-28 00:08:43Z
<eeeee> strace it to see why it fails exactly?
Avatar
Learath2 2017-12-28 06:04:38Z
eeeee: no strace on windows
Avatar
Savander 2017-12-28 13:08:34Z
gdb ?
Avatar
qshar 2017-12-28 14:46:23Z
I wonder if anyone remembers that funny comment in DDNet source xD
14:46
#if defined(CONF_FAMILY_WINDOWS) char m_aName[16]; // Don't edit this, or all your teeth will fall #else
Avatar
irclink BOT 2017-12-28 16:35:02Z
<nemo2> heh
Avatar
irclink BOT 2017-12-28 20:03:29Z
<nemo2> qshar: was disappointed that ~/hg/ddnet$ grep -r "teeth will fall" * returned nothing so I looked for it... $ hg grep --all "teeth will fall" yielded:
20:03
<nemo2> src/game/server/score/sql_score.h:3311:+: char m_aName[16]; // Don't edit this, or all your teeth will fall http://bugs.mysql.com/bug.php?id=50046
20:03
<nemo2> (and many other revisions)
20:03
<nemo2> that was first one tho
20:04
<nemo2> $ hg log -r 3311
20:04
<nemo2> changeset: 3311:229bc5153183
20:04
<nemo2> user: GreYFoX <GreYFoXGTi@GMaiL.CoM>
20:04
<nemo2> "Program crash after using getString for a string longer than 15 chars"
20:05
<nemo2> looks like it was closed as unreproducible. how odd
20:08
<nemo2> so the problem might still exist?
20:09
<nemo2> does seem to be windows specific tho
Avatar
irclink BOT 2017-12-28 20:19:12Z
<nemo2> hm it was removed in:
20:19
<nemo2> $ hg log -r 6758
20:19
<nemo2> changeset: 6758:22d931ec465e
20:19
<nemo2> user: H-M-H <henry@freedesk.net>
20:19
<nemo2> I sure hope henry knew what he was doing ☺
20:19
<nemo2> since the problem was windows specific and I bet devs don't test much on that
20:19
<nemo2> oh well!
20:20
<nemo2> oh
20:20
<nemo2> src/engine/shared/protocol.h: MAX_NAME_LENGTH=16,
20:20
<nemo2> default of 16
20:20
<nemo2> maybe THAT line should have a "don't edit this" etc
Avatar
irclink BOT 2017-12-28 22:44:45Z
<heinrich5991> if you edit anything in src/engine/shared/protocol.h, the protocol will break anyway ^^
Exported 29 message(s)