DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2017-11-27 00:00:00Z and 2017-11-28 00:00:00Z

[ddnet/ddnet] Pull request opened: #956 Remove unused header file `src/engine/shared/storage.h`

00:06

[ddnet/ddnet] Pull request opened: #957 Add manual locking to `ASYNCIO` for transacted writes

Previously, e. g. it was possible that newlines are separated from the printed line in logger_file.

00:08

[ddnet/ddnet] Pull request opened: #958 Add interface headers to `CMakeLists.txt`

@heinrich5991 slow down

@Learath2 already slowed down

@heinrich5991 does #953 work?

yes, tested it

time for bors

I can't really test it at all on windows as I can't launch any of the opengl builds :/

gfx_opengl3 0? (edited)

nope, instant crash

mh

00:48

that's bad

00:48

even though you changed the config option?

yeah

00:48

I'll try to compile my own see if it reproduces

00:48

if it does can get you a bt

00:49

or could fix it

00:49

but #953 should work™

00:49

but if you want, there are 6 other, less risky, PRs open by me

00:51

@Learath2 how do you compile on windows btw?

normally with mingw but this is a clean install, I only have VS

vs2017?

y

you could try the method in my tutorial

ue4 doesn't work with any other IDE or compiler

00:52

@heinrich5991 your tutorial generates 2 errors

tell me

http://codepad.org/4mBb4wpT

00:54

would probably have worked if I had git in my path but don't have git on this computer yet either

you can install git via vs2017

00:55

and I tell the people to install it in the tutorial

00:55

but I'll patch out that git dependency

well it did clone properly

did you select "Git for Windows" (or similar) in the vs installer though?

doubt it

00:57

I didn't hopefully it doesn't pollute my path with it

00:57

257mb for git

While the entirety of msysgit is 36mb

01:00

@heinrich5991 if git isn't found maybe skip gtest alltogether

01:02

@heinrich5991 heh the crash isn't in opengl at all but in aio_write

01:02

well io_write from aio_thread but same same

good (?)

better then it being an arcane opengl crash

back to the drawing board?

isn't visual studio supposed to be the fruit of millions of dollars of investment from microsoft?

01:05

the icons disappeared

01:11

hmm, this debugger is harder to use then I remember

01:15

@heinrich5991 do you know how to check the fd associated with a (FILE *) here?

<heinrich5991> on windows?

in VS2017 to be exact

no, don't

am I supposed to keep track of them by paper?

have you tried hovering a FILE *?

it's technically not a FILE * in tw code

01:21

we cast it to a IOINTERNAL or sth like that

01:22

is it possible that we are calling io_write before ever calling io_open? wtf

yea... that probably tricks the debugger

01:22

yes, for stdout

if I put enough breakpoints it doesn't crash at all

01:24

my favourite kind of bug

01:24

@heinrich5991 it's a write to stdout that causes the crash

01:24

I might get a couple wires and hook it up to my MCU to get more information about it as that's about as much as I can get from VS

it's maybe related to https://github.com/ddnet/ddnet/issues/914

asyncio test failure · Issue #914 · ddnet/ddnet

f679c3e https://ci.appveyor.com/project/def-/ddnet/build/1.0.457 Running main() from gtest_main.cc [==========] Running 27 tests from 4 test cases. [----------] Global test environment set-up...

we pass buffers as pointers, I don't even know what it tried to write :/

[ddnet/ddnet] Pull request opened: #959 Fail gracefully when trying to automatically download GTest

what would be a simple print (char *)buffer in gdb, the best substitute is inspecting the memory address by hand as far as I can see

01:28

I don't see anything off with the call tbh

try sth like (char*) pArray in the watch window apparently

MAGIC

01:32

hmm, might be printing one too many bytes

01:33

nah not that

01:37

@heinrich5991 wanna give me a hand here?

I can try

if you have time that is

01:37

but I tried to stare that code down already

01:37

it won the the staring contest so far

01:38

I might be blind to the mistake as I wrote the code ^^

feel free to debug on my computer where it consistently happens as long as you don't slow it down too much

you could comment out the code in the static void logger_file(const char *line, void *user) function to see if you can start the client then

01:39

@Learath2 ^

crashes on another io_write

backtrace? does it contain aio?

oh not another io_write

01:42

its a lock_unlock in fetcher

with or w/o my PR?

01:42

^^

w/o your PR

01:42

which takes me to my next question, how do I checkout prs in vs?

good question, don't remember what I did last time

01:43

maybe just add my repository as a remote

01:43

and fetch the appropriate branch

sure, how?

in the panel on the right, go to repository options or so

01:44

you can add a remote there

do you know how to fetch?

01:46

I mean hmm

01:46

oh a restart fixed it nvm

01:49

@heinrich5991 well your job overhaul fixes that bug

01:49

so the crash is only with logger_file

yay \o/

well not yay

01:50

I don't have any idea where to even start looking at that thing

well, I find likely that it is somewhere between aio_write and aio_thread

01:51

but since I haven't found the bug so far, maybe I'm looking at the wrong place

yet it crashes all the way in ntdll.dll

01:51

so it manages to get past every sanity check between there and our code

01:52

the input is fine and the size looks to be correct btw

mh

oh wait

01:53

actually not

01:54

with 1 line break per line it's 1009 characters (edited)

01:54

but we have \r\n in windoze

01:54

our passed size is only 906

01:54

hmm, but a lower size shouldn't be a problem

01:55

also it's normal given you are using a "circular" buffer

01:55

actually I dont ever see how you could read past in this case :/

01:56

you know what would be great? valgrind or asan

currently trying thread sanitizer from clang

mingw doesn't provide --fsanitize=address for windows

01:59

how do people even develop anything on windows?

the same question will be asked by people switching to windows

02:01

you probably have to forget a bit of your linux knowledge and find out how to do what you want natively

you meant s/windows/linux/ in your previous statement

02:02

and switching to linux was pure bliss in that regard. I'd switch just for valgrind tbh

I remember me switching to linux. it was definitely not a bliss for me, everything worked differently and I didn't manage to do almost anything

oh everything except development, surely was painful

I'll go to bed soon

great, so this one will be unsolved for a decade or so

02:08

guess I'll just comment out the file_logger while building my own

what is this language

@Deleted User which language?

its def not english my friends

02:11

you guys are from a different planet

I think the technical term is "technical language"

02:14

what's the special reason behind your numbers @heinrich5991

guess

a girl?

nah

a boy?

nah

learath?

02:15

Oh, 5991 = 1995

02:16

I was eleven years old, okay? ^^

we all were

how old are you?

I think I'm done, the only tool that looks halfway viable for windows is Dr Memory. It looks like it's from 1981, the latest update on the documentation is for VS2015 and the code slows the client down so much that it works, I also highly doubt threads were invented back when this monstrosity was written, so even if it crashed I doubt I'd get any result

not under 13 (def your type)

02:17

Kappa

02:17

I'm 18

mh

02:18

and where're you from? germany, as most people in here?

nope, Albania

02:18

shit country

ah right, I think you told me that before

BUT I'm moving to germany

huh, why?

yes we had something special going on

02:19

my parents live there

02:19

and work

ah

02:19

if you're 18, are you looking to study somewhere?

well

02:19

I still haven't finished the last grade

02:19

I'm studying economy rn

oh

class or grade idk how you say that

still in school and already studying?

12th class

02:20

I mean

02:21

the thing teachers teach us in this class is mostly about economy and business administration

ah

if you get what I mean

so you're gonna be my boss somewhen

I don't know how to explain it properly

02:21

tbh

02:21

I don't like it lmao

02:21

it is too stressful

02:22

I want to find something that I can actually enjoy n shit

02:22

but nowadays that seems impossible

hmm

02:23

I totally don't know you, so I can't really help here

its just like trying to follow the girl of your dreams but your ex drags you behind

02:23

from behind

– do you have something you really enjoy, some kind of hobby or so? (edited)

I actually do

ok, drop the "really"

02:24

something you enjoy should be enough ^^

02:24

what is it?

well

02:24

sex?

02:24

jk, tbh the only hobby that makes me happy

02:24

is the gym

02:25

and its not even a hobby

02:25

its a part of my life

that's definitely not my area of expertise

02:26

I do enjoy climbing – but I'd have no idea what kind of jobs fit to your description

we're way too different, it won't work :c

02:26

climbing?

02:26

that seems exciting

we should probably change the website with our updated compatibility

hi @Learath2

hi worstwish

I missed you

Windows 32bit (mostly)\n Windows 64bit (mostly) should work fine

^^

02:27

I'll try to get the fix for the issues

02:27

but now I have to sleep :/

02:27

I'm actually still a bit ill and uni starts tomorrow again

02:28

g'night

sleep well

02:28

and hope you get better buddy

thanks

night

OGL

2.94 KB

02:58

io_write

3.36 KB

02:59

App Verifier is quite nice and works at a decent enough speed, but the output I get from it is not much more useful then the call stack itself

03:01

https://hastebin.com/axacitutag.m and these are the leaks I could find with dr memory, all also present in linux

after i compile the unchanged source of ddnet i get a problem ingame

10:54

if i run into a wall, the tee sinks like 1.0f down into the ground

10:55

that doesnt happen on the compiled exe from the website though

feelsbadman

@ZimE Compiler, version, OS, CPU arch? Try some weird compiler flags to change float behaviour

deen:, whats going on on ger ?

13:57

With lags? DDoS? Firewall configuration?

Looks like DoS

14:55

At least I see 600 Mbit/s incoming traffic

14:56

probably my fault, I asked admins to disable the FW rules they had

14:56

because I suspected them to cause lags in last days

DoS since yesterday

@HMH ok, reenable again I guess. Sounds like it's even worse without the protection

<eeeee> `win 9

21:14

<heinrich5991> `win 9.5?

21:14

<heinrich5991> `win 95?

<eeeee> /win 9

21:26

<heinrich5991> ahh

21:26

<fstd_> /dos 6.22

21:26

<fstd_> for workgroups

21:26

<fstd_> wait, no

21:27

<eeeee> i gave up figuring out which one of kbd->macos->iterm->mosh->tmux->irssi eats my alt

21:28

<eeeee> /dos 6.22 is for foreveralone, not for workgroups

21:32

<heinrich5991> /linux 3.11 for workgroups!

what a mystery over here?

<eeeee> http://esyr.org/dump/Lin3.11.logo.png

21:36

<heinrich5991> ^^

huh

[ddnet:staging.tmp] 1 new commit

ad8fca7 [ci skip] - bors[bot]

22:41

[ddnet/ddnet] New branch created: staging.tmp

22:41

[ddnet:staging.tmp] 2 new commits

fd36b8c Remove unused header file

src/engine/shared/st... - heinrich5991
[

b6743a9`](https://github.com/ddnet/ddnet/commit/b6743a99ca1324edf8352d914c1b736490207f29) [ci skip] -bors-staging-tmp-956 - bors[bot]

22:41

[ddnet:staging] 2 new commits

fd36b8c Remove unused header file

src/engine/shared/st... - heinrich5991
[

525f671`](https://github.com/ddnet/ddnet/commit/525f6715cf6df5c122da95de2a0f2ca46c520613) Merge #956 - bors[bot]

boris sapmmer

<eeeee> in soviet russia pullreq accept YOU

[ddnet:master] 2 new commits

fd36b8c Remove unused header file

src/engine/shared/st... - heinrich5991
[

525f671`](https://github.com/ddnet/ddnet/commit/525f6715cf6df5c122da95de2a0f2ca46c520613) Merge #956 - bors[bot]

23:34

[ddnet:staging.tmp] 1 new commit

4512ca3 [ci skip] - bors[bot]

23:34

[ddnet/ddnet] New branch created: staging.tmp

23:34

[ddnet/ddnet] Pull request closed: #956 Remove unused header file `src/engine/shared/storage.h`

23:34

[ddnet:staging] 6 new commits

94acac9 Overhauled job system - heinrich5991 a3cdfac Fix lookup job being zeroed in

CMasterServer::... - heinrich5991
[

01d81fc](https://github.com/ddnet/ddnet/commit/01d81fc4ccfd8438a30804af26be17a0d4ca114b) Make m_Shutdown variable atomic instead of v... - heinrich5991 3f43624 Add a couple of tests for CJobPool - heinrich5991 23734de Call net_init in tests - heinrich5991

Exported 260 message(s)