Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2017-09-04 00:00:00Z and 2017-09-05 00:00:00Z
Acme is a text editor and graphical shell from the Plan 9 from Bell Labs operating system, designed and implemented by Rob Pike. It can use the Sam command language. The design of the interface was influenced by Oberon. It is different from other...
Let's Encrypt is a certificate authority that launched on April 12, 2016 that provides free X.509 certificates for Transport Layer Security (TLS) encryption via an automated process designed to eliminate the current complex process of manual crea...
12:36
<heinrich5991> here's a reference to ACME
12:37
<heinrich5991> ah
12:37
<heinrich5991> it actually exists on the page, but I couldn't find it, despite me knowing it
The Automatic Certificate Management Environment (ACME) protocol is a communications protocol for automating interactions between certificate authorities and their users' web servers, allowing the automated deployment of public key infrastructure...
12:41
<heinrich5991> deen: I think you should use POST instead of GET parameters
12:41
<heinrich5991> GET parameters show up in server logs
<heinrich5991> well, you now have a log of each ddnet player's IP address and nick name in your webserver log
12:43
<deen> I have the same already
12:44
<deen> from DDNet-Server
12:44
<heinrich5991> when they join the server
12:44
<deen> Yeah
12:44
<deen> So we should only log the name if there is a problem?
12:45
<heinrich5991> would you expect that your nick name lands on some server when you click a tab in a server browser
12:45
<deen> I find it useful to see if some name is especially slow for example
12:45
<heinrich5991> that would be better, I guess
12:45
<Learath2> could implement CFetcher on CJob but i'm scared it'll break that one remote ass possiblity that i didn't think about
12:45
<Learath2> no idea why i didn't make it a cjob at the beginning tho
12:45
<deen> heinrich5991: when that tab shows you your finished maps, yes
12:46
<heinrich5991> I don't know, I dislike it
12:47
<deen> The request or logging it?
12:47
<heinrich5991> first it was just logging it, but after thinking again, the request
12:48
<Learath2> class CFetchJob { CJob m_Job; allthestufffromCFetchTask; }; pass CFetchjob as userdata to the job. use CFetchjob as we used CFetchtask in the past
12:48
<deen> So we can add a setting "Use username to request finished maps and sort servers"
12:48
<Learath2> sounds sane ^^?
12:48
<deen> and if it's turned off, then the info is requested without name
12:49
<Learath2> how can you request that data without a name?
12:49
<heinrich5991> there's other stuff in there
12:49
<heinrich5991> more than just your records
12:49
<deen> yeah, still request it
12:49
<heinrich5991> it apparently replaces the versionsrv
12:50
<deen> but you just get empty records back
12:50
<Learath2> also replaces the servers json we had?
12:50
<deen> yes
12:51
<deen> and the news from versionsrv as well
12:51
<Learath2> well we could have a setting for "Show finished maps"
12:51
<Learath2> if it's not checked we don't need to request by name afterall
12:52
<deen> exactly what I just proposed
12:52
<Learath2> heinrich5991: ^^ reasonable?
12:52
<heinrich5991> if I added a box with information about this to the ddnet tab, would you consider making this opt-in?
12:52
<heinrich5991> so people will see the feature and won't request it unknowingly?
12:52
<deen> Well, people won't find that info
12:53
<heinrich5991> to the ddnet tab, near the place where the records would be showed otherwise
12:53
<Learath2> don't really have enough space in the serverbrowser to write an essay either, you'd only fit "Show finished maps"
12:53
<deen> even if you make it opt-out, they would click it by accident
12:53
<heinrich5991> see: vlc asks on first launch whether it can access metadata from a remote server for stuff you're currently playing
12:53
<heinrich5991> firefox also asks on first launch whether it can transmit data
<deen> Ideally make it opt-in, but ask people at the first start
12:55
<Learath2> make it opt-in noone uses it, make it opt-out it's a privacy concern (a minor one imho)
12:55
<heinrich5991> Learath2: not if we don't hide it in the options somewhere
12:56
<Learath2> well i don't see anywhere to put it in the serverbrowser window so it needs to be a on startup thing like the nickname setting etc
12:56
<heinrich5991> yes, that would be bad
12:56
<heinrich5991> first launch questions are annoying
12:56
<heinrich5991> those that you can't skip
12:56
<Learath2> so POPUP_FIRST_LAUNCH or idk where to put :/
12:58
<deen> at least you can add it in the dialog at the start where you enter your name
12:58
<deen> it fits well there
12:59
<heinrich5991> true, it can be put into the same dialog
13:00
<Learath2> deen: do you want me to make CFetchTask->CFetchJob
13:00
<deen> but make an even bigger warning that their ip is broadcasted to every server when they open internet server browser
13:00
<deen> Learath2: only if it will have 0 bugs
13:00
<deen> becuase people still get ddosed from that
13:00
<heinrich5991> and if they deny that, don't show the server browser ^^
13:00
<heinrich5991> but actually, we could do that
13:01
<heinrich5991> fetch the servers ourselves and put them into your info.json
1
13:01
<Learath2> deen: you can't promise that, i can't promise that, i'm pretty sure even god would think twice before promising that
13:02
<Learath2> deen: eeeee has the teewebs serverlist available as json, could switch to using that instead of masters, calculating ping is not an exact science in that case but we'd get to upgrade to http masters :P
13:03
<heinrich5991> nah, we still need all servers
13:03
<Learath2> heinrich5991: i think eeeee has all the servers
13:03
<heinrich5991> what use would that be?
13:03
<heinrich5991> they don't support websockets
13:03
<heinrich5991> or webrtc
13:03
<heinrich5991> or whatever the current flavor of the day is
13:03
<Learath2> ask him wtf
13:04
<heinrich5991> or he proxies it
13:04
<Learath2> only supports connecting to ddnet servers but iirc he does keep a json list of all servers
13:06
<Learath2> deen: serverinfo amplification is still possible?
<eeeee> ok yeah i did notice that high resolution is laggy on my broadwell macbook, maybe i'll dig into that
18:57
<eeeee> will fix the text loading once i settle on a way to get rid of freetype
19:01
<eeeee> Savander: specactor mode stops moving when you center your cursor. it's hard to make it work the same way as in desktop client because browsers don't let you easily switch between absolute and relative mouse positioning
19:02
<eeeee> Learath2: can you update your browser to the latest version and then copypaste the contents of developer tools console after it fails to connect to a server?
19:04
<eeeee> and what's qutebrowser, is that like konqueror?