Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2017-08-30 00:00:00Z and 2017-08-31 00:00:00Z
Avatar
GitHub BOT 2017-08-30 04:30:28Z
Author icon
def-
[ddnet-maps:master] 1 new commit
d89fa33 A Zadrotos_final - def-
Avatar
GitHub BOT 2017-08-30 05:48:20Z
Author icon
def-
[ddnet/ddnet] Issue closed: #843 map_resave tool issue
05:48
Author icon
def-
[ddnet/ddnet] Pull request closed: #844 Fixing map_resave tool and add map_replace_image tool
05:48
Author icon
def-
[ddnet:master] 4 new commits
0849fa6 fixing map_resave and adding map_replace_image - sctt 2c748eb Fixing PR over heinrich revision - root 7cd95f6 Fixing spaces and globals - root 3555762 Merge pull request #844 from sctt/master - def-
Avatar
GitHub BOT 2017-08-30 12:02:20Z
Author icon
heinrich5991
[ddnet/ddnet] Pull request opened: #847 Rename `GetUncompressedDataSize` to `GetDataSize`
Also rename the old GetDataSize to GetFileDataSize. GetDataSize now returns the actual data size, not the data size before decompression.
12:05
Author icon
heinrich5991
[ddnet/ddnet] Issue opened: #848 Segmentation when quitting the client after adding an image in the editor
``` Thread 1 "DDNet" received signal SIGSEGV, Segmentation fault. 0x000000010018f181 in CEditorImage::~CEditorImage (this=0x102302de0, in_chrg=<optimized out>) at ../src/game/editor/editor.cpp:64 64 m_pEditor->Graphics()->UnloadTexture(m_TexID); (gdb) bt #0 0x000000010018f181 in CEditorImage::~CEditorImage (this=0x102302de0, in_chrg=<optimized out>) at ../src/game/editor/editor.cpp:64 #1 0x00000001001b28f1 in array<CEditorImage, allocator_default<CEditorImage> >::de...
Avatar
irclink BOT 2017-08-30 13:57:20Z
<redix> Some days ago someone wrote that the precision on the ghost (and i guess the auto recorded demos) is dropped.
Avatar
Savander 2017-08-30 13:57:46Z
Learath2
Avatar
irclink BOT 2017-08-30 13:57:57Z
<redix> Thsi is probably due to this line: https://github.com/ddnet/ddnet/blob/0a9f2913935feccd93c66d739b9b8a3279a7443d/src/engine/client/client.cpp#L3661
ddnet/ddnet
ddnet - DDraceNetwork, a mod of Teeworlds
Thumbnail
Avatar
Savander 2017-08-30 13:58:33Z
348533194355900416
13:58
Learath2 - 19.08.2017 Can someone take a look at how we store ghosts? We seem to drop the precision, we shouldn't
Avatar
irclink BOT 2017-08-30 14:00:20Z
<redix> The servers use dots as decimal-point character but some languages use commas (at least german)
14:01
<redix> the scanf call which extracts the time drops the precision because of this
14:02
<redix> Solution would be to remove the line (at least in the latest sdl version it seems to be fixed) or do the time parsing ourselves
Avatar
Savander 2017-08-30 14:03:56Z
so maybe try to remove that line and pull request with information about fix ? https://hg.libsdl.org/SDL/rev/2f18ea79bc03
hg.libsdl.org/SDL changeset 2f18ea79bc03
Call setlocale + XSetModifiers before XOpenIM, Work around ibus+xim duplicate events.
Avatar
irclink BOT 2017-08-30 14:05:12Z
<redix> Question is whether the systems where the bug occured have to fixed version now
Avatar
Savander 2017-08-30 14:06:20Z
I think ddnet provides dlls with a client? Is he not?
14:07
or libs, don't know what is used on linux
Avatar
irclink BOT 2017-08-30 14:09:15Z
<redix> The bug occured on linux. I don't know whether the bundled or system libs are used for releases
Avatar
Savander 2017-08-30 14:09:27Z
then i don't know
14:09
On windows, there are bundled dlls
14:10
deen: are you here?
Avatar
irclink BOT 2017-08-30 14:11:27Z
<redix> ddnet-libs does not contain a bundled version for sdl...
14:12
<redix> only for windows... not for linux
Avatar
Savander 2017-08-30 14:12:26Z
:/ only for windows, I see
14:13
sorry, I'm not familiar with C/C++. I'm web dev 😛
Avatar
irclink BOT 2017-08-30 14:13:19Z
<redix> In this case doing the parsing ourselves might be the better solution
14:13
<redix> okay :D
14:13
<redix> will look at this later again
Avatar
GitHub BOT 2017-08-30 14:32:46Z
Author icon
def-
[ddnet:master] 1 new commit
43af1fd fixed sprite rendering. Closes #834 - oy
14:32
Author icon
def-
[ddnet/ddnet] Issue closed: #834 Visual bug on default hammer cursor
14:34
Author icon
def-
[ddnet/ddnet] Pull request closed: #847 Rename `GetUncompressedDataSize` to `GetDataSize`
14:34
Author icon
def-
[ddnet:master] 2 new commits
2682480 Rename GetUncompressedDataSize to GetDataSize - heinrich5991 25a5eff Merge pull request #847 from heinrich5991/pr_dd... - def-
Avatar
GitHub BOT 2017-08-30 15:22:40Z
Author icon
def-
[ddnet:master] 1 new commit
7f0eb53 Initialize in order to ensure destruction in or... - def-
15:22
Author icon
def-
[ddnet/ddnet] Issue closed: #848 Segmentation when quitting the client after adding an image in the editor
Avatar
Learath2 2017-08-30 15:29:13Z
@heinrich5991 43af1fd what doesitdo?
Avatar
Savander 2017-08-30 15:31:12Z
https://github.com/teeworlds/teeworlds/blob/master/scripts/tw_api.py#L213
teeworlds/teeworlds
teeworlds - A retro multiplayer shooter
Thumbnail
15:31
What does this line do?
15:31
don't know Python, trying to rewrite to PHP
Avatar
Savander 2017-08-30 15:41:01Z
Nevermind 😃 Python automatically split string to array of characters
15:41
😃
Avatar
Savander 2017-08-30 16:17:04Z
Great, I've done collecting data from MasterServers via PHP, yey. :D https://packagist.org/packages/savander/twservers (edited)
Avatar
irclink BOT 2017-08-30 18:23:27Z
<deen> Learath2: I have trouble with the fetcher
18:23
<deen> It fetches the first 16 KB, and writes them and then I get [2017-08-30 20:21:47][fetcher]: task failed. libcurl error: Failed writing body (0 != 16200)
Avatar
irclink BOT 2017-08-30 18:36:38Z
<deen> wtf, failes with Debug, but works with Release
18:36
<deen> (in cmake)
18:37
<deen> ok, same in bam at least
18:37
<deen> why are our map downloads broken in debug?
Avatar
GitHub BOT 2017-08-30 18:41:24Z
Author icon
def-
[ddnet/ddnet] Issue opened: #849 Fetcher still running while client is closing
Leads to segfault: ``` Thread 7 received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7f4b90f27700 (LWP 10641)] 0x00005555555dc2db in CFetcher::FetcherThread ( pUser=<error reading variable: Cannot access memory at address 0x7f4b90f26ed8>) at /media/ddnet/src/engine/client/fetcher.cpp:82 82 lock_wait(pFetcher->m_Lock); (gdb) bt #0 0x00005555555dc2db in CFetcher::FetcherThread ( pUser=<error reading variable: Cannot access memory at address 0x7f4b90f26e...
18:42
Author icon
def-
[ddnet/ddnet] Issue opened: #850 HTTP fetcher broken in Debug build
On Linux x86-64, using system curl. Fails with [2017-08-30 20:21:47][fetcher]: task failed. libcurl error: Failed writing body (0 != 16200)
Avatar
irclink BOT 2017-08-30 18:45:39Z
<heinrich5991> redix: I think the precision is dropped on the server side
18:46
<heinrich5991> there's a tw vanilla issue about this I think
Avatar
irclink BOT 2017-08-30 18:55:50Z
<redix> heinrich5991: what exactly do you mean? The issue I encountered is that a message like "xxx finished in: 0 minute(s) 21.50 second(s)" is recognized as 0:21.00 if your system language expects 21,50
18:56
<heinrich5991> ok, no, that's something different
18:57
<deen> redix: we already set LC_ALL
18:57
<redix> not sure if this is what Learath2 meant though
18:57
<deen> maybe we need to set some other thingy
18:57
<eeeee> changing https://github.com/ddnet/ddnet/blob/5a437b110f8efdb1c27e38f26b7681ff7d1c33cb/src/engine/client/fetcher.cpp#L170 to "return io_write(..." might fix the downloads. https://curl.haxx.se/libcurl/c/CURLOPT_WRITEFUNCTION.html
ddnet/ddnet
ddnet - DDraceNetwork, a mod of Teeworlds
Thumbnail
18:57
<deen> but not using scanf is probably a better idea
18:59
<redix> LC_ALL is the problem... without LC_NUMERIC all should be fine. But without sscanf might be a better solution
19:00
<deen> eeeee: thanks, that works!
19:00
<deen> redix: make a PR please
19:00
<redix> okay
Avatar
GitHub BOT 2017-08-30 19:01:32Z
Author icon
def-
[ddnet:master] 1 new commit
e480b65 Fix fetcher write function to return size - def-
Avatar
GitHub BOT 2017-08-30 19:16:58Z
Author icon
def-
[ddnet/ddnet] Issue closed: #850 HTTP fetcher broken in Debug build
19:18
Author icon
def-
[ddnet/ddnet] Issue opened: #851 Sound sometimes crashes when exiting
``` Thread 1 "DDNet" received signal SIGSEGV, Segmentation fault. 0x00005555557128b7 in mem_free (p=0x7fadc80a6960) at /media/ddnet/src/base/system.c:375 375 header->next->prev = header->prev; (gdb) bt #0 0x00005555557128b7 in mem_free (p=0x7fadc80a6960) at /media/ddnet/src/base/system.c:375 #1 0x00005555555edffe in CSound::UnloadSample (this=0x555555bd3630, SampleID=6) at /media/ddnet/src/engine/client/sound.cpp:691 #2 0x00005555555ed207 in CSound::Shutdown (this=0x555555bd...
Avatar
irclink BOT 2017-08-30 19:32:13Z
<Learath2> deen: sry totally missed that
19:32
<deen> np :)
19:32
<deen> I have a cool new feature
19:32
<deen> That was written by timakro 2 years ago
19:32
<Learath2> hype?
19:32
<deen> and then abandoned, just made it work
19:32
<deen> yeah, best feature ever, +1000% player growth tomorrow
19:33
<eeeee> Learath2: not your fault curl api has no type safety
19:33
<deen> (but i'd like to get the crashes fixed before releasing)
19:33
<Learath2> what be the feature?
19:33
<deen> eeeee: can you even have type safety in a c api like that?
19:34
<eeeee> not with a generic "setopt" function which does everything. but if they had a specialized function for setting each callback then it could be safe i think.
Avatar
GitHub BOT 2017-08-30 19:34:48Z
Author icon
def-
[ddnet:master] 1 new commit
16f3ddc Show if user has rank on map in browser (+filter) - def-
Avatar
irclink BOT 2017-08-30 19:34:50Z
<deen> Learath2: This:
19:35
<heinrich5991> how? :)
19:35
<heinrich5991> clicks link
19:35
<Learath2> that doesnt sound too safe :D
19:35
<deen> compile it yourself and see!
19:35
<deen> works already with default servers
19:35
<deen> client-only change
19:36
<eeeee> kek
19:37
<Learath2> eh that sounds safe :)
19:37
<Learath2> nice idea
19:37
<deen> maybe need to make sure it only includes the real "ddnet type" servers
19:37
<deen> not block, ictf etc
19:38
<deen> and we have the /players/ web thingy already
19:38
<deen> So https://ddnet.tw/players/?json=deen is super fast
Avatar
Savander 2017-08-30 19:38:58Z
sounds good 😮
Avatar
irclink BOT 2017-08-30 19:39:00Z
<deen> I wanted to add ranks to that too, but I feel like the server browser looks overloaded if we display another number
19:39
<Learath2> i really should have made fetchtasks just jobs :/
19:39
<deen> and then people would all change their name to milk just to have a nice looking server browser
Avatar
Savander 2017-08-30 19:40:13Z
hahahah
Avatar
irclink BOT 2017-08-30 19:40:29Z
<deen> Oh, and we expose the player name to the web server every time you press refresh, not sure what to think about that
19:41
<eeeee> but it's our webserver so it's safe, no?
19:41
<deen> yeah
19:41
<deen> and it's only on ddnet tab
19:41
<deen> so these people will go on our servers anyway
19:42
<Learath2> deen: could the traffic be an issue?
19:42
<deen> nope
19:42
<heinrich5991> not even mysql-webserver traffic?
19:42
<Learath2> well we could always throttle client side if it does
19:42
<deen> I ran time.gif
19:42
<deen> heinrich5991: no mysql required
19:42
<heinrich5991> kk
19:42
<heinrich5991> cached?
19:42
<Learath2> heinrich5991: the player pages are prebuilt iirc
19:42
<deen> heinrich5991: we have all that info in ram for /players/
19:42
<heinrich5991> generated?
19:42
<deen> at all times
19:42
<heinrich5991> cool
19:42
<deen> including all ranks, times etc
19:42
<heinrich5991> sounds safe
19:42
<deen> would be way too slow to request that dynamically
19:42
<heinrich5991> ok
19:42
<heinrich5991> didn't know that
19:43
<deen> that's the main memory user on our server actually :D
19:43
<Learath2> deen: how do we have it on ram?
19:43
<deen> [pid: 11463|app: 0|req: 544/544] 84.191.82.137 () {38 vars in 453 bytes} [Wed Aug 30 21:42:10 2017] GET /players/?json=milk => generated 20415 bytes in 0 msecs (HTTP/1.1 200) 1 headers in 51 bytes (0 switches on core 0)
19:43
<deen> Learath2: it's a uwsgi python thingy, scripts/players.py
19:44
<deen> so should we show the flag or the rank of player instead?
19:45
<heinrich5991> flag
19:45
<heinrich5991> (my vote)
Avatar
Savander 2017-08-30 19:46:05Z
flag
Avatar
irclink BOT 2017-08-30 19:46:10Z
<Learath2> just a checkered finish flag rite?
19:46
<deen> yes
19:46
<Learath2> +1
19:46
<deen> and empty flag when unfinished
19:46
<Learath2> maybe nothing when unfinished to keep it cleaner?
19:46
<deen> and no flag at all for other tabs (and non-ddnet server kinds)
19:47
<deen> hm
19:47
<deen> then it doesn't look aligned
19:47
<deen> or you mean just leaving it empty?
19:47
<Learath2> i mean empty yeah
Avatar
Savander 2017-08-30 19:47:36Z
yea, could be cleaner
19:47
like with password servers
Avatar
irclink BOT 2017-08-30 19:47:47Z
<deen> yeah, doesn't look bad
19:47
<deen> and I have to write less code
19:47
<deen> great
Avatar
Savander 2017-08-30 19:48:00Z
you know Immediately if you finished
Avatar
irclink BOT 2017-08-30 19:49:42Z
<deen> anyone want to figure out the fixes for the new issues I made? have to fix the crashes before release
Avatar
GitHub BOT 2017-08-30 19:50:13Z
Author icon
def-
[ddnet:master] 1 new commit
a1d2ecb Empty when no rank - def-
Avatar
irclink BOT 2017-08-30 19:56:41Z
<Learath2> deen: #849 is #825
19:57
<Learath2> need to terminate it before quitting the main process
Avatar
GitHub BOT 2017-08-30 19:57:01Z
Author icon
def-
[ddnet/ddnet] Issue closed: #849 Fetcher still running while client is closing
Avatar
irclink BOT 2017-08-30 19:57:07Z
<deen> ok, can you do that?
19:58
<Learath2> it would be quite antisocial of me to code on a boat :P
19:58
<Learath2> can try to sneak it in after everyone else goes to sleep if you really need me to :)
19:58
<deen> nah, that's fine
Avatar
Savander 2017-08-30 19:58:40Z
lol
19:58
coding on boat
19:58
new achievement
Avatar
irclink BOT 2017-08-30 19:58:57Z
<Learath2> @Savander yean i'd never hear the end of that one
Avatar
Savander 2017-08-30 19:59:00Z
you should show them DDNet, maybe they will start to code with you
19:59
as wel
19:59
well 😮
Avatar
GitHub BOT 2017-08-30 20:03:40Z
Author icon
heinrich5991
[ddnet/ddnet] Pull request opened: #852 Add testing; fix, rename and test the `CEditor::ExtractName` function
Fixes #846.
Avatar
irclink BOT 2017-08-30 20:03:53Z
<heinrich5991> does someone have ubuntu here?
20:04
<deen> gtest?
20:04
<heinrich5991> google test
20:04
<heinrich5991> used by llvm, chromium
20:04
<deen> I know gtest
20:04
<deen> just wondering, you're adding that
20:05
<heinrich5991> I have no experience with testing frameworks, so I just picked the seemingly most popular one
20:05
<heinrich5991> if you know something better, I can change that
20:05
<deen> nono, i have lots of experience with gtest from work
20:05
<heinrich5991> cool
20:05
<heinrich5991> so did I do it correctly? ^^
20:06
<deen> dunno, there are no tests yet :D
20:06
<heinrich5991> there are five
20:06
<deen> you forgot to add them?
20:06
<heinrich5991> https://github.com/ddnet/ddnet/pull/852/files#diff-b46255edcb8ce021a21c6b190484bc23
Add testing; fix, rename and test the CEditor::ExtractName function by heinrich5991 · Pull Request #852 · ddnet/ddnet
Fixes #846.
Thumbnail
20:06
<heinrich5991> no
20:06
<deen> ah
20:07
<deen> not used to tests not starting with Unit* :D
20:07
<heinrich5991> :)
20:07
<deen> you could use parameterized teests
20:08
<heinrich5991> that sounds like something reasonable
20:08
<deen> but in this case just use a fixture class with a helper method and call that
20:08
<heinrich5991> a what?
Avatar
Savander 2017-08-30 20:08:17Z
new age of ddnet? unit tests ?
Avatar
irclink BOT 2017-08-30 20:08:28Z
<heinrich5991> what is a fixture class?
20:08
<deen> and each test uses the fixture class and calls the method
20:08
<deen> I'll just merge it and show you?
20:08
<heinrich5991> sure
20:09
<heinrich5991> make run_tests to run the tests
Avatar
GitHub BOT 2017-08-30 20:09:18Z
Author icon
def-
[ddnet/ddnet] Pull request closed: #852 Add testing; fix, rename and test the `CEditor::ExtractName` function
20:09
Author icon
def-
[ddnet:master] 3 new commits
22be1be Fix and rename the CEditor::ExtractName function - heinrich5991 de2fd75 Add possibility to write tests - heinrich5991 eb2634a Merge pull request #852 from heinrich5991/pr_dd... - def-
20:09
Author icon
def-
[ddnet/ddnet] Issue closed: #846 Fix `ExtractName` after #844 lands
Avatar
irclink BOT 2017-08-30 20:09:41Z
<deen> make: *** No rule to make target 'run_tests'. Stop.
20:10
<heinrich5991> in the build folder
20:10
<deen> ah, have to install gtest
20:10
<heinrich5991> oh yea, that too
20:10
<heinrich5991> do you happen to have ubuntu?
20:10
<deen> arch
20:10
<heinrich5991> (that's the CI environment)
20:10
<heinrich5991> meh, already tested there :D
Avatar
Deleted User 2017-08-30 20:11:43Z
I want to learn how to create webhooks for ddnet :C
Avatar
irclink BOT 2017-08-30 20:11:57Z
<deen> webhooks for discord?
Avatar
heinrich5991 2017-08-30 20:11:57Z
webhooks?
Avatar
irclink BOT 2017-08-30 20:12:16Z
<heinrich5991> .
20:12
<heinrich5991> duh, irc window broken :(
20:12
<heinrich5991> better
Avatar
Deleted User 2017-08-30 20:12:42Z
yes
20:12
like
Avatar
irclink BOT 2017-08-30 20:12:48Z
<deen> it's just a POST to https://discordapp.com/api/webhooks/SECRETCODEHERE
Avatar
Deleted User 2017-08-30 20:12:54Z
imagine i finish a map on ddnet
Avatar
Savander 2017-08-30 20:12:57Z
https://discordapp.com/developers/docs/resources/webhook
Discord API Docs for Bots and Developers
Integrate your service with Discord - whether it's a bot or a game or your whatever you wildest imagination can come up with.
Thumbnail
Avatar
irclink BOT 2017-08-30 20:12:57Z
<deen> with a json {'content': msg}
Avatar
Deleted User 2017-08-30 20:13:02Z
i wanted it to send a message on my dioscord
20:13
saying that i did it
Avatar
Savander 2017-08-30 20:13:11Z
discord webooks, if you are interested
Avatar
irclink BOT 2017-08-30 20:13:19Z
<deen> Well, you can't do that because you don't have ssh on the ddnet server
Avatar
Deleted User 2017-08-30 20:13:20Z
lemme see savander
20:13
whats ssh
Avatar
irclink BOT 2017-08-30 20:13:37Z
<deen> i mean, it's a script we run on our sever every few minutes
Avatar
Savander 2017-08-30 20:13:41Z
RockuS. DDnet send post data to discord, to the specific url
Avatar
Deleted User 2017-08-30 20:13:43Z
oh
Avatar
irclink BOT 2017-08-30 20:13:46Z
<deen> and it just checks for new ranks and puts them on discord
Avatar
Savander 2017-08-30 20:13:52Z
that's why, you can see notifications :P.
Avatar
Deleted User 2017-08-30 20:13:54Z
i see
20:14
aw rip then
20:16
what is that irclink thing
20:16
its a webhook
20:17
for you to send messages
Avatar
Savander 2017-08-30 20:17:01Z
You still can parse ddnet site
Avatar
Deleted User 2017-08-30 20:17:13Z
but i don't know anything related to programming and shit
Avatar
Savander 2017-08-30 20:17:13Z
to gather information by your script
Avatar
irclink BOT 2017-08-30 20:17:15Z
<heinrich5991> or get the records from the ddnet discord bot
20:17
<Learath2> i give permission to the bot to post here
Avatar
Savander 2017-08-30 20:17:38Z
or you can do that, right 😛
Avatar
Deleted User 2017-08-30 20:17:44Z
but idk how
Avatar
Savander 2017-08-30 20:17:57Z
Actually, its something more
20:18
webhook's are a bit different to pure bots
Avatar
Deleted User 2017-08-30 20:18:22Z
and i don't understand either of them
Avatar
irclink BOT 2017-08-30 20:18:22Z
<Learath2> webhooks get to send messages
Avatar
Deleted User 2017-08-30 20:18:28Z
bots do actions
Avatar
irclink BOT 2017-08-30 20:18:34Z
<Learath2> bot's can parse and act on messages on discord
20:18
<deen> heinrich5991: like this:
Avatar
GitHub BOT 2017-08-30 20:18:54Z
Author icon
def-
[ddnet:master] 1 new commit
58c5303 Change unit test layout - def-
Avatar
Deleted User 2017-08-30 20:18:54Z
i see
Avatar
Savander 2017-08-30 20:19:09Z
Omg, DDNET WILL HAVE UNIT TEST S 😮
20:19
NO MORE CRASHES 😮
Avatar
Deleted User 2017-08-30 20:19:20Z
what's that XD
Avatar
Savander 2017-08-30 20:19:39Z
ehm, in PHP it test specific function
20:19
if it still works :v
20:19
or whole feature
Avatar
Deleted User 2017-08-30 20:20:11Z
it's too complicated
Avatar
Savander 2017-08-30 20:20:20Z
i'm not C programmer, unfortunately :?
Avatar
irclink BOT 2017-08-30 20:20:55Z
<heinrich5991> deen: this doesn't look like much of an improvement
20:21
<heinrich5991> tbh
20:21
<deen> not using macros is the improvement
20:21
<heinrich5991> ok
20:21
<deen> otherwise it does the same, yes
20:21
<heinrich5991> why do you need a whole class though?
20:21
<heinrich5991> function would work too, right?
20:22
<heinrich5991> what does TEST_F do different from TEST?
20:22
<deen> oh, probably yes. we always use classes so that we can use constructor/destructor for additional setup/cleanup for each test
20:22
<deen> and some magic stuff
20:22
<deen> not sure if we'll need that in ddnet
20:22
<heinrich5991> not in that case, probably
Avatar
GitHub BOT 2017-08-30 20:25:57Z
Author icon
Redix
[ddnet/ddnet] Pull request opened: #853 Ghost and Race demo time extraction fix
On systems that use a language with comma as decimal-point character, the decimal places of the ghosts and race demos are dropped. The sscanf call stops when it reaches the dot used by the servers. The time parsing functions are probably a bit more complicated then needed, but they are able to parse the chat messages of any ddnet, ddrace and race version I encountered. Seconds are parsed up to the third decimal place.
Avatar
irclink BOT 2017-08-30 20:26:53Z
<Learath2> redix: could you fix the actual timing while at it?
20:26
<Learath2> we should store more then t
20:27
<Learath2> the seconds
20:27
<redix> the code extracts up to 3 decimal places
20:28
<Learath2> redix: unless you changed sth it doesn't
20:28
<heinrich5991> I guess you could also replace decimal commas with dots or so?
20:28
<heinrich5991> before trying to parse
20:28
<Learath2> it looked to me as it did aswell, after trying apparently it doesn't
20:30
<redix> Learath2 what exactly happens? for me everything is fine now :O
20:35
<Learath2> get the time 7.25, then get the time 7.20 you get new record but your old ghost is what exists
20:35
<Learath2> Tezcan can show it to you if you find him ingame
20:36
<redix> this should be fixed now... the client used 7.00 for both. So the second wasn't better
Avatar
Learath2 2017-08-30 20:37:19Z
Oh so you did fix it up
Avatar
GitHub BOT 2017-08-30 20:37:22Z
Author icon
def-
[ddnet:master] 1 new commit
040fc9c Implement right click and middle click on count... - def-
Avatar
irclink BOT 2017-08-30 20:38:56Z
<redix> i think so... at least if Tezcans system uses , for decimal-points
Avatar
Learath2 2017-08-30 20:44:20Z
Tezcans server is just a normal ddnet server modified to store 1 more digit. It s record messages are same
Avatar
Ryozuki 2017-08-30 20:44:32Z
it has more features tho
Avatar
irclink BOT 2017-08-30 20:45:53Z
<redix> sure... but the system he ran the client on when he noticed the bug
Avatar
Learath2 2017-08-30 20:52:28Z
We could send a NETMSG_RACE_STATE aswell to indicate finishes and stuff
20:52
So might not need that weird parsing
Avatar
irclink BOT 2017-08-30 20:55:21Z
<heinrich5991> what is NETMSG_RACE_STATE?
20:56
<redix> advantage of this parsing is that it works with any version of ddnet or whatever race mod you are running
20:56
<heinrich5991> yep
Avatar
Savander 2017-08-30 20:56:35Z
it will be only for ddnet tab i guess ?
Avatar
irclink BOT 2017-08-30 20:57:26Z
<redix> some even leave the minute part out if your time is below 60 seconds. works with this pr :D
Avatar
Savander 2017-08-30 20:58:07Z
Wait a second, I am dev? o.O
Avatar
Ryozuki 2017-08-30 20:58:33Z
btw, how reliably is the race time counter?
Avatar
Savander 2017-08-30 20:59:17Z
thousands ?
Avatar
Ryozuki 2017-08-30 20:59:24Z
usually speedrun games have a high precision timer
Avatar
irclink BOT 2017-08-30 20:59:27Z
<heinrich5991> 0.02
20:59
<heinrich5991> seconds
Avatar
Ryozuki 2017-08-30 20:59:34Z
:/
Avatar
irclink BOT 2017-08-30 20:59:40Z
<heinrich5991> IIRC
20:59
<heinrich5991> unless we applied the race patch
Avatar
Savander 2017-08-30 20:59:51Z
for example, teesites race severs
20:59
has thousandths
Avatar
irclink BOT 2017-08-30 20:59:58Z
<heinrich5991> yes
Avatar
Savander 2017-08-30 21:00:18Z
It would be too late, to change that thing ?
Avatar
Ryozuki 2017-08-30 21:00:25Z
i saw 0.0001 on some games
Avatar
Savander 2017-08-30 21:00:35Z
I mean, to make bigger precision
Avatar
Ryozuki 2017-08-30 21:00:44Z
or maybe not(?) i dont remember
Avatar
Savander 2017-08-30 21:00:53Z
0.0001 seems too high
21:00
but who knows.
Avatar
Ryozuki 2017-08-30 21:00:58Z
yeah xD
Avatar
Savander 2017-08-30 21:00:59Z
If i remember, in Trackmania
Avatar
Ryozuki 2017-08-30 21:01:02Z
yes
Avatar
Savander 2017-08-30 21:01:09Z
i saw precision like that
21:01
hmm
Avatar
Ryozuki 2017-08-30 21:01:19Z
trackmania, every ms counts
Avatar
Savander 2017-08-30 21:01:28Z
even half of a ms 😄
Avatar
Ryozuki 2017-08-30 21:01:30Z
yes
Avatar
irclink BOT 2017-08-30 21:01:39Z
<heinrich5991> nah, trackmania was 0.001 I think
Avatar
Savander 2017-08-30 21:01:52Z
I think, more like 0.002
21:02
i never saw 0.003/5/7
21:02
it was always even number
Avatar
Ryozuki 2017-08-30 21:02:48Z
http://dedimania.net/tm2stats/?do=stat&Envir=Stadium&UId=7yN2DsBnbG8swVNQ81oAcS4pGe5&Show=RECORDS
21:02
0.001?
Avatar
Savander 2017-08-30 21:03:45Z
nevermind
21:03
😄
21:03
http://dedimania.net/tm2stats/?do=stat&Envir=Stadium&RecOrder3=REC-ASC&UId=oFCBcoNpAKYW7fSu9w5DmdtzKAg&Show=RECORDS
21:03
ah right
Avatar
Ryozuki 2017-08-30 21:03:55Z
xD
Avatar
Savander 2017-08-30 21:04:33Z
but what with performance? Could it cause more usage?
21:05
Btw, i had idea to add "Exclude Gamemode" in filter's
Avatar
irclink BOT 2017-08-30 21:05:58Z
<heinrich5991> no
21:06
<heinrich5991> re performance
21:06
<redix> well 0.001 precision is mostly useful for fastcap and short runs
Avatar
Savander 2017-08-30 21:06:30Z
no, to exlucde gamemode? or to performance?
Avatar
irclink BOT 2017-08-30 21:06:41Z
<heinrich5991> [23:06:06] <@heinrich5991> re performance
Avatar
Ryozuki 2017-08-30 21:06:43Z
https://ddnet.tw/ranks/solo/#map-Gorou e.e
Avatar
Savander 2017-08-30 21:06:54Z
what does it mean 😄
Avatar
Ryozuki 2017-08-30 21:07:16Z
i think he means it doesnt affect perfomence ?
Avatar
Savander 2017-08-30 21:07:55Z
I meant "re" word. But i guess i understand, it's like "it was about that topic"
Avatar
irclink BOT 2017-08-30 21:07:55Z
<heinrich5991> yes
Avatar
Savander 2017-08-30 21:08:30Z
sometimes i got brain lags. I am apologize
Avatar
irclink BOT 2017-08-30 21:08:30Z
<heinrich5991> why exclude gamemodes?
21:08
<heinrich5991> doesn't exclude suffice?
Avatar
Savander 2017-08-30 21:08:46Z
Not really
21:08
because, i see o lot of ddrace servers
21:09
and if I want to see everything else, but not ddrace
Avatar
irclink BOT 2017-08-30 21:09:15Z
<heinrich5991> you type ddrace into exclude?
Avatar
Savander 2017-08-30 21:09:17Z
it's not really possible. Or maybe i don't know how to use exclude in filter at bottom properly
21:10
Like that /
21:10
http://www.wasz.ovh/img/P8nY9yVC80230
Screenshot_P8nY9yVC80230
1 view(s)
Thumbnail
21:11
It looks like it doesn't work
Avatar
irclink BOT 2017-08-30 21:12:00Z
<heinrich5991> maybe it doesn't capture game mode, like quick search
Avatar
Savander 2017-08-30 21:12:12Z
But, actually its weird
21:12
it exclude every ddnet server
Avatar
irclink BOT 2017-08-30 21:12:34Z
<heinrich5991> because of ddracenetwork in the title
Avatar
Savander 2017-08-30 21:12:35Z
Ah right, because ddnet has "DDrace" word
Avatar
irclink BOT 2017-08-30 21:12:35Z
<heinrich5991> probably
Avatar
Savander 2017-08-30 21:12:38Z
in server name
21:12
it doesn't work for gamemodes
Avatar
GitHub BOT 2017-08-30 21:14:07Z
Author icon
def-
[ddnet:master] 1 new commit
7d71dae Fetcher: sephamore instead of spinlock, exit th... - def-
Avatar
Ryozuki 2017-08-30 21:15:25Z
what does the fetcher fetch?
Avatar
Savander 2017-08-30 21:15:29Z
Maybe i could try to add that thing ?
21:15
I would learn something 😄 In C
Avatar
irclink BOT 2017-08-30 21:15:39Z
<deen> @Ryozuki http downloader
Avatar
Ryozuki 2017-08-30 21:15:51Z
ah
Avatar
Savander 2017-08-30 21:15:53Z
not always that Web things
Avatar
GitHub BOT 2017-08-30 21:18:23Z
Author icon
def-
[ddnet/ddnet] Issue closed: #825 CFetcher::FetcherThread has no way to terminate properly
21:19
Author icon
def-
[ddnet:master] 1 new commit
a20db6e Don't shutdown sound twice (fixes #851) - def-
21:19
Author icon
def-
[ddnet/ddnet] Issue closed: #851 Sound sometimes crashes when exiting
Avatar
Savander 2017-08-30 21:20:06Z
ha! Cool ~!
21:20
http://www.wasz.ovh/img/LEMjhhX980301
Screenshot_LEMjhhX980301
1 view(s)
Thumbnail
21:20
i can use CLion to compile/debug ddnet
21:20
D:
Avatar
irclink BOT 2017-08-30 21:20:47Z
<heinrich5991> ?
21:20
<deen> What's the status with #853? redix? Should I wait before releasing new client?
21:21
<heinrich5991> is currently reviewing #853
21:23
<redix> The code fixes at least the bug i encountered. Looks a bit weird maybe but it works and is quite flaxible :D
21:23
<redix> flexible*
Avatar
Ryozuki 2017-08-30 21:33:16Z
NETMSG_SNAPSINGLE, // ?
21:33
best comment ever
Avatar
irclink BOT 2017-08-30 21:33:45Z
<heinrich5991> a snapshot diff contained in only a single message
Avatar
Ryozuki 2017-08-30 21:34:09Z
you know the whole tw protocol?
21:34
nice :o
21:34
(well most the enums there are obvius)
21:34
what about
21:34
NETMSG_SNAPSMALL, //
Avatar
irclink BOT 2017-08-30 21:34:52Z
<heinrich5991> not used
Avatar
Ryozuki 2017-08-30 21:35:03Z
why its there then?
Avatar
irclink BOT 2017-08-30 21:35:19Z
<deen> @Ryozuki You know that heinrich5991 reimplemented the tw protocol in Rust?
Avatar
Ryozuki 2017-08-30 21:35:32Z
no, can see source?
Avatar
irclink BOT 2017-08-30 21:35:43Z
<heinrich5991> yes, thanks to deen
21:35
<heinrich5991> heinrich5991/libtw2
21:35
<deen> thanks to me?
21:36
<heinrich5991> yes
21:36
<deen> how so?
21:36
<heinrich5991> you bugged me long enough to put it on github ^^
21:36
<deen> ah, that's what you mean
Avatar
Ryozuki 2017-08-30 21:48:47Z
static const unsigned char SECURITY_TOKEN_MAGIC[] = {'T', 'K', 'E', 'N'};
21:48
idk why i find lot of the tw code to be funny
Avatar
Savander 2017-08-30 21:49:03Z
What do you think, about add to exclude gametypes ? https://github.com/ddnet/ddnet/blob/master/src/engine/client/serverbrowser.cpp#L248-L266
ddnet/ddnet
ddnet - DDraceNetwork, a mod of Teeworlds
Thumbnail
Avatar
irclink BOT 2017-08-30 21:52:20Z
<heinrich5991> Savander: better add gamemode support to exclude filter
Avatar
Savander 2017-08-30 21:52:35Z
yea, i mentioned that code
Avatar
irclink BOT 2017-08-30 21:53:07Z
<heinrich5991> deen: you broke the build
21:53
<heinrich5991> /Users/travis/build/ddnet/ddnet/src/engine/client/fetcher.h:18:2: error: unknown type name 'SEMAPHORE'
Avatar
Savander 2017-08-30 21:53:49Z
i added it now, 😛 But i can't really make pull request
Avatar
irclink BOT 2017-08-30 21:53:56Z
<heinrich5991> why not?
Avatar
Savander 2017-08-30 21:53:57Z
i mean, i don't know how 😮
Avatar
irclink BOT 2017-08-30 21:54:11Z
<heinrich5991> mh
21:54
<heinrich5991> do you know how to use git?
21:55
<heinrich5991> deen: (on mac: https://travis-ci.org/ddnet/ddnet/jobs/270160021)
Avatar
GitHub BOT 2017-08-30 21:55:11Z
Author icon
savander
[ddnet/ddnet] Pull request opened: #854 Add gametype support to exclude field
Avatar
Savander 2017-08-30 21:55:15Z
nevermind
21:55
i did it from github.com
21:55
im using Git, but for my own project's
21:55
withour pr's
21:55
without*
Avatar
irclink BOT 2017-08-30 21:55:49Z
<deen> oh grea,t we have no semaphores on mac?!
21:57
<eeeee> they must be called iSemaphores on mac
21:58
<deen> cool, file size never worked in teeworlds
21:59
<deen> makes me wonder why that doesn't cause more problems
21:59
<heinrich5991> file size?
21:59
<deen> io_length
22:00
<heinrich5991> what do we use filesize for?
22:00
<deen> hm, or is it right after all. somewhere is an off by one error
22:00
<deen> embedding sounds into maps for example
22:01
<deen> and opening sounds in general
Avatar
Savander 2017-08-30 22:02:06Z
I wonder, if i can copy ddnet's CMakeLists.txt with CMake folder. It would work?
Avatar
irclink BOT 2017-08-30 22:02:11Z
<heinrich5991> embedding sounds into maps -> just read until end? ^^
22:02
<deen> currently it uses io_length
22:05
<deen> ah no, my bad!
Avatar
GitHub BOT 2017-08-30 22:08:03Z
Author icon
def-
[ddnet:master] 1 new commit
bff1c12 Don't try to load ddnet-ranks.json while fetche... - def-
Avatar
Savander 2017-08-30 22:11:28Z
woah, it looks pretty good 😮
22:11
those flags
Avatar
irclink BOT 2017-08-30 22:19:07Z
<deen> If anyone can fix the mac build, would be nice. I might take a look tomorrow.
22:21
<deen> or I try named semaphores
22:22
<heinrich5991> maybe the unix version just works on mac as well?
22:22
<deen> no
22:22
<deen> there are no unnamed semaphores
22:22
<heinrich5991> ok
22:22
<deen> so i will hack around using named ones with unique names
22:22
<deen> otherwise you couldn't run 2 ddnet clients at once...
22:24
<deen> i guess tomorrow is good enough, good night
22:24
<heinrich5991> good night
Avatar
jao 2017-08-30 22:31:05Z
Is it known, that bullets affect only the player who is longest alive, even on solo server?
Avatar
irclink BOT 2017-08-30 22:31:29Z
<heinrich5991> what do you mean?
22:31
<heinrich5991> you can't do grenade jumps?
Avatar
jao 2017-08-30 22:32:09Z
the gametiles (220-223)
Avatar
irclink BOT 2017-08-30 22:32:26Z
<heinrich5991> the shotgun things?
Avatar
jao 2017-08-30 22:34:24Z
moving tiles that either hit, freeze or unfreeze you
Avatar
irclink BOT 2017-08-30 22:35:38Z
<heinrich5991> ah, the laser bullets
Avatar
jao 2017-08-30 22:35:43Z
ye
22:36
apparently it doesn't matter if you are longest alive tho
22:36
seems to be random
Avatar
irclink BOT 2017-08-30 22:36:19Z
<heinrich5991> the first one to enter the range, right?
Avatar
jao 2017-08-30 22:37:41Z
no idea, looks random to me
22:38
anyways, it's annoying that they ignore teams
Avatar
irclink BOT 2017-08-30 22:39:59Z
<heinrich5991> I think they don't ignore teams
22:40
<heinrich5991> only solo
Avatar
jao 2017-08-30 22:40:29Z
solo server is handled like everyone is in a seperate team or not?
Avatar
irclink BOT 2017-08-30 22:40:43Z
<heinrich5991> dunno, don't think so
22:41
<heinrich5991> I think everyone is just solo
Avatar
jao 2017-08-30 22:42:13Z
I think the bullet affects the player that lives the shortest
22:42
can't be, else switches wouldn't work
Avatar
irclink BOT 2017-08-30 22:42:43Z
<heinrich5991> true
Avatar
jao 2017-08-30 22:47:40Z
is it possible to fix it?
Avatar
irclink BOT 2017-08-30 22:48:19Z
<heinrich5991> what do you mean with "possible"?
22:48
<heinrich5991> technically, it is possible – whether such a change would be desired is another question
Avatar
jao 2017-08-30 22:49:58Z
well it's a bug
Avatar
irclink BOT 2017-08-30 22:50:15Z
<heinrich5991> if it is a team thing, then yes
Avatar
jao 2017-08-30 22:50:21Z
you can possibly cheat maps if you abuse it
Avatar
irclink BOT 2017-08-30 22:50:51Z
<heinrich5991> if it only affects solo (not the solo server kind), then it's not clear that it's a bug
Avatar
jao 2017-08-30 22:51:37Z
hm I tested it on solo server^^
Avatar
irclink BOT 2017-08-30 22:52:03Z
<heinrich5991> maybe the teams stuff of the solo server is just bugged :)
Avatar
jao 2017-08-30 22:54:57Z
ok, tested it with teams instead of solo server. same outcome :p
Avatar
GitHub BOT 2017-08-30 23:15:32Z
Author icon
heinrich5991
[ddnet/ddnet] Pull request opened: #855 Run tests on Travis on Linux
Fix the style of our only test.
Avatar
Ryozuki 2017-08-30 23:20:41Z
^^
Avatar
irclink BOT 2017-08-30 23:44:50Z
<sctt_> heinrich5591: im going to code a map_randomize_names tool, but i'm almost sure you are not interested in merging that right?
23:45
<heinrich5991> what would that do?
23:45
<sctt_> randomize the name of map images
23:45
<heinrich5991> why would you do that? ^^
23:45
<sctt_> xD
23:45
<sctt_> long story
23:45
<sctt_> i've built a captcha system, a that will help to prevent a bit more in analizing the captcha
23:46
<sctt_> that's why i wrote a image_replace tool in the first place
23:46
<sctt_> you can look this demo
23:46
<heinrich5991> ah
23:46
<sctt_> https://streamable.com/caeud
23:47
<heinrich5991> mh :)
23:47
<heinrich5991> ask deen, but I don't think we need that tool ^^
23:47
<sctt_> yeah that's what i thought xD
23:49
<heinrich5991> night
23:49
<sctt_> good night!
Exported 493 message(s)