DDraceNetwork - developer

Learath2

[ddnet-web:master] 1 new commit

25a45d2 Add Silex - Learath2

<sctt_> hi

09:23

<heinrich5991> hi

heinrich5991

[ddnet/ddnet] Pull request opened: #845 Add Windows CMake compilation instructions

<heinrich5991> sctt_: is the pull request more or less done now?

<heinrich5991> is there someone capable of making good screenshot guides for windows? https://github.com/ddnet/ddnet/pull/845#discussion_r135739812

Add CMake compilation instructions by heinrich5991 · Pull Request #845 · ddnet/ddnet

13:27

<heinrich5991> Ryozuki: are you, or do you maybe know someone who is? :)

<Ryozuki> i am able

13:41

<Ryozuki> heinrich5991, you could extend https://wiki.ddnet.tw/Compiling_DDRaceNetwork

Compiling DDRaceNetwork

13:41

<Ryozuki> we got a nice wiki e.e why not use it

13:41

<Ryozuki> (that page is outdated/incomplete btw)

13:44

<heinrich5991> I updated the README, but I can also update that page

13:46

<deen> Please only keep information in one place

13:46

<deen> when people go to compile ddnet, they will be on github already, so keep the info there. Merge all the additional info from the wiki into that and make the wiki a link to github readme

13:47

<heinrich5991> it doesn't look like the wiki page has extra info right now

13:47

<heinrich5991> looks like a copy of the old readme

13:47

<Ryozuki> yes...

def-

[ddnet/ddnet] Pull request closed: #845 Add CMake compilation instructions

13:47

def-

[ddnet:master] 3 new commits

3df0df4 Add Windows CMake compilation instructions - heinrich5991 bd229a2 Change the Linux/MacOS build instructions to CMake - heinrich5991 5d98b55 Merge pull request #845 from heinrich5991/pr_dd... - def-

<deen> Don't make copies of information...

13:47

<deen> No one wants to maintain multiple versions

13:47

<Ryozuki> 07:21, 18 June 2016‎

13:47

<Ryozuki> anyways its rly old

13:48

<Ryozuki> (last edit)

<Ryozuki> http://i.imgur.com/NGMMxIp.png

14:00

<Ryozuki> http://i.imgur.com/8HoUF90.png

14:00

<Ryozuki> good?

14:00

<Ryozuki> or to confusing

14:02

<Ryozuki> (visual studio adds lots of files over the place, idk if there is some kind of clean cmd, also the end build ends up at Debug/ and the dlls needed arent there

14:03

<heinrich5991> but if you execute it with visual studio it runs, right?

14:03

<heinrich5991> I vote for "too confusing" btw

14:03

<heinrich5991> soo many arrows

14:03

<Ryozuki> so

14:03

<Ryozuki> you want lot of images instead?

14:03

<heinrich5991> I think that would actually be better

14:04

<heinrich5991> interesting points also are the install C++ extensions for MSVS and the install python for all users

14:05

<Ryozuki> visual studio fills the ddnet folder with shit

14:05

<Ryozuki> and it is run from ddnet/build

14:05

<Ryozuki> i dont see why it does that

14:05

<heinrich5991> does it? which files for example?

14:08

<Ryozuki> http://i.imgur.com/01wm6Oq.png

14:08

<Ryozuki> http://i.imgur.com/F2TND1o.png

14:09

<heinrich5991> :D that's not good

14:09

<heinrich5991> let me boot my windows computer

14:10

<sctt_> heinrich5991: yes, this morning i've tested a lot map_replace_image tool and it seems to work well in many situations, so i guess im not going to add any other commits

14:11

<heinrich5991> could you squash all these commits into one?

14:11

<heinrich5991> wait a second, I can probably tell you the right command

14:13

<heinrich5991> sctt_: you with me? :)

14:13

<sctt_> oh ok

14:13

<sctt_> yes :D

14:13

<sctt_> i thought you could do something like "Squash and merge"

14:13

<sctt_> i saw i somewhere

14:13

<heinrich5991> are you in the git command line with inside the repository?

14:13

<sctt_> yes

14:14

<heinrich5991> what is the upstream git repository named, do you already have a name for that?

14:14

<heinrich5991> git remote -v can show you that

14:15

<sctt_> yes wait 1 sec

14:16

<heinrich5991> Ryozuki: it hasn't created these folders for me, they're probably artifacts from an earlier build

14:16

<Ryozuki> mmm

14:16

<Ryozuki> let me test again

14:18

<sctt_> heinrich5991: origin https://github.com/sctt/ddnet.git (fetch) origin https://github.com/sctt/ddnet.git (push)

sctt/ddnet

ddnet - DDraceNetwork, a mod of Teeworlds

14:18

<heinrich5991> sctt_: do "git remote add remote https://github.com/ddnet/ddnet"

14:18

<sctt_> done

14:19

<heinrich5991> git fetch upstream

14:19

<heinrich5991> and then you can do git rebase upstream/master

14:19

<sctt_> fatal: 'upstream' does not appear to be a git repository

14:19

<sctt_> :(

14:19

<heinrich5991> duh

14:19

<heinrich5991> git remote rename remote upstream

14:19

<heinrich5991> a typo from me

14:20

<Ryozuki> https://help.github.com/articles/syncing-a-fork/

14:20

<Ryozuki> oh

14:20

<Ryozuki> its not that :P

14:20

<sctt_> heinrich5991: ok it worked now^^

14:20

<sctt_> Ryozuki: thanks i will read that :D

14:20

<heinrich5991> then do git rebase upstream/master

14:21

<sctt_> ok it applied

14:21

<Ryozuki> i recloned ddnet

14:21

<Ryozuki> im getting a error with cmake now

14:21

<Ryozuki> :D

14:21

<heinrich5991> :(

14:21

<Ryozuki> it doesnt use bundled libs?

14:21

<heinrich5991> Ryozuki: btw, you can clean your repository with git clean

14:21

<Ryozuki> CMake Error at CMakeLists.txt:126 (message):

14:21

<Ryozuki> You must install Curl to compile the DDNet client

14:21

<Ryozuki> + with all libs

14:21

<heinrich5991> Ryozuki: did you clone with --recursive?

14:22

<heinrich5991> otherwise do a git submodule update --init

<Ryozuki> hein

14:22

<Ryozuki> oh

14:22

<Ryozuki> im dumb

14:22

<Ryozuki> :D

14:22

<Ryozuki> always forget that..

14:22

<heinrich5991> sctt_: do a git rebase upstream/master again and mark all but the first commit as "squash"

14:22

<heinrich5991> and don't reclone ^^

14:23

<sctt_> heinrich5991:git rebase upstream/master Current branch master is up to date.

14:23

<heinrich5991> ah right

14:23

<heinrich5991> I ment git rebase -i upstream/master

14:23

<heinrich5991> -i for interactve

14:23

<sctt_> oh i see

14:24

<sctt_> my editor opened, how to mark the commits as squash? xD

14:24

<sctt_> i see pick 46d51e2 Update map_resave.cpp

14:24

<heinrich5991> replace pick by squash

14:24

<sctt_> should i rename pick into squash>

14:24

<heinrich5991> yes

14:24

<sctt_> oh ok

14:24

<Ryozuki> heinrich5991, using the cmake gui and building with vs2017 fills the ddnet folder also

14:25

<heinrich5991> I have vs2015. mh

14:25

<heinrich5991> have you selected a different build folder?

14:25

<sctt_> can i rename the first commit name during this process?

14:25

<Ryozuki> Desktop/ddnet/build

14:25

<heinrich5991> you'll be prompted afterwards, sctt_

14:25

<sctt_> ok :D

14:26

<Ryozuki> heinrich5991, looks like vs is generating the object files at ddnet folder instead of build

14:26

<Ryozuki> idk why

14:26

<heinrich5991> so I should install msvs 2017? :(

14:27

<Ryozuki> it currently builds generating the object files at ddnet and then moves those to the build folder

14:27

<Ryozuki> but the folders remain there

14:27

<heinrich5991> hmm

14:27

<sctt_> heinrich5991: ok it finished

14:27

<sctt_> but i still see all the commits

14:28

<heinrich5991> then do git push origin +master

14:29

<sctt_> heinrich5991: ok it worked :D i see only one commit now, thank you

14:30

<Ryozuki> git clean -f doesnt remove the folders :/

14:30

<heinrich5991> -fd

14:30

<heinrich5991> but do -nd first

14:30

<heinrich5991> to see which it would remove

14:31

<Ryozuki> to late

14:31

<Ryozuki> λ git clean -fd

14:31

<Ryozuki> Removing build/data/

14:31

<Ryozuki> doesnt remove folders

14:31

<heinrich5991> git clean -nxd

14:31

<heinrich5991> that also removes files ignored by git

14:31

<heinrich5991> (the -x)

14:31

<Ryozuki> that looks good

14:32

<Ryozuki> and worked

14:32

<Ryozuki> -xdf

14:33

<Ryozuki> mmm what about writing a bat script to build it

14:33

<Ryozuki> and cleaning the mess

what mess?

14:33

build should be simple cmake && make

<Ryozuki> the mess that vs2015 produces

14:33

<Ryozuki> 2017*

use a separate build directory and tell microsoft not to make a mess?

<Ryozuki> i cant, the program does what it wants

14:34

<Ryozuki> i built in a separate folder

14:34

<Ryozuki> yet it generates a bunch of folders on ddnet root folder

14:34

<heinrich5991> I'm currently installing msvs 2017, I'll check what went wrong

that sounds like a bug

<heinrich5991> I don't even know how it knows about the existence of that folder

14:35

<heinrich5991> other than the fact that it is the shared root of all source files

14:35

<Ryozuki> im gonna try from command line and using msbuild

14:36

<Ryozuki> oh

14:36

<Ryozuki> mmm

14:36

<Ryozuki> forget what i say

14:36

<Ryozuki> said*

14:37

<Ryozuki> (tried again, still makes folders on ddnet)

14:37

<heinrich5991> is the problem resolved?

14:37

<Ryozuki> no

14:37

<heinrich5991> I just aborted my installation of msvs 2017 ^^

14:37

<heinrich5991> meh

14:37

<Ryozuki> D:

14:38

<Ryozuki> im sry for confusing you

14:38

<Ryozuki> https://github.com/opencv/opencv/issues/7796

VS2017: CMake files are put outside the build directory · Issue #7796 · opencv/opencv

System information (version) OpenCV => GitHub master from today Operating System / Platform => Win 8.1 Compiler => VS2015-U3 CMake => 3.7.1 Detailed description & Steps to reproduce If you do an ...

14:38

<Ryozuki> ^

14:39

<Ryozuki> another project, with same issue

14:40

<Ryozuki> and this is the cmake bug issue https://gitlab.kitware.com/cmake/cmake/issues/16458

VS 2017: Incorrect Intermediate Directory for utility targets (#16458) · Issues · CMake / CMake

Using cmake-3.7.20161123-g250c3-win64-x64.msi from the nightly builds and generating project files for the Visual Studio 2017 Community Edition RC results in ZERO_CHECK and ALL_BUILD Intermediate Directories being incorrect. For example I...

14:40

<Ryozuki> (or looks like)

14:41

<Ryozuki> and yes, looks like its a vs bug

14:41

<Ryozuki> can't do nothing then

14:42

<heinrich5991> "This issue has been fixed and is now available in our latest update. You can download the update via the in-product notification or from here: https://www.visualstudio.com/vs/ Thanks to everyone who provided feedback, votes and solutions for this problem."

Visual Studio IDE

Fully-featured IDE for Android, iOS, Windows, web, & cloud. Learn more about Visual Studio's Integrated Development Environment. Free trial.

14:42

<heinrich5991> Ryozuki: could you try updating your vs? this post is from august the 14th

14:43

<Ryozuki> hmm maybe wait

14:43

<heinrich5991> "Closing this, as I can confirm this has been fixed in Visual Studio 15.3.0."

14:43

<Ryozuki> (i got 15.0 new is 15.3, hope this fixes it)

14:43

<heinrich5991> in the cmake issue

14:43

<Ryozuki> oh

14:43

<Ryozuki> nice

14:43

<Ryozuki> will update

14:45

<heinrich5991> sctt_: unfortunately there are quite some minor style issues remaining, but that shouldn't be hard to fix

14:45

<heinrich5991> I could either annotate the appropriate locations in the pull request

14:45

<heinrich5991> or, since I'm in an awesome mood today, fix it myself :)

14:46

<sctt_> xD

14:46

<heinrich5991> the former is probably better for you, the latter is easier for you :)

14:46

<Ryozuki> haha

14:46

<sctt_> if you tell me what's the problem i can fix it, np

14:46

<heinrich5991> kk, then let me begin the review :)

14:46

<sctt_> ok :D

14:46

<sctt_> i have to go out in 20 mins so i'll fix it tonight

14:47

<heinrich5991> sure, no pressure

14:47

<Ryozuki> i should have thought about updating before, my bad :/

14:47

<heinrich5991> np

<heinrich5991> deen: have you tried this function already? https://msdn.microsoft.com/en-us/library/windows/desktop/ms633543(v=vs.85).aspx

15:27

<deen> yeah, didn't work according to user reports

15:28

<deen> i think SDL2 has functions for dpi stuff, but they actually do nothing

15:29

<heinrich5991> this one? SDL_WINDOW_ALLOW_HIGHDPI

15:29

<deen> yes

15:29

<heinrich5991> https://wiki.libsdl.org/SDL_WindowFlags

15:29

<deen> it might be implemented on macosx, but apparently not yet on windows

15:33

<Ryozuki> updated vs and the bug is gone

15:33

<heinrich5991> good :)

15:34

<heinrich5991> I added a comment to the opencv issue: https://github.com/opencv/opencv/issues/7796#issuecomment-325700775 :)

VS2017: CMake files are put outside the build directory · Issue #7796 · opencv/opencv

System information (version) OpenCV => GitHub master from today Operating System / Platform => Win 8.1 Compiler => VS2015-U3 CMake => 3.7.1 Detailed description & Steps to reproduce If you do an ...

15:34

<Ryozuki> nice

15:35

<Ryozuki> tho the dlls arent on the output folder

15:35

<Ryozuki> but on the build folder

15:35

<Ryozuki> maybe its possible to add a postbuild command for vs to move these?

15:36

<heinrich5991> but can you start the programs from the msvs UI?

15:36

<Ryozuki> yep

15:37

<heinrich5991> then it should be good, right?

15:38

<Ryozuki> not if i run outside vs

15:38

<Ryozuki> cause dlls arent copied

15:38

<Ryozuki> to the output folder

15:39

<Ryozuki> https://stackoverflow.com/questions/9994045/copy-target-file-to-another-location-in-a-post-build-step-in-cmake

Copy target file to another location in a post build step in CMake

I have a dynamic library that gets a different name depending on configuration, specified in the CMake scripts by: set_target_properties(${name} PROPERTIES OUTPUT_NAME ${outputName}64)

15:39

<Ryozuki> smth like that would fix it

<Nimda> Zadrotos_final by Opana just released on Oldschool at 2017-08-29 18:21

<Toer> hey, it seems that my isp latley has problems with the master servers of tw, does anyone has a script to fetch the addresses i could put on my server, or already set up something like this?

<sctt_> heinrich5991: i've read your revision, that's great! but i have some doubts and observations about some point... can we brefly discuss?

19:04

<heinrich5991> sure

19:04

<sctt_> ok so, a general thing

19:05

<sctt_> many things you pointed out are about pieces of code i just copied from tw source

19:05

<sctt_> like LoadPNG and ExtractName

19:05

<sctt_> or general structure of main, it is from map_resave

19:06

<sctt_> does it mean i should also change also the methods i copied

19:06

<sctt_> or just change map_replace_image?

19:06

<heinrich5991> if you want, you can also change map_resave

19:07

<heinrich5991> but it would suffice if the new code is better :)

19:07

<heinrich5991> ddnet source code does have some dark corners that border on unreadability

19:07

<heinrich5991> but we won't fix it all at once, no big refactor or anything

19:08

<sctt_> ok so i will focus on the tool

19:08

<heinrich5991> sure :)

19:08

<sctt_> consider that the things you pointed out on LoadPNG and ExtractName

19:08

<sctt_> are like this also inside the main code

19:10

<heinrich5991> hm. maybe I'll do a follow-up fix of the main code

19:10

<sctt_> ok :D

19:10

<heinrich5991> extractname e.g. is from 2010 :)

19:10

<sctt_> than i have a couple of more questions

19:10

<heinrich5991> go ahead :)

19:10

<sctt_> where you say

19:10

<sctt_> "Is this line still needed?"

19:10

<sctt_> you are referring to an include list

19:11

<heinrich5991> yes

19:11

<sctt_> which include were you referring exactly?

19:11

<heinrich5991> to the graphics

19:11

<sctt_> oh

19:11

<heinrich5991> engine/graphics.cpp

19:11

<sctt_> thats for image info structure

19:11

<heinrich5991> .h

19:11

<heinrich5991> ah ok

19:11

<heinrich5991> so yes, it's still needed

19:11

<sctt_> ok^^

19:11

<sctt_> than

19:11

<sctt_> then*

19:12

<sctt_> This allocates and leaks the CMapItemImage. Either make it global (meh) or pass in a pointer. Ask me about this one if you don't know what to do. :)

19:12

<sctt_> why leakead? it is needed for datafile.addData

19:12

<sctt_> addItem sorry

19:12

<heinrich5991> leaked means: it is never deleted

19:12

<sctt_> yes but i dont want to delete it

19:12

<sctt_> cause it is needed

19:12

<sctt_> where datafile.Finished

19:13

<heinrich5991> after the call to additem, you don't need it anymore

19:13

<heinrich5991> additem makes a copy

19:13

<sctt_> oh

19:13

<sctt_> i didnt know that

19:13

<sctt_> i thought he kept the reference

19:13

<heinrich5991> yea, the joys of c/c++ :)

19:13

<sctt_> but i noticed, when i do getItem

19:13

<sctt_> i don't have a copy

19:13

<sctt_> i have his reference

19:14

<sctt_> that's why i thought it was the same with addItem

19:16

<heinrich5991> but even if it were the case, you'd still leak it after finish

19:16

<heinrich5991> – for every new you must have a delete somewhere

19:16

<heinrich5991> but in this case, it should be doable without new/delete

19:17

<sctt_> if that were the case, i would just have to delete the datawriter

19:17

<sctt_> his destroyer should deallocate the items i guess

19:18

<heinrich5991> no

19:18

<sctt_> so it doesnt :/

19:18

<sctt_> so i have to save all the items into an array and deallocate them after the finish

19:18

<heinrich5991> or jsut don't allocate using new at all

19:19

<sctt_> but considering that after the .finish the program quits and all its memory willl be released, i dont think its worth it

19:19

<sctt_> i can't not allocating them

19:19

<sctt_> the function needs the return a void pointer

19:19

<sctt_> and i can't use the same Item i'm reading, i have to clone it into another memory area

Did you ever think about some kind of Code Reformatter? To standardize whole code, at least in structure? Without changing naming convention?

<sctt_> i know that because before i was using the same Item

19:20

<sctt_> and the result map was messy, cause the reader probably was doing his calculation on the item i modified while i shouldnt have done that

19:20

<sctt_> so i decided to clone it instead of directly modify it

19:20

<sctt_> and that solved the problem

19:21

<heinrich5991> you could passi n a pointer to a CMapItemImage

19:21

<heinrich5991> given by the caller

19:21

<heinrich5991> and just write in there

19:21

<heinrich5991> the caller just puts the CMapItemImage on the stack

19:21

<heinrich5991> like CMapItemImage Buffer;

19:22

<sctt_> yes but it is the main who does addItem

19:22

<sctt_> so the new Item can't be destroyed by the ReplaceItemFunction

19:22

<heinrich5991> ReplaceImageItem(.., &Buffer);

19:23

<sctt_> oh

19:23

<sctt_> so add a new parameter on ReplaceImageItem

19:23

<sctt_> referring to the new Item

19:24

<sctt_> that will oblige me to do more checks inside the main

19:24

<sctt_> to see if it is allocated

19:24

<heinrich5991> (feel free not to fix ExtractName if you mean)

19:24

<heinrich5991> *if you want

19:25

<heinrich5991> not really

19:25

<sctt_> why? you want to fix it? xD

19:25

<heinrich5991> I can fix it later, yes

19:25

<heinrich5991> see, you can do it like this:

19:26

<heinrich5991> ReplaceImage item works like before, but gets passed the pointer to CMapItemImage *pBuffer

19:26

<heinrich5991> if you change the image stuff, just return pBuffer

19:26

<heinrich5991> if not, do the stuff like before

19:27

<heinrich5991> this way, you either get back a pointer to the Buffer (which is a variable in main) or to the DatafileReader item

19:27

<heinrich5991> you don't have to deallocate either of these, so you don't need any extra code in main

19:27

<sctt_> so you mean

19:27

<sctt_> the main will create the new CMapItemImage

19:28

<sctt_> as an object

19:28

<heinrich5991> without any "new" keywords involved

19:28

<heinrich5991> yes

19:28

<sctt_> and pass it as a pointer

19:28

<heinrich5991> yes

19:28

<sctt_> and the function will return that pointer

19:28

<sctt_> if it was actually the wanted item

19:28

<sctt_> yeah that could work :D

19:29

<sctt_> heinrich5991: ok that's clear now

19:30

<heinrich5991> cool

19:30

<sctt_> heinrich5991: last question, you said to print messages like usage

19:30

<sctt_> what do you use in ddnet for that?

19:30

<sctt_> dgb_msg?

19:30

<heinrich5991> just use dbg_msg

19:30

<heinrich5991> doesn't look nice, but it's something

19:30

<sctt_> ok^^

19:30

<sctt_> so i will have to compile in debug mode to see them, correct?

19:31

<heinrich5991> no, it always displays them

19:31

<sctt_> oh good

19:31

<sctt_> in stderr?

19:31

<sctt_> or stdout?

19:31

<heinrich5991> no, stdout

19:31

<heinrich5991> IIRC

19:31

<sctt_> okok

19:31

<sctt_> very last question xD

19:31

<sctt_> you said you want to fix ExtractName

19:31

<sctt_> so should i still fix LoadPNG?

19:32

<sctt_> it's a tw pasted code that too

19:32

<heinrich5991> yes, that seems very easy to fix

19:32

<sctt_> ok cool^^

19:33

<sctt_> ok so i will start to rework the code in a while and let you know :D

19:34

<heinrich5991> cool

19:34

<heinrich5991> just ping me on github when you're done

heinrich5991

[ddnet/ddnet] Issue opened: #846 Fix `ExtractName` after #844 lands

#844

<sctt_> heinrich5991: curiosity, if you are using hungarian notation, why you don't put 'n' before integers? xD

20:47

<heinrich5991> it's only used to distinguish where a variable comes from in TW

20:47

<heinrich5991> g for globals, m for members, s_ for statics

20:47

<heinrich5991> and then a for arrays and p for pointers, mh.

20:47

<sctt_> yeah that's hungarian notation

20:48

<sctt_> you use it everywhere but not for integers

20:48

<sctt_> xD

<sctt_> @heinrich5991 you still here?

21:52

<sctt_> heinrich5991:

21:52

<heinrich5991> yes

21:52

<heinrich5991> :)

21:52

<sctt_> :)

21:52

<sctt_> i've finished the fixes

21:52

<sctt_> but...

21:52

<sctt_> i've noticed i don't get any output from dbg_mesg

21:52

<sctt_> :/

21:53

<heinrich5991> put dbg_logger_stdout() into your main function

21:54

<heinrich5991> before any dbg_msg statements

21:55

<sctt_> ok :D

21:56

<sctt_> heinrich5991: oh god

21:56

<sctt_> i've got like 10 lines of garbage

21:56

<sctt_> like [2017-08-29 23:50:47][storage]: added path '$USERDIR' ('/root/.teeworlds')

21:56

<heinrich5991> that's ok

21:56

<heinrich5991> WAIT

21:56

<heinrich5991> why do you execute stuff as root?

21:56

<sctt_> well if he spams, maybe i should spam too xD

21:56

<sctt_> i'm on a VM

21:56

<heinrich5991> ok

21:57

<heinrich5991> (still doesn't hurt to use a user account, but ok)

21:58

<sctt_> it's a live

21:58

<sctt_> he has only root by default

22:01

<sctt_> heinrich5991: it's ok for you to use this style?

22:01

<sctt_> https://ibb.co/bQ36U5

22:02

<heinrich5991> mhmh. dbg_msgs are usually one line

22:02

<heinrich5991> if you do it this way, the first line will have [] stuff and the others won't

22:02

<heinrich5991> is that intended?

22:02

<sctt_> heinright591: maybe i will just issue more dbg_msgs?

22:03

<heinrich5991> yea

22:03

<sctt_> ok :)

22:03

<heinrich5991> but if(!pStorage) doesn't really fit there ^^

are you programming with nano? :o

<sctt_> Ryozuki: well to be honest when i started this i didn't think i would take it that seriously xD

why not vim?

22:06

"I've been using vim for about 2 years now, mostly because I can't figure out how to exit it."

22:06

funny :)

<heinrich5991> :)

22:07

<sctt_> hahahha

22:07

<sctt_> well the reality is that i've always used nano and never found a reason to switch to vi, even if i've used it a couple of times

well its all personal preference, my eyes wouldnt stand with that green :P

<sctt_> i know vi is more powerful, but in a way i've never found indispensable

22:08

<sctt_> Ryozuki: well the colors are configurable

ik :P

<sctt_> Ryozuki: i like retro green xD

<sctt_> heinrich5991: i've pushed :P

22:32

<heinrich5991> great :)

22:32

<heinrich5991> couple of things:

22:32

<heinrich5991> I still see some of the code indented with 8 spaces instead of tabs

22:32

<heinrich5991> DataWriter and DataReader should get a g_ prefix

22:33

<heinrich5991> it really doesn't hurt to declare the variables in the main function a bit later, at their use site

22:33

<heinrich5991> i.e. in the loops

22:33

<heinrich5991> but that's it, I think :)

22:33

<heinrich5991> sctt_: ^

22:34

<sctt_> i noticed the spaces, i'm fixing now

22:34

<sctt_> xD

22:34

<sctt_> ok for data

22:40

<sctt_> heinrich5991: ok done^^

22:42

<heinrich5991> ok, looks good now. you really like nonlocal variables, aha :)

22:42

<heinrich5991> sctt_: the newest commits are made by root@term.station

22:42

<heinrich5991> if that's ok, I'll go ahead and merge

22:42

<sctt_> "you really like nonlocal variables" what do you mean? xD

22:42

<sctt_> oooh

22:43

<sctt_> sorry i've read non-canonical, i don't know why :/

22:43

<sctt_> i hate globals, i never use them

22:43

<sctt_> i've not for a piece of code that does only one thing and it's under 100 lines xD

22:43

<heinrich5991> not what I mean, I ment that you declare all your variables at the start of the main function instead of in the loops where they're used

22:45

<sctt_> i did that only because it was like this on the code i started and you didn't tell me to move them

22:45

<sctt_> i'm trying to do things as you are used to :/

22:46

<sctt_> there are people who likes to have data list in the top part xD

22:46

<heinrich5991> anyway, [00:42:15] <@heinrich5991> sctt_: the newest commits are made by root@term.station

22:46

<heinrich5991> is that ok or do you want to change that?

22:47

<sctt_> i don't really care about the name, i would change only if you prefer that

22:47

<heinrich5991> nah, d/c

22:47

<sctt_> ok^^

22:48

<heinrich5991> I'll wait for the travis ci build to finish before merging

22:48

<heinrich5991> should hopefully be done in a couple of minutes ...

22:48

<sctt_> ok :)

22:48

<sctt_> to be honest i'm surprised you are interested in map_image_replace tool

22:49

<sctt_> i hadn't think about a merge when i wrote it

<heinrich5991> w/e build still not started, will go to sleep and merge tomorrow

23:02

<heinrich5991> good night sctt_

23:02

<sctt_> yeah no pressure

23:02

<sctt_> goodnight and thanks!

23:02

<heinrich5991> thanks for the pull request! :)

23:02

<sctt_> :)

@everyone Countdown for DDNet!!! 21days 10hours 20 minutes