Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2017-04-24 00:00:00Z and 2017-04-25 00:00:00Z
Avatar
<deen> Learath2: i will only merge /invite in again if it gets fixed for spamming
08:58
<Learath2> you already fixed the spamming by removing uninvite
08:58
<deen> every command that produces chat messages needs to be spam-filtered
08:58
<deen> no, that did not fix it
08:58
<deen> i got reports that you could still cause spam by using a few more commands in combination
08:58
<Learath2> the only person you can spam with it is yourself
08:59
<deen> something like /invite;lock;lock;invite;lock;lock;invite;lock;lock etc
08:59
<Learath2> well you can spam as fast as you can switch teams
08:59
<Learath2> i don't see any other way
08:59
<Learath2> huh
08:59
<Learath2> i'll check it out
09:00
<Learath2> see instead of nuking it out of the orbit just because you don't use it you could have just told me the combination
09:00
<deen> that was a quick fix
09:00
<deen> i don't think we have a flag for disabling it or i would've used that
09:00
<deen> because i got reports from people being spammed again
Avatar
ᶰ°Konͧsti 2017-04-24 09:01:07Z
Maybe allow only one invite per player until he /agree or /disagree ?
Avatar
<Learath2> fixed
09:03
<Learath2> atleast that one combination
09:07
<deen> as I said, make sure it uses spam protection
Avatar
Now the GUI mute behaves like add_foe, which is persisted to disk.
Avatar
<Learath2> deen: i did ask for help on that i just wasn't sure where the rate limiting belonged
09:48
<Learath2> if i limit the command then inviting a big team takes too long, if i limit it per person i wouldn't be able to use a bitmask anymore
10:28
309d47e Revert "Remove invite system entirely since no ... - Learath2 89199d0 Fix invite spam by abusing lock. - Learath2 c610b5f Merge pull request #748 from Learath2/dd_pr_inv... - def-
Avatar
<deen> Learath2: well, not sure how to fix it then
Avatar
ᶰ°Konͧsti 2017-04-24 11:26:10Z
/lock should not be delayed
11:26
If you have planned to change this ofc xd
Avatar
<Learath2> lock is not delayed
Avatar
i like coords
Avatar
ᶰ°Konͧsti 2017-04-24 11:29:02Z
I know, just saying if you want To fix spam by delay it
11:29
But yes you are not dumb i know
11:36
f5c4a6b Add show more precise coords in debug - d3fault 716b61d Merge pull request #750 from d3fault/more-preci... - def-
Avatar
Suggestions on how to fix the annoying voting stuff? (see #off-topic)
Avatar
lifeban SP | Someone
Avatar
<Learath2> mfw i have to go to discord again :D
Avatar
Limitation? By nickname, for example you can vote 3 times, then you have to wait some magic time (like 5 minutes or so)
Avatar
hardcode a ban on the name "SP | Someone"
Avatar
<Learath2> isnt there a frequency thing on votes already?
Avatar
yea, 30 seconds?
Avatar
ᶰ°Konͧsti 2017-04-24 11:53:49Z
Mol?
Avatar
and always every 30 seconds if i remember
Avatar
ᶰ°Konͧsti 2017-04-24 11:54:02Z
180 seconds
11:54
And 50 after join
Avatar
i meant, some kind of ban to vote for more time
11:54
ok, so It was on Vanilla then (haha)
Avatar
<Learath2> and how does he bypass the timer?
Avatar
hes a hacker
Avatar
<Learath2> ask him he likes to brag about it
Avatar
ᶰ°Konͧsti 2017-04-24 11:55:03Z
Ah, the delay is only for failed votes
Avatar
@bob1 they don't want to ban names 😢
😢 1
Avatar
ᶰ°Konͧsti 2017-04-24 11:55:25Z
Lol, he can just take another Name omg
Avatar
<Learath2> well lets make the delay for all votes
Avatar
ᶰ°Konͧsti 2017-04-24 11:55:43Z
No
Avatar
why not?
Avatar
<Learath2> b/c konsti likes to oppose me for no reason :)
Avatar
ᶰ°Konͧsti 2017-04-24 11:56:13Z
Learath, just make it like:
Avatar
and one mor
Avatar
add a vote delay on succsesfull votes
Avatar
He's voting himself
11:57
his dummy
Avatar
ᶰ°Konͧsti 2017-04-24 11:57:21Z
For kickvotes need to be 5 players on Server, make it so that in a team also need to be 5 players or just disable votes in team
Avatar
maybe we should disable possibility to vote characters on same IP?
Avatar
good idea he only has 1 ip
Avatar
<Learath2> actually why do we even allow kick in teams?
Avatar
disable specvotes too
11:57
ez fix
Avatar
Learath2, it is allowed ?
Avatar
disable all votes and chatting ez fix all bugs
Avatar
ᶰ°Konͧsti 2017-04-24 11:58:21Z
Just kick and specvotes in team need to be disabled, they are unnecessary
Avatar
<Learath2> matricks had a branch without nicknames for tees and no chat
Avatar
<Learath2> anonymous teeworlds
Avatar
We should try it
11:59
Everyone would have same amount of points
11:59
😃
12:00
The first solution, should be to disable self-voting (even with dummy)
Avatar
<Learath2> if i call for a vote inside a team do other people see the vote?
12:19
<deen> yes
12:19
<deen> the current system only allows for 1 vote and everyone sees that
12:19
<Learath2> and do other people get to vote?
12:19
<deen> no
12:19
<Learath2> do you happen to know where we make that happen?
Avatar
ᶰ°Konͧsti 2017-04-24 12:19:54Z
So just hide it?
Avatar
<deen> i remember writing it, i don#t remember where^^
12:20
<deen> even if you hide it, then no one else can vote while someone is doing that
12:20
<deen> there are a few approaches:
12:20
<deen> 1. allow 1 vote per team at once
12:20
<deen> 2. don't allow voting within team at all
12:21
<deen> 3. delay even after successful vote
12:21
<Learath2> i'd go with 2 but i can't seem to find where we did that :P
12:21
<deen> gamecontext.cpp, CL_CALLVOTE
Avatar
ᶰ°Konͧsti 2017-04-24 12:22:00Z
I think voting in a team has no need am i right? You can just join another team or use /save if u want an afk guy awax
Avatar
<deen> yeah, we used to kick people out of a team, but if there's invite that's not really neded
12:23
<Learath2> deen: yeah can prevent it there but we'd have some unnecessary logic somewhere in the voting code leftover
12:23
<Learath2> maybe we should let people within teams vote but like all other people
12:24
<deen> don't understand that
12:24
<Learath2> let them vote in team0 votes and let them vote for people in team0
12:24
<deen> easy way to find a place in the code: trigger the situation on a server and grep for the error message in code
12:25
<deen> but it should just be in gamecontext.cpp
Avatar
ᶰ°Konͧsti 2017-04-24 12:25:30Z
Would be unfair if Team 0 trolls can kick teamplayers
Avatar
<deen> search for GetDDRaceTeam(ClientID) within the vote calling
12:26
<Learath2> how do you account for the team when counting the votes?
12:26
<Learath2> thats what i'm after
12:27
<deen> well, i showed you
12:27
<deen> each player just has a flag if they votes yes/no/nothing yet
12:27
<deen> and we just iterate over all players and ignore those in another team
12:32
<Learath2> well are we okay with "no votes in team, no votes affecting team members"
12:33
<deen> not sure, have to think through all the consequences
12:34
<deen> what if you play in a team for a few hours, one guy dies and goes afk, while lying in freeze
12:34
<deen> now the team can never finish
12:34
<deen> usually they would just vote him to spec or kic khim
Avatar
they can save and kick vote him in team 0 then
Avatar
<Learath2> cant load the team tho
12:34
<deen> haha
Avatar
replace him with dummy
12:34
or some other guy
Avatar
<deen> that's a ridiculous workaround
12:35
<deen> shouldn't have to resort to that
12:35
<Learath2> well team votes should only move to team 0
12:36
<deen> yeah, but if the server has /spec enabled then you can't move to spec
12:36
<deen> so you'd have to modify the kick behavious to move them to team 0 instead
12:36
<deen> and the /spec-enabled spec vote is weird anyway, i'm not sure it even works at all
12:36
<Learath2> it doesn't work now but it works in my pull req :P
12:37
<Learath2> yeah we'd need to modify the kick behaviour but the word is still suitable :) You get kicked out of the team
Avatar
<deen> sounds ok
Avatar
<Learath2> i have no idea how to make that happen without rewriting a lot of the vote code :/
12:54
<deen> line 2291 etc
12:54
<deen> move to eam 0 instead of kick/ban
Avatar
oh are we okay with 1 concurrent vote?
Avatar
<deen> yeah, i guess
13:00
<deen> it's good when everyone can see what votes are going on
13:00
<deen> then mods can observe
13:00
<deen> and otherwise we need to complicate the code even more
Avatar
"one cant vote people from their ip" does that sound fair?
Avatar
What you mean
Avatar
i can't vote my own dummy f.e.
Avatar
I said that
13:25
look ad SP
13:25
he voting himself
Avatar
<deen> just connect from multiple ips
Avatar
and in as a result, he's spamming by voting
13:25
or maybe i still don't understand what you want to say 😄
Avatar
<deen> Learath2: that's a bad idea, what if your brother is afk and you want to move him to spec?
Avatar
it's possible, to check if its your dummy?
Avatar
well no not reliably atleast
13:32
I don't know, if your brother
13:32
is afk
13:33
you can go to his comptuer
13:33
and go spec
13:33
xD
13:33
Unless you are lazy as fu...
13:34
so it shouldn't be problem, to disable self-voting (on same ip)
Avatar
<deen> ok, what if you're from a country that has a single IP address for all citizens?
Avatar
those exist?
13:35
anyways it doesn't fix any problem
Avatar
<deen> (you don't want to get kicked then, but spec-vote would be ok)
Avatar
no need to remove self-voting
Avatar
<deen> Quatar?
13:36
<deen> but they use a few more addresses nowadays
13:36
<deen> "This is the IP address for the entire nation of Qatar. As such it is a very sensitive IP address to block and any prolonged blocks are likely to wind up in the news. As such please exercise extreme caution when deciding to block this IP address."
13:37
I was talking about this problem
13:37
self-voting -> spamming
13:38
so, we can make exceptions?
13:38
for Qatar, for example
Avatar
<heinrich5991> self-voting is not necessarily spamming, is it?
13:39
<deen> no, just don't forbid spec-voting your own ip
Avatar
my 2ct, a window of last votes (maybe last 5) and add time limitation if the length between the current and the first vote is too small.
Avatar
hey, just wanted to throw idea, could you please add some command that would lock team only if it is locked already? or just modify currently existing /lock so I can do /lock 1 and it won't unlock
13:55
>lock team only if it not locked already *
Avatar
<deen> i don#t understand
13:55
<deen> just use /lock 1 or /lock 0?
13:56
it didn't work recently :x maybe i misstyped
13:56
nvm then
Avatar
Again self-voting
Avatar
can I invite more ppl like /invite A B C?
14:07
that sounds like a nice idea
14:07
will look into it after i fix the vote stuff
Avatar
what if someone has space in nickname?
Avatar
people have spaces in names that's why i am asking
Avatar
/invite "test test"
14:07
?
14:07
but then, someone could have " in nickname as well
Avatar
escaping obviously
14:09
/invite "\"test\"" (edited)
Avatar
not everyone will know
Avatar
well you'll have to invite one by one
Avatar
escaping isn't that obvious
Avatar
<heinrich5991> CookieAlex: /invite test test should work even today
Avatar
I guess you meant @xPapla
Avatar
<heinrich5991> oh, didn't see the suggestion, nvm
Avatar
https://github.com/ddnet/ddnet/pull/751 does it mean I won't be able to do: "say /team 37; say /lock 1; say /invite CookieMichal; say /invite CookieAlex; say /invite W33Ð; say /invite CookieAlex²" ? (edited)
Avatar
exactly
Avatar
<deen> btw, get rid of all those says
14:25
<deen> just use say /team 37;lock 1;invite foo;invite bar
14:25
<deen> (I think)
Avatar
i couldn't find a way to limit it per person without writing way too complex code
Avatar
deen: doesn't really work :v
Avatar
<deen> too bad
Avatar
i'd need to keep an array of ticks
Avatar
<deen> Learath2: not saying that's a good idea, but 64bit bitfield?
14:26
<deen> hm, no
Avatar
i have an 64bit bitfield now
14:27
per team
Avatar
with tick() you get integer?
Avatar
if i want rate limiting per person i'd need an array 64 of ticks to keep when you invited someone
Avatar
64x64 array :v
Avatar
not too nice 😄
Avatar
<deen> ask heinrich5991 what he thinks!
Avatar
or do it teamspeak way
14:34
everytime you invite someone you get some points (let's say 200) and when you go over limit (let's say 500) you can't invite anyone until it goes back to 0
14:34
and on each tick u get -1
Avatar
heinrich5991 what do you think
Avatar
<heinrich5991> I'm currently in a lecture /o\
14:36
<heinrich5991> ask me again in 10min
Avatar
<heinrich5991> 10min over
Avatar
if i want to ratelimit invites per player i need an array 64 of ticks on each player
15:17
heinrich5991 ^^
15:22
thats 8byte tick * 64 players * 64 players = 33KB of data 😛
Avatar
<heinrich5991> mh
Avatar
<deen> I disabled /spec for now
15:36
<deen> ehm, spec-vote
15:36
<deen> not /spec
Avatar
ᶰ°Konͧsti 2017-04-24 15:38:43Z
How long will it take to allow kickvotes again? Its really annoying
Avatar
<heinrich5991> we could disable saves instead
15:39
<heinrich5991> until we figure out the correct solution to that load problem and test it
Avatar
ᶰ°Konͧsti 2017-04-24 15:39:33Z
What load Problem?
15:40
Ah yes
Avatar
we figured out 3 solutions
15:40
can we just chose one and test it now?
Avatar
ᶰ°Konͧsti 2017-04-24 15:41:05Z
If you want to load a savegame the players have to /agree first maybe?
Avatar
we have that, we have players must be teamed up beforehand, and all need to /load passwd
15:41
first two are already in pullreqs but not tested
Avatar
<heinrich5991> Learath2: if you invite people to a team, why can you even invite them again?
15:42
<heinrich5991> irc client broke
Avatar
you can't
Avatar
ᶰ°Konͧsti 2017-04-24 15:42:26Z
Solution 2 is my Favorite if u can get loaded in your Favorite team
15:42
And not in random team with ugly colour x)
Avatar
heinrich5991 i already fixed the spams we know about but deen doesn't seem to be convinced 😃
15:43
heinrich5991 aa3690a632dd9cbd5e8c58faf016a9f282f5317b can you cherry pick this?
Avatar
<heinrich5991> link plz
Avatar
i forgot to put it in the last pr
15:44
the rest of the pr is questionable but should get the first one atleast
Avatar
<heinrich5991> Learath2: so, invite is currently enabled and you want that commit in?
15:53
<heinrich5991> and what was deen's opinion about that?
Avatar
deen merged invite
16:01
before i could get that commit in
16:01
without that you can block teams forever
Avatar
ᶰ°Konͧsti 2017-04-24 16:02:03Z
Nice!
Avatar
<deen> I just noticed that the mozilla irc server is really unfriendly
17:09
<deen> "This server is for use by Mozilla developers, testers, and users. If you are not one, please find another server."
Avatar
<Ryozuki> i guess they have lot of chrome users?
17:22
<Ryozuki> "Mozilla runs an IRC server to host channels for discussion of topics related to the Mozilla project. "
17:23
<Ryozuki> i find it logic
17:23
<deen> but you're not allowed if you don't use Firefox or another Mozilla product^^
17:23
<Ryozuki> if u dont, why would u go there?
17:23
<deen> I'm there to listen in on rust discussions
17:24
<deen> but I'm not even a rust user
17:24
<deen> luckily i coincidentally use firefox, otherwise I'd have to leave
17:24
<Ryozuki> well, u don't have to tell you dont use them :)
Avatar
spying on rust discussions to steal their ideas and implement them in nim?
Avatar
<deen> sure, but it's just a ridiculous rule to have
17:25
<Ryozuki> that sure went to Learath2 ? :D (joke)
17:25
<Ryozuki> nim doesn't suck
17:26
<Ryozuki> i like custom operators
Avatar
who wrote smh and tried to delete it?
Avatar
<heinrich5991> smh?
Avatar
I was tempted to convert the number into 0->359 but I just left it in whatever format it's already in
Avatar
meant to write something
Avatar
<heinrich5991> why aren't you on irc btw? ^^
Avatar
other computer
Avatar
does anyone knows a shop where i can buy a pi zero w inexpensively? (edited)
Avatar
I will steal it for you
Avatar
really? 😍
Avatar
<heinrich5991> are they in stock again?
Avatar
I dont know, but I want one
Avatar
Rust took 14gb of memory crashed my browser and steam...
Avatar
Yeah, sweety ❤
19:18
Rust? This all-the-time in alpha
19:18
game?
19:18
sorry
19:18
in early access
Avatar
<heinrich5991> rust-the-language or rust-the-game? ^^
Avatar
I guess the game
19:19
since programming languages usually arent on steam
19:20
🤔
19:21
or maybe
19:21
he just compiled something
19:21
it took 14gb memory
19:21
and crashed browser and steaem
19:21
😮
Avatar
forkbomb?
Avatar
<Ryozuki> :(){ :|: & };:
Avatar
void main(){while(1){fork();}}
Avatar
<heinrich5991> *int main
19:24
<heinrich5991> plz
19:24
<Ryozuki> xD
Avatar
¯\_(ツ)_/¯
Avatar
<heinrich5991> int main(void) if you're coding c
Avatar
i would like to learn c or c++ 😦
19:24
but im so laaazy
Avatar
:(){ :|:& };: \_/| |||| ||\- ... the function ':', initiating a chain-reaction: each ':' will start two more. | | |||| |\- Definition ends now, to be able to run ... | | |||| \- End of function-block | | |||\- disown the functions (make them a background process), so that the children of a parent | | ||| will not be killed when the parent gets auto-killed | | ||\- ... another copy of the ':'-function, which has to be loaded into memory. | | || So, ':|:' simply loads two copies of the function, whenever ':' is called | | |\- ... and pipe its output to ... | | \- Load a copy of the function ':' into memory ... | \- Begin of function-definition \- Define the function ':' without any parameters '()' as follows:
Avatar
i never have idea, what could i do. so stupid
Avatar
thanks for the copy pasta @Ryozuki
Avatar
what the fuck is that
Avatar
<Ryozuki> xD, its well formated on discord
19:25
<Ryozuki> the explanation of the forkbomb isent
Avatar
no shit
19:25
everyone knows unix forkbomb :l
Avatar
but not why it is like that
Avatar
alright alright
Avatar
i didn't knew
19:26
😦
Avatar
have you ever been using linux?
Avatar
<heinrich5991> Savander: have you tried any programming language already? :)
Avatar
<Ryozuki> php
Avatar
i am PHP programmer already
Avatar
<Ryozuki> right?
19:28
<Ryozuki> :P
Avatar
so how is everyone doing tonight?
Avatar
I used linux
19:29
but rather to nginx
19:29
than to make scripts
Avatar
what's nginx?
Avatar
3878d6f Reset invites when the team is empty - Learath2
Avatar
nginx?
19:31
http server
Avatar
rust the game 😛
Avatar
i have tested nginx-rtmp-module
19:32
Livestreaming on your own! oh yea!
Avatar
I prefer to write my own http servers ¯\_(ツ)_/¯
Avatar
i know, node.js
Avatar
or java ee
Avatar
then great. I can't do it
19:33
so i using nginx
19:33
or apache2
19:33
maybe someday
Avatar
probably not
19:34
Iam to lazy
Avatar
<heinrich5991> Learath2: cherry-picked it
heartw 1
Avatar
thx :3
Avatar
nginx is good
heartw 2
Avatar
i suggest to learn brainfuck programming language
Avatar
hello
👞 1
Avatar
<deen> Welf: Good, you can even combine brainfuck with nim: http://howistart.org/posts/nim/1/
Avatar
nimfuck?
Avatar
have to admit that irc<-->discord bridge was very good idea
Avatar
I agree
Avatar
<deen> feels like irc gets spammed a lot now, not sure how the quiet irc majority feels about that
Avatar
noone forces anyone : P
Avatar
<Ryozuki> well, that irc majority never talks :o
Avatar
bob, go troll on #off-topic
Avatar
don't delete messages as they stay in logs T_T
Avatar
waht logs
Avatar
irc logs
Avatar
this is discord
Avatar
can we kick him?
Avatar
sry for calling you noob
20:23
pls forgive me
Avatar
S I L I C O N V A L L E Y S E A S O N 4 E P I S O D E 1 ! ! ! !
Avatar
<Ryozuki> dont spam
Avatar
It's one message
20:46
using that logic, your reply is also considered spam
🤔 1
Avatar
<Ryozuki> ur message looks horrible on irc
Avatar
cant confirm that
Avatar
@Learath2 in case you need MySQL DB, tell me
Avatar
i'll aquire some sleep then i'll get an sql db and test :/
22:12
i really hate setting up sql 😄
Avatar
<heinrich5991> deen: indeed a lot of spam ^^
Avatar
500MB is enough?
22:25
will pm you
Avatar
<necropotame> Is the Discord now acceptable ? Last time it was just a stream of insult
Avatar
Still is it. 😦
Exported 393 message(s)